From 6f635b46fd868a9684136ac79b393d5cdfa7eb59 Mon Sep 17 00:00:00 2001
From: William Casarin <jb55@jb55.com>
Date: Fri, 24 May 2019 02:57:30 -0700
Subject: [PATCH] gossipstore: fix uninitialized input fd
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Initialize infd to STDIN_FILENO if the input file argument is missing.

Caught with gcc version: 7.4.0

devtools/create-gossipstore.c: In function ‘main’:
devtools/create-gossipstore.c:130:9: error: ‘infd’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
  while (read_all(infd, &be_inlen, sizeof(be_inlen))) {

Suggested-by: @ZmnSCPxj <https://github.com/ElementsProject/lightning/pull/2674#issuecomment-495617253>
Signed-off-by: William Casarin <jb55@jb55.com>
---
 devtools/create-gossipstore.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/devtools/create-gossipstore.c b/devtools/create-gossipstore.c
index 9fc6f90df..956724f1e 100644
--- a/devtools/create-gossipstore.c
+++ b/devtools/create-gossipstore.c
@@ -115,6 +115,8 @@ int main(int argc, char *argv[])
 		if (infd < 0)
 			err(1, "opening %s", infile);
 	}
+	else
+		infd = STDIN_FILENO;
 
 	if (outfile) {
 		outfd = open(outfile, O_WRONLY|O_TRUNC|O_CREAT, 0666);