aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-02-07 07:04:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

wallet: don't try to set a timer past 2038 on 32-bit platforms.

Browse Source 
It'll wrap, probably be in the past, and infinite loop.  This was caused by an invoice
with expiry set at 2076.  This wrap caused us to think the expiry has already
passed, and keep looping!

Reported-by: @telelvis
Fixes: #6339
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: lightnind: don't infinite loop on 32 bit platforms if only invoices are expiring after 2038.
This commit is contained in:
Rusty Russell
2023-06-23 16:47:40 +09:30
parent 910630c497
commit 336dcef541
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
wallet/invoices.c
View File

@@ -225,6 +225,11 @@ static void install_expiration_timer(struct invoices *invoices)
memset(&expiry, 0, sizeof(expiry));
expiry.ts.tv_sec = invoices->min_expiry_time;
/* Hi! On a 32 bit time_t platform with an expiry after 2038? Let's
* not set a timer, assuming you'll upgrade before then! */
if (expiry.ts.tv_sec != invoices->min_expiry_time)
goto done;
/* now > expiry */
if (time_after(now, expiry))
expiry = now;