aljaz/cdk
1
0
Fork 0
mirror of https://github.com/aljazceru/cdk.git synced 2026-02-05 13:16:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(mint): check sig flag even if no inputs included

Browse Source
This commit is contained in:
thesimplekid
2024-08-13 02:28:23 +01:00
parent 3ea0c4c7ea
commit 62e0879d8c
1 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
crates/cdk/src/mint/mod.rs
View File

@@ -857,26 +857,6 @@ impl Mint {
&self,
melt_request: &MeltBolt11Request,
) -> Result<MeltQuote, Error> {
let ys: Vec<PublicKey> = melt_request
.inputs
.iter()
.flat_map(|p| hash_to_curve(&p.secret.to_bytes()))
.collect();
// Ensure proofs are unique and not being double spent
if melt_request.inputs.len() != ys.iter().collect::<HashSet<_>>().len() {
return Err(Error::DuplicateProofs);
}
self.localstore
.add_proofs(melt_request.inputs.clone())
.await?;
self.check_ys_spendable(&ys, State::Pending).await?;
for proof in &melt_request.inputs {
self.verify_proof(proof).await?;
}
let state = self
.localstore
.update_melt_quote_state(&melt_request.quote, MeltQuoteState::Pending)
@@ -892,6 +872,26 @@ impl Mint {
}
}
let ys = melt_request
.inputs
.iter()
.map(|p| hash_to_curve(&p.secret.to_bytes()))
.collect::<Result<Vec<PublicKey>, _>>()?;
// Ensure proofs are unique and not being double spent
if melt_request.inputs.len() != ys.iter().collect::<HashSet<_>>().len() {
return Err(Error::DuplicateProofs);
}
self.localstore
.add_proofs(melt_request.inputs.clone())
.await?;
self.check_ys_spendable(&ys, State::Pending).await?;
for proof in &melt_request.inputs {
self.verify_proof(proof).await?;
}
let quote = self
.localstore
.get_melt_quote(&melt_request.quote)
@@ -933,13 +933,13 @@ impl Mint {
keyset_units.insert(keyset.unit);
}
let EnforceSigFlag { sig_flag, .. } = enforce_sig_flag(melt_request.inputs.clone());
if sig_flag.eq(&SigFlag::SigAll) {
return Err(Error::SigAllUsedInMelt);
}
if let Some(outputs) = &melt_request.outputs {
let EnforceSigFlag { sig_flag, .. } = enforce_sig_flag(melt_request.inputs.clone());
if sig_flag.eq(&SigFlag::SigAll) {
return Err(Error::SigAllUsedInMelt);
}
let output_keysets_ids: HashSet<Id> = outputs.iter().map(|b| b.keyset_id).collect();
for id in output_keysets_ids {
let keyset = self