aljaz/btcpayserver
1
0
Fork 0
mirror of https://github.com/aljazceru/btcpayserver.git synced 2026-02-14 10:44:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Making sure we don't register same invoice multiple times

Browse Source
This commit is contained in:
rockstardev
2020-09-17 00:18:18 -05:00
committed by Kukks
parent f177a39b96
commit d9872bc94d
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
BTCPayServer/Services/Shopify/OrderTransactionRegisterLogic.cs
View File

@@ -16,16 +16,17 @@ namespace BTCPayServer.Services.Shopify
_client = client;
}
public async Task<dynamic> Process(string orderId, string currency = null, string amountCaptured = null)
public async Task<TransactionsCreateResp> Process(string orderId, string invoiceId, string currency = null, string amountCaptured = null)
{
var resp = await _client.TransactionsList(orderId);
var txns = resp.transactions;
if (txns != null && txns.Count >= 1)
// only register transactions if first, parent_id transaction is present and we haven't already registered transaction for this invoice
if (txns != null && txns.Count >= 1 && !txns.Any(a => a.authorization == invoiceId))
{
var transaction = txns[0];
if (currency != null && currency.ToUpperInvariant().Trim() != transaction.currency.ToString().ToUpperInvariant().Trim())
if (currency != null && currency.ToUpperInvariant().Trim() != transaction.currency.ToUpperInvariant().Trim())
{
// because of parent_id present, currency will always be the one from parent transaction
// malicious attacker could potentially exploit this by creating invoice
@@ -43,11 +44,12 @@ namespace BTCPayServer.Services.Shopify
amount = amountCaptured ?? transaction.amount,
kind = "capture",
gateway = "BTCPayServer",
source = "external"
source = "external",
authorization = invoiceId
}
};
dynamic createResp = await _client.TransactionCreate(orderId, createTransaction);
var createResp = await _client.TransactionCreate(orderId, createTransaction);
return createResp;
}

9
BTCPayServer/Services/Shopify/ShopifyOrderMarkerHostedService.cs
View File

@@ -61,9 +61,12 @@ namespace BTCPayServer.Services.Shopify
try
{
var logic = new OrderTransactionRegisterLogic(client);
await logic.Process(shopifyOrderId, invoice.Currency, invoice.Price.ToString(CultureInfo.InvariantCulture));
Logs.PayServer.LogInformation("Registered order transaction on Shopify. " +
$"Triggered by invoiceId: {invoice.Id}, Shopify orderId: {shopifyOrderId}");
var resp = await logic.Process(shopifyOrderId, invoice.Id, invoice.Currency, invoice.Price.ToString(CultureInfo.InvariantCulture));
if (resp != null)
{
Logs.PayServer.LogInformation("Registered order transaction on Shopify. " +
$"Triggered by invoiceId: {invoice.Id}, Shopify orderId: {shopifyOrderId}");
}
}
catch (Exception ex)
{