Fix missing hot wallet option on seed import (#2284)

* Fix missing hot wallet option on seed import Thanks @kukks for spotting! * Tests: Wait for button to be ready for interaction * Camelcase test selectors * Tests: Remove general ImplicitWait * Tests: Add WaitForAndClick helper * Tests: Refactor SetCheckbox * Tests: Add WaitForElement helper * Tests: Refactor and use wait.UntilJsIsReady helper * Fix missing helper in ethereum tests * Tests: Some more refactorings
2026-01-31 11:54:24 +01:00 · 2021-02-17 04:14:29 +01:00
parent 41e453306d
commit c73878ccca
14 changed files with 108 additions and 75 deletions
--- a/BTCPayServer.Tests/AltcoinTests/EthereumTests.cs
+++ b/BTCPayServer.Tests/AltcoinTests/EthereumTests.cs
@@ -73,14 +73,14 @@ namespace BTCPayServer.Tests
            var seed = new Mnemonic(Wordlist.English);
            s.Driver.FindElement(By.Id("ModifyETH")).Click();
            s.Driver.FindElement(By.Id("Seed")).SendKeys(seed.ToString());
-            s.SetCheckbox(s.Driver.FindElement(By.Id("StoreSeed")), true);
-            s.SetCheckbox(s.Driver.FindElement(By.Id("Enabled")), true);
+            s.Driver.SetCheckbox(By.Id("StoreSeed"), true);
+            s.Driver.SetCheckbox(By.Id("Enabled"), true);
            s.Driver.FindElement(By.Id("SaveButton")).Click();
            s.FindAlertMessage();
            s.Driver.FindElement(By.Id("ModifyUSDT20")).Click();
            s.Driver.FindElement(By.Id("Seed")).SendKeys(seed.ToString());
-            s.SetCheckbox(s.Driver.FindElement(By.Id("StoreSeed")), true);
-            s.SetCheckbox(s.Driver.FindElement(By.Id("Enabled")), true);
+            s.Driver.SetCheckbox(By.Id("StoreSeed"), true);
+            s.Driver.SetCheckbox(By.Id("Enabled"), true);
            s.Driver.FindElement(By.Id("SaveButton")).Click();
            s.FindAlertMessage();

--- a/BTCPayServer.Tests/ApiKeysTests.cs
+++ b/BTCPayServer.Tests/ApiKeysTests.cs
@@ -61,9 +61,9 @@ namespace BTCPayServer.Tests
                Assert.Contains("btcpay.server.canmodifyserversettings", s.Driver.PageSource);

                //server management should show now
-                s.SetCheckbox(s, "btcpay.server.canmodifyserversettings", true);
-                s.SetCheckbox(s, "btcpay.store.canmodifystoresettings", true);
-                s.SetCheckbox(s, "btcpay.user.canviewprofile", true);
+                s.Driver.SetCheckbox(By.Id("btcpay.server.canmodifyserversettings"), true);
+                s.Driver.SetCheckbox(By.Id("btcpay.store.canmodifystoresettings"), true);
+                s.Driver.SetCheckbox(By.Id("btcpay.user.canviewprofile"), true);
                s.Driver.FindElement(By.Id("Generate")).Click();
                var superApiKey = s.FindAlertMessage().FindElement(By.TagName("code")).Text;

@@ -72,7 +72,7 @@ namespace BTCPayServer.Tests


                s.Driver.FindElement(By.Id("AddApiKey")).Click();
-                s.SetCheckbox(s, "btcpay.server.canmodifyserversettings", true);
+                s.Driver.SetCheckbox(By.Id("btcpay.server.canmodifyserversettings"), true);
                s.Driver.FindElement(By.Id("Generate")).Click();
                var serverOnlyApiKey = s.FindAlertMessage().FindElement(By.TagName("code")).Text;
                await TestApiAgainstAccessToken(serverOnlyApiKey, tester, user,
@@ -80,7 +80,7 @@ namespace BTCPayServer.Tests


                s.Driver.FindElement(By.Id("AddApiKey")).Click();
-                s.SetCheckbox(s, "btcpay.store.canmodifystoresettings", true);
+                s.Driver.SetCheckbox(By.Id("btcpay.store.canmodifystoresettings"), true);
                s.Driver.FindElement(By.Id("Generate")).Click();
                var allStoreOnlyApiKey = s.FindAlertMessage().FindElement(By.TagName("code")).Text;
                await TestApiAgainstAccessToken(allStoreOnlyApiKey, tester, user,
@@ -149,7 +149,7 @@ namespace BTCPayServer.Tests
                Assert.Equal("checkbox", s.Driver.FindElement(By.Id("btcpay.server.canmodifyserversettings")).GetAttribute("type").ToLowerInvariant());
                Assert.Equal("true", s.Driver.FindElement(By.Id("btcpay.server.canmodifyserversettings")).GetAttribute("value").ToLowerInvariant());

-                s.SetCheckbox(s, "btcpay.server.canmodifyserversettings", false);
+                s.Driver.SetCheckbox(By.Id("btcpay.server.canmodifyserversettings"), false);
                Assert.Contains("change-store-mode", s.Driver.PageSource);
                s.Driver.FindElement(By.Id("consent-yes")).Click();
                Assert.Equal(callbackUrl, s.Driver.Url);
--- a/BTCPayServer.Tests/CheckoutUITests.cs
+++ b/BTCPayServer.Tests/CheckoutUITests.cs
@@ -113,7 +113,7 @@ namespace BTCPayServer.Tests
                var store = s.CreateNewStore();
                s.AddInternalLightningNode("BTC");
                s.GoToStore(store.storeId, StoreNavPages.Checkout);
-                s.SetCheckbox(s, "LightningAmountInSatoshi", true);
+                s.Driver.SetCheckbox(By.Id("LightningAmountInSatoshi"), true);
                var command = s.Driver.FindElement(By.Name("command"));

                command.Click();
--- a/BTCPayServer.Tests/Extensions.cs
+++ b/BTCPayServer.Tests/Extensions.cs
@@ -7,6 +7,7 @@ using Microsoft.AspNetCore.Mvc;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Serialization;
 using OpenQA.Selenium;
+using OpenQA.Selenium.Support.UI;
 using Xunit;

 namespace BTCPayServer.Tests
@@ -105,5 +106,49 @@ namespace BTCPayServer.Tests
            }
            Assert.False(true, "Elements was found");
        }
+
+        public static void UntilJsIsReady(this WebDriverWait wait)
+        {
+            wait.Until(d=>((IJavaScriptExecutor)d).ExecuteScript("return document.readyState").Equals("complete"));
+            wait.Until(d=>((IJavaScriptExecutor)d).ExecuteScript("return typeof(jQuery) === 'undefined' || jQuery.active === 0").Equals(true));
+        }
+
+        public static IWebElement WaitForElement(this IWebDriver driver, By selector)
+        {
+            var wait = new WebDriverWait(driver, SeleniumTester.ImplicitWait);
+            wait.UntilJsIsReady();
+
+            var el = driver.FindElement(selector);
+            wait.Until(d => el.Displayed);
+
+            return el;
+        }
+
+        public static void WaitForAndClick(this IWebDriver driver, By selector)
+        {
+            var wait = new WebDriverWait(driver, SeleniumTester.ImplicitWait);
+            wait.UntilJsIsReady();
+
+            var el = driver.FindElement(selector);
+            wait.Until(d => el.Displayed && el.Enabled);
+            el.Click();
+
+            wait.UntilJsIsReady();
+        }
+
+        public static void SetCheckbox(this IWebDriver driver, By selector, bool value)
+        {
+            var element = driver.FindElement(selector);
+            if ((value && !element.Selected) || (!value && element.Selected))
+            {
+                driver.WaitForAndClick(selector);
+            }
+
+            if (value != element.Selected)
+            {
+                Logs.Tester.LogInformation("SetCheckbox recursion, trying to click again");
+                driver.SetCheckbox(selector, value);
+            }
+        }
    }
 }
--- a/BTCPayServer.Tests/PayJoinTests.cs
+++ b/BTCPayServer.Tests/PayJoinTests.cs
@@ -237,7 +237,7 @@ namespace BTCPayServer.Tests
                    s.GoToStore(receiver.storeId);
                    //payjoin is not enabled by default.
                    Assert.False(s.Driver.FindElement(By.Id("PayJoinEnabled")).Selected);
-                    s.SetCheckbox(s, "PayJoinEnabled", true);
+                    s.Driver.SetCheckbox(By.Id("PayJoinEnabled"), true);
                    s.Driver.FindElement(By.Id("Save")).Click();
                    Assert.True(s.Driver.FindElement(By.Id("PayJoinEnabled")).Selected);

--- a/BTCPayServer.Tests/SeleniumTester.cs
+++ b/BTCPayServer.Tests/SeleniumTester.cs
@@ -32,6 +32,7 @@ namespace BTCPayServer.Tests
        public static SeleniumTester Create([CallerMemberNameAttribute] string scope = null, bool newDb = false) =>
            new SeleniumTester { Server = ServerTester.Create(scope, newDb) };

+        public static readonly TimeSpan ImplicitWait = TimeSpan.FromSeconds(5);

        public async Task StartAsync()
        {
@@ -73,20 +74,19 @@ namespace BTCPayServer.Tests
            Logs.Tester.LogInformation($"Selenium: Using {Driver.GetType()}");
            Logs.Tester.LogInformation($"Selenium: Browsing to {Server.PayTester.ServerUri}");
            Logs.Tester.LogInformation($"Selenium: Resolution {Driver.Manage().Window.Size}");
-            Driver.Manage().Timeouts().ImplicitWait = ImplicitWait;
            GoToRegister();
            Driver.AssertNoError();
        }

        internal IWebElement FindAlertMessage(StatusMessageModel.StatusSeverity severity = StatusMessageModel.StatusSeverity.Success)
        {
-            var el = Driver.FindElements(By.ClassName($"alert-{StatusMessageModel.ToString(severity)}")).FirstOrDefault(e => e.Displayed);
+            var className = $"alert-{StatusMessageModel.ToString(severity)}";
+            var el = Driver.FindElement(By.ClassName(className)) ?? Driver.WaitForElement(By.ClassName(className));
            if (el is null)
-                throw new NoSuchElementException($"Unable to find alert-{StatusMessageModel.ToString(severity)}");
+                throw new NoSuchElementException($"Unable to find {className}");
            return el;
        }

-        public static readonly TimeSpan ImplicitWait = TimeSpan.FromSeconds(5);
        public string Link(string relativeLink)
        {
            return Server.PayTester.ServerUri.AbsoluteUri.WithoutEndingSlash() + relativeLink.WithStartingSlash();
@@ -126,40 +126,47 @@ namespace BTCPayServer.Tests
        {
            Driver.FindElement(By.Id($"Modify{cryptoCode}")).Click();
            // Modify case
-            if (Driver.PageSource.Contains("id=\"change-wallet-link\""))
+            if (Driver.PageSource.Contains("id=\"ChangeWalletLink\""))
            {
-                Driver.FindElement(By.Id("change-wallet-link")).Click();
+                Driver.FindElement(By.Id("ChangeWalletLink")).Click();
            }

            if (string.IsNullOrEmpty(seed))
            {
-                var option = privkeys ? "hotwallet" : "watchonly";
+                var option = privkeys ? "Hotwallet" : "Watchonly";
                Logs.Tester.LogInformation($"Generating new seed ({option})");
-                Driver.FindElement(By.Id("generate-wallet-link")).Click();
-                Driver.FindElement(By.Id($"generate-{option}-link")).Click();
+                Driver.FindElement(By.Id("GenerateWalletLink")).Click();
+                Driver.FindElement(By.Id($"Generate{option}Link")).Click();
            }
            else
            {
                Logs.Tester.LogInformation("Progressing with existing seed");
-                Driver.FindElement(By.Id("import-wallet-options-link")).Click();
-                Driver.FindElement(By.Id("import-seed-link")).Click();
+                Driver.FindElement(By.Id("ImportWalletOptionsLink")).Click();
+                Driver.FindElement(By.Id("ImportSeedLink")).Click();
                Driver.FindElement(By.Id("ExistingMnemonic")).SendKeys(seed);
-                SetCheckbox(Driver.FindElement(By.Id("SavePrivateKeys")), privkeys);
+                Driver.SetCheckbox(By.Id("SavePrivateKeys"), privkeys);
            }

            Driver.FindElement(By.Id("ScriptPubKeyType")).Click();
            Driver.FindElement(By.CssSelector($"#ScriptPubKeyType option[value={format}]")).Click();
-            Driver.FindElement(By.Id("advanced-settings-button")).Click();
-            SetCheckbox(Driver.FindElement(By.Id("ImportKeysToRPC")), importkeys);
-            Driver.FindElement(By.Id("advanced-settings-button")).Click(); // close settings again , otherwise the button might not be clickable for Selenium
+            Driver.FindElement(By.Id("AdvancedSettingsButton")).Click();
+            Driver.SetCheckbox(By.Id("ImportKeysToRPC"), importkeys);
+            Driver.FindElement(By.Id("AdvancedSettingsButton")).Click(); // close again
+
+            try
+            {
+                Driver.FindElement(By.Id("Continue")).Click();
+            }
+            catch (ElementClickInterceptedException)
+            {
+                Driver.WaitForAndClick(By.Id("Continue"));
+            }

-            Logs.Tester.LogInformation("Trying to click Continue button");
-            Driver.FindElement(By.Id("Continue")).Click();
            // Seed backup page
            FindAlertMessage();
            if (string.IsNullOrEmpty(seed))
            {
-                seed = Driver.FindElements(By.Id("recovery-phrase")).First().GetAttribute("data-mnemonic");
+                seed = Driver.FindElements(By.Id("RecoveryPhrase")).First().GetAttribute("data-mnemonic");
            }

            // Confirm seed backup
@@ -173,8 +180,8 @@ namespace BTCPayServer.Tests
        public void AddDerivationScheme(string cryptoCode = "BTC", string derivationScheme = "xpub661MyMwAqRbcGABgHMUXDzPzH1tU7eZaAaJQXhDXsSxsqyQzQeU6kznNfSuAyqAK9UaWSaZaMFdNiY5BCF4zBPAzSnwfUAwUhwttuAKwfRX-[legacy]")
        {
            Driver.FindElement(By.Id($"Modify{cryptoCode}")).Click();
-            Driver.FindElement(By.Id("import-wallet-options-link")).Click();
-            Driver.FindElement(By.Id("import-xpub-link")).Click();
+            Driver.FindElement(By.Id("ImportWalletOptionsLink")).Click();
+            Driver.FindElement(By.Id("ImportXpubLink")).Click();
            Driver.FindElement(By.Id("DerivationScheme")).SendKeys(derivationScheme);
            Driver.FindElement(By.Id("Continue")).Click();
            Driver.FindElement(By.Id("Confirm")).Click();
@@ -282,26 +289,6 @@ namespace BTCPayServer.Tests
            CheckForJSErrors();
        }

-
-        public void SetCheckbox(IWebElement element, bool value)
-        {
-            if ((value && !element.Selected) || (!value && element.Selected))
-            {
-                element.Click();
-            }
-
-            if (value != element.Selected)
-            {
-                Logs.Tester.LogInformation("SetCheckbox recursion, trying to click again");
-                SetCheckbox(element, value);
-            }
-        }
-
-        public void SetCheckbox(SeleniumTester s, string checkboxId, bool value)
-        {
-            SetCheckbox(s.Driver.FindElement(By.Id(checkboxId)), value);
-        }
-
        public void GoToInvoices()
        {
            Driver.FindElement(By.Id("Invoices")).Click();
--- a/BTCPayServer.Tests/SeleniumTests.cs
+++ b/BTCPayServer.Tests/SeleniumTests.cs
@@ -113,7 +113,7 @@ namespace BTCPayServer.Tests
                s.Driver.FindElement(By.Id("Email")).SendKeys(u2.RegisterDetails.Email);
                s.Driver.FindElement(By.Id("save")).Click();

-                s.FindAlertMessage(Abstractions.Models.StatusMessageModel.StatusSeverity.Error);
+                s.FindAlertMessage(StatusMessageModel.StatusSeverity.Error);

                s.GoToProfile(ManageNavPages.Index);
                s.Driver.FindElement(By.Id("Email")).Clear();
@@ -578,7 +578,7 @@ namespace BTCPayServer.Tests
                await s.Server.ExplorerNode.GenerateAsync(1);
                s.GoToWallet(walletId);
                s.Driver.FindElement(By.Id("advancedSettings")).Click();
-                s.Driver.FindElement(By.Id("toggleInputSelection")).Click();
+                s.Driver.WaitForAndClick(By.Id("toggleInputSelection"));
                s.Driver.FindElement(By.Id(spentOutpoint.ToString()));
                Assert.Equal("true", s.Driver.FindElement(By.Name("InputSelection")).GetAttribute("value").ToLowerInvariant());
                var el = s.Driver.FindElement(By.Id(spentOutpoint.ToString()));
@@ -878,7 +878,7 @@ namespace BTCPayServer.Tests
                s.Driver.FindElement(By.CssSelector("button[value=view-seed]")).Click();

                // Seed backup page
-                var recoveryPhrase = s.Driver.FindElements(By.Id("recovery-phrase")).First().GetAttribute("data-mnemonic");
+                var recoveryPhrase = s.Driver.FindElements(By.Id("RecoveryPhrase")).First().GetAttribute("data-mnemonic");
                Assert.Equal(mnemonic.ToString(), recoveryPhrase);
                Assert.Contains("The recovery phrase will also be stored on the server as a hot wallet.", s.Driver.PageSource);

--- a/BTCPayServer/Views/Home/RecoverySeedBackup.cshtml
+++ b/BTCPayServer/Views/Home/RecoverySeedBackup.cshtml
@@ -9,13 +9,13 @@
 }

 <style>
-    @@media (min-width: 476px) { ol#recovery-phrase {max-height:16em;} }
-    @@media (min-width: 768px) { ol#recovery-phrase {max-height:12em;} }
-    @@media (min-width: 1200px) { ol#recovery-phrase {max-height:8em;} }
-    form#recovery-confirmation button { position: absolute; bottom:0; left:50%; width:200px; margin-left:-100px; }
-    form#recovery-confirmation button:not([disabled]) { display: none; }
-    form#recovery-confirmation input:checked ~ button[disabled] { display: none; }
-    form#recovery-confirmation input:checked + button:not([disabled]) { display: inline-block; }
+    @@media (min-width: 476px) { ol#RecoveryPhrase {max-height:16em;} }
+    @@media (min-width: 768px) { ol#RecoveryPhrase {max-height:12em;} }
+    @@media (min-width: 1200px) { ol#RecoveryPhrase {max-height:8em;} }
+    form#RecoveryConfirmation button { position: absolute; bottom:0; left:50%; width:200px; margin-left:-100px; }
+    form#RecoveryConfirmation button:not([disabled]) { display: none; }
+    form#RecoveryConfirmation input:checked ~ button[disabled] { display: none; }
+    form#RecoveryConfirmation input:checked + button:not([disabled]) { display: inline-block; }
 </style>

 <div class="row justify-content-md-center">
@@ -33,7 +33,7 @@
                <span class="d-sm-block"><strong>Write them down on a piece of paper in the exact order.</strong></span>
            </p>
        </div>
-        <ol id="recovery-phrase" data-mnemonic="@Model.Mnemonic" class="my-5 d-flex flex-column flex-wrap justify-content-center align-items-center text-left p-0">
+        <ol id="RecoveryPhrase" data-mnemonic="@Model.Mnemonic" class="my-5 d-flex flex-column flex-wrap justify-content-center align-items-center text-left p-0">
            @foreach (var word in Model.Words)
            {
                <li class="ml-4 px-3 py-2 text-secondary" style="flex: 0 1;min-width:10em;">
@@ -71,7 +71,7 @@
        </div>
        @if (Model.RequireConfirm)
        {
-            <form id="recovery-confirmation" action="@Model.ReturnUrl" class="d-flex align-items-start justify-content-center" style="margin-top:4rem;padding-bottom: 80px">
+            <form id="RecoveryConfirmation" action="@Model.ReturnUrl" class="d-flex align-items-start justify-content-center" style="margin-top:4rem;padding-bottom: 80px">
                <label class="form-check-label lead order-2" for="confirm">I have written down my recovery phrase and stored it in a secure location</label>
                <input type="checkbox" class="mt-2 mr-3 order-1" id="confirm">
                <button type="submit" class="btn btn-primary btn-lg px-5 order-3" id="submit">Done</button>
--- a/BTCPayServer/Views/Stores/GenerateWalletOptions.cshtml
+++ b/BTCPayServer/Views/Stores/GenerateWalletOptions.cshtml
@@ -16,7 +16,7 @@
 <div class="list-group mt-5">
    @if (Model.CanUseHotWallet)
    {
-        <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="hotwallet" id="generate-hotwallet-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+        <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="hotwallet" id="GenerateHotwalletLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
            <div class="image">
                <vc:icon symbol="seed"/>
            </div>
@@ -45,7 +45,7 @@
 </div>

 <div class="list-group mt-4">
-    <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="watchonly" id="generate-watchonly-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+    <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="watchonly" id="GenerateWatchonlyLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
        <div class="image">
            <vc:icon symbol="xpub"/>
        </div>
--- a/BTCPayServer/Views/Stores/ImportWallet/Seed.cshtml
+++ b/BTCPayServer/Views/Stores/ImportWallet/Seed.cshtml
@@ -19,6 +19,7 @@
 <div class="my-5">
    @if (Model.CanUseHotWallet)
    {
+        ViewData.Add(nameof(Model.CanUseHotWallet), Model.CanUseHotWallet);
        ViewData.Add(nameof(Model.CanUseRPCImport), Model.CanUseRPCImport);
        ViewData.Add(nameof(Model.Method), Model.Method);

--- a/BTCPayServer/Views/Stores/ImportWalletOptions.cshtml
+++ b/BTCPayServer/Views/Stores/ImportWalletOptions.cshtml
@@ -20,7 +20,7 @@
 {
    <div class="mt-5">
        <div class="list-group">
-            <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="hardware" id="import-hardware-link" class="list-group-item list-group-item-action list-group-item-wallet-setup only-for-js">
+            <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="hardware" id="ImportHardwareLink" class="list-group-item list-group-item-action list-group-item-wallet-setup only-for-js">
                <div class="image">
                    <vc:icon symbol="hardware-wallet"/>
                </div>
@@ -52,7 +52,7 @@
 }

 <div class="list-group mt-4">
-    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="file" id="import-file-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="file" id="ImportFileLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
        <div class="image">
            <vc:icon symbol="wallet-file"/>
        </div>
@@ -68,7 +68,7 @@
 </div>

 <div class="list-group mt-4">
-    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="xpub" id="import-xpub-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="xpub" id="ImportXpubLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
        <div class="image">
            <vc:icon symbol="xpub"/>
        </div>
@@ -81,7 +81,7 @@
 </div>

 <div class="list-group mt-4">
-    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="scan" id="import-scan-link" class="list-group-item list-group-item-action list-group-item-wallet-setup only-for-js">
+    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="scan" id="ImportScanLink" class="list-group-item list-group-item-action list-group-item-wallet-setup only-for-js">
        <div class="image">
            <vc:icon symbol="scan-qr"/>
        </div>
@@ -105,7 +105,7 @@
 </div>

 <div class="list-group mt-4">
-    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="seed" id="import-seed-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+    <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" asp-route-method="seed" id="ImportSeedLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
        <div class="image">
            <vc:icon symbol="seed"/>
        </div>
--- a/BTCPayServer/Views/Stores/ModifyWallet.cshtml
+++ b/BTCPayServer/Views/Stores/ModifyWallet.cshtml
@@ -57,7 +57,7 @@
    </form>
    <br>
    <form method="get" asp-controller="Stores" asp-action="DeleteWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" class="mt-5">
-        <a asp-controller="Stores" asp-action="SetupWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="change-wallet-link" class="btn btn-secondary mr-2">
+        <a asp-controller="Stores" asp-action="SetupWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="ChangeWalletLink" class="btn btn-secondary mr-2">
            Replace wallet
        </a>
        <button type="submit" class="btn btn-danger" id="Delete">Remove wallet</button>
--- a/BTCPayServer/Views/Stores/SetupWallet.cshtml
+++ b/BTCPayServer/Views/Stores/SetupWallet.cshtml
@@ -21,7 +21,7 @@
 <div class="mt-5">
    <h3 class="my-4">I have a wallet</h3>
    <div class="list-group">
-        <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="import-wallet-options-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+        <a asp-controller="Stores" asp-action="ImportWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="ImportWalletOptionsLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
            <div class="image">
                <vc:icon symbol="existing-wallet"/>
            </div>
@@ -38,7 +38,7 @@
 <div class="mt-5">
    <h3 class="my-4">I don't have a wallet</h3>
    <div class="list-group">
-        <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="generate-wallet-link" class="list-group-item list-group-item-action list-group-item-wallet-setup">
+        <a asp-controller="Stores" asp-action="GenerateWallet" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="GenerateWalletLink" class="list-group-item list-group-item-action list-group-item-wallet-setup">
            <div class="image">
                <vc:icon symbol="new-wallet"/>
            </div>
--- a/BTCPayServer/Views/Stores/_GenerateWalletForm.cshtml
+++ b/BTCPayServer/Views/Stores/_GenerateWalletForm.cshtml
@@ -58,7 +58,7 @@
    }

    <div class="mb-4">
-        <button class="btn btn-link px-0" type="button" id="advanced-settings-button" data-toggle="collapse" data-target="#advanced-settings" aria-expanded="false" aria-controls="advanced-settings">
+        <button class="btn btn-link px-0" type="button" id="AdvancedSettingsButton" data-toggle="collapse" data-target="#advanced-settings" aria-expanded="false" aria-controls="advanced-settings">
            Advanced settings
        </button>
        <div id="advanced-settings" class="collapse @(string.IsNullOrEmpty(Model.Passphrase) && !Model.ImportKeysToRPC ? "" : "show")">