Remove Firefox as option for Selenium tests

This commit is contained in:
Dennis Reimann
2021-01-27 09:35:14 +01:00
parent 5e344b9be7
commit b75409a6bf
3 changed files with 10 additions and 29 deletions

View File

@@ -21,7 +21,6 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="Newtonsoft.Json.Schema" Version="3.0.13" />
<PackageReference Include="Selenium.Firefox.WebDriver" Version="0.27.0" />
<PackageReference Include="Selenium.Support" Version="3.141.0" />
<PackageReference Include="Selenium.WebDriver" Version="3.141.0" />
<PackageReference Include="Selenium.WebDriver.ChromeDriver" Version="88.0.4324.9600" />

View File

@@ -74,5 +74,3 @@ If you still have issues, try to restart docker.
Run `dotnet user-secrets set RunSeleniumInBrowser true` to run tests in browser.
To switch back to headless mode (recommended) you can run `dotnet user-secrets remove RunSeleniumInBrowser`.
To run the tests using Firefox (default is Chrome), run `dotnet user-secrets set RunSeleniumInFirefox true`.

View File

@@ -17,7 +17,6 @@ using Microsoft.Extensions.Configuration;
using NBitcoin;
using OpenQA.Selenium;
using OpenQA.Selenium.Chrome;
using OpenQA.Selenium.Firefox;
using Xunit;
namespace BTCPayServer.Tests
@@ -45,36 +44,21 @@ namespace BTCPayServer.Tests
// Run `dotnet user-secrets set RunSeleniumInBrowser true` to run tests in browser
var runInBrowser = config["RunSeleniumInBrowser"] == "true";
// Run `dotnet user-secrets set RunSeleniumInFirefox true` to run tests in browser
var runInFirefox = config["RunSeleniumInFirefox"] == "true";
// Reset this using `dotnet user-secrets remove RunSeleniumInBrowser` (or `...Firefox`)
// Reset this using `dotnet user-secrets remove RunSeleniumInBrowser`
if (runInFirefox)
var options = new ChromeOptions();
if (Server.PayTester.InContainer)
{
var options = new FirefoxOptions();
if (!runInBrowser)
{
options.AddArguments("-headless");
}
options.AddArguments($"--window-size {windowSize.Width},{windowSize.Height}");
Driver = new FirefoxDriver(options);
// this must be first option https://stackoverflow.com/questions/53073411/selenium-webdriverexceptionchrome-failed-to-start-crashed-as-google-chrome-is#comment102570662_53073789
options.AddArgument("no-sandbox");
}
else
if (!runInBrowser)
{
var options = new ChromeOptions();
if (Server.PayTester.InContainer)
{
// this must be first option https://stackoverflow.com/questions/53073411/selenium-webdriverexceptionchrome-failed-to-start-crashed-as-google-chrome-is#comment102570662_53073789
options.AddArgument("no-sandbox");
}
if (!runInBrowser)
{
options.AddArguments("headless");
}
options.AddArguments($"window-size={windowSize.Width}x{windowSize.Height}");
options.AddArgument("shm-size=2g");
Driver = new ChromeDriver(Server.PayTester.InContainer ? "/usr/bin" : Directory.GetCurrentDirectory(), options);
options.AddArguments("headless");
}
options.AddArguments($"window-size={windowSize.Width}x{windowSize.Height}");
options.AddArgument("shm-size=2g");
Driver = new ChromeDriver(Server.PayTester.InContainer ? "/usr/bin" : Directory.GetCurrentDirectory(), options);
if (runInBrowser)
{