mirror of
https://github.com/dergigi/boris.git
synced 2026-01-02 06:24:20 +01:00
Added findings about applesauce-accounts queue issue: - Queue MUST be disabled for batch decrypt operations - Default queueing blocks all requests until first completes - This was the primary cause of hangs and timeouts - Updated performance improvements section with all optimizations - Updated conclusion with key learnings Ref: https://hzrd149.github.io/applesauce/typedoc/classes/applesauce-accounts.BaseAccount.html#disablequeue
6.7 KiB
6.7 KiB
Boris ↔ Amber bunker: current findings
- Environment
- Client: Boris (web) using
applesaucestack (NostrConnectSigner,RelayPool). - Bunker: Amber (mobile).
- We restored a
nostr-connectaccount from localStorage and re-wired the signer to the appRelayPoolbefore use.
- Client: Boris (web) using
What we changed client-side
-
Signer wiring
- Bound
NostrConnectSigner.subscriptionMethod/publishMethodto the appRelayPoolat startup. - After deserialization, recreated the signer with pool context and merged its relays with app
RELAYS(includes local relays). - Opened the signer subscription and performed a guarded
connect()with default permissions includingnip04_encrypt/decryptandnip44_encrypt/decrypt.
- Bound
-
Account queue disabling (CRITICAL)
applesauce-accountsBaseAccountqueues requests by default - each request waits for the previous one to complete before being sent.- This caused batch decrypt operations to hang: first request would timeout waiting for user interaction, blocking all subsequent requests in the queue.
- Solution: Set
account.disableQueue = truebefore batch operations, restore after completion. - Without this, Amber never sees decrypt requests because they're stuck in the account's internal queue.
- Reference: https://hzrd149.github.io/applesauce/typedoc/classes/applesauce-accounts.BaseAccount.html#disablequeue
-
Probes and timeouts
- Initial probe tried
decrypt('invalid-ciphertext')→ timed out. - Switched to roundtrip probes:
encrypt(self, ... )thendecrypt(self, cipher)for both nip-44 and nip-04. - Increased probe timeout from 3s → 10s; increased bookmark decrypt timeout from 15s → 30s.
- Initial probe tried
-
Logging
- Added logs for publish/subscribe and parsed the NIP-46 request content length.
- Confirmed NIP‑46 request events are kind
24133with a singleptag (expected). The method is inside the encrypted content, so it prints asmethod: undefined(expected).
Evidence from logs (client)
[bunker] ✅ Wired NostrConnectSigner to RelayPool publish/subscription
[bunker] 🔗 Signer relays merged with app RELAYS: (19) [...]
[bunker] subscribe via signer: { relays: [...], filters: [...] }
[bunker] ✅ Signer subscription opened
[bunker] publish via signer: { relays: [...], kind: 24133, tags: [['p', <remote>]], contentLength: 260|304|54704 }
[bunker] 🔎 Probe nip44 roundtrip (encrypt→decrypt)… → probe timeout after 10000ms
[bunker] 🔎 Probe nip04 roundtrip (encrypt→decrypt)… → probe timeout after 10000ms
bookmarkProcessing.ts: ❌ nip44.decrypt failed: Decrypt timeout after 30000ms
bookmarkProcessing.ts: ❌ nip04.decrypt failed: Decrypt timeout after 30000ms
Notes:
- Final signer status shows
listening: true,isConnected: true, and requests are published to 19 relays (includes Amber’s).
Evidence from Amber (device)
- Activity screen shows multiple entries for: “Encrypt data using nip 4” and “Encrypt data using nip 44” with green checkmarks.
- No entries for “Decrypt data using nip 4” or “Decrypt data using nip 44”.
Interpretation
- Transport and publish paths are working: Boris is publishing NIP‑46 requests (kind 24133) and Amber receives them (ENCRYPT activity visible).
- The persistent failure is specific to DECRYPT handling: Amber does not show any DECRYPT activity and Boris receives no decrypt responses within 10–30s windows.
- Client-side wiring is likely correct (subscription open, permissions requested, relays merged). The remaining issue appears provider-side in Amber’s NIP‑46 decrypt handling or permission gating.
Repro steps (quick)
- Revoke Boris in Amber.
- Reconnect with a fresh bunker URI; approve signing and both encrypt/decrypt scopes for nip‑04 and nip‑44.
- Keep Amber unlocked and foregrounded.
- Reload Boris; observe:
- Logs showing
publish via signerfor kind 24133. - In Amber, activity should include “Decrypt data using nip 4/44”.
- Logs showing
If DECRYPT entries still don’t appear:
- This points to Amber’s NIP‑46 provider not executing/authorizing
nip04_decrypt/nip44_decryptmethods, or not publishing responses.
Suggestions for Amber-side debugging
- Verify permission gating allows
nip04_decryptandnip44_decrypt(not just encrypt). - Confirm the provider recognizes NIP‑46 methods
nip04_decryptandnip44_decryptin the decrypted payload and routes them to decrypt routines. - Ensure the response event is published back to the same relays and correctly addressed to the client (
ptag set and content encrypted back to client pubkey). - Add activity logging for “Decrypt …” attempts and failures to surface denial/exception states.
Performance improvements (post-debugging)
Non-blocking publish wiring
- Problem: Awaiting
pool.publish()completion blocks until all relay sends finish (can take 30s+ with timeouts). - Solution: Wrapped
NostrConnectSigner.publishMethodat app startup to fire-and-forget publish Observable/Promise; responses still arrive via signer subscription. - Result: Encrypt/decrypt operations complete in <2s as seen in
/debugpage (NIP-44: ~900ms enc, ~700ms dec; NIP-04: ~1s enc, ~2s dec).
Bookmark decryption optimization
- Problem #1: Sequential decrypt of encrypted bookmark events blocks UI and takes long with multiple events.
- Problem #2: 30-second timeouts on
nip44.decryptmeant waiting 30s per event if bunker didn't support nip44. - Problem #3: Account request queue blocked all decrypt requests until first one completed (waiting for user interaction).
- Solution:
- Removed artificial timeouts - let decrypt fail naturally like debug page does.
- Added smart encryption detection (NIP-04 has
?iv=, NIP-44 doesn't) to try the right method first. - Use 5-second timeout as safety net (down from 30s).
- Disable account queue (
disableQueue = true) during batch operations so all requests are sent immediately. - Process sequentially (removed concurrent
mapWithConcurrencyhack).
- Result: Bookmark decryption should be near-instant, limited only by bunker response time and user approval speed.
Current conclusion
- Client is configured and publishing requests correctly; encryption proves end‑to‑end path is alive.
- Non-blocking publish keeps operations fast (~1-2s for encrypt/decrypt).
- Account queue MUST be disabled for batch operations - this was the primary cause of hangs/timeouts.
- Smart encryption detection and reasonable timeouts (5s) prevent unnecessary delays.
- Sequential processing is cleaner and more predictable than concurrent hacks.
- The missing DECRYPT activity in Amber was partially due to requests never being sent (stuck in queue). With queue disabled, Amber should now receive all decrypt requests.