chore: bump version to 0.10.17

Reading position now saves every 1 second during continuous scrolling
instead of every 3 seconds, providing more frequent position updates.

CHANGELOG.md

@@ -7,6 +7,37 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.10.16] - 2025-10-22
+
+### Fixed
+
+- Reading position auto-save now works correctly during continuous scrolling
+  - Fixed critical bug where save timer was cleared when tracking toggled
+  - Timer now persists across tracking state changes
+  - Saves fire reliably every 3 seconds during active reading
+  - Throttle mechanism now works as intended
+- Reading position tracking stability improved
+  - Tracking state no longer toggles erratically
+  - Content stability checks refined to prevent false negatives
+  - Infinite loop fixed in position save handler
+
+### Changed
+
+- Reading position save mechanism changed from debounce to throttle
+  - Ensures saves happen at regular 3-second intervals during continuous scrolling
+  - Previous debounce approach could skip saves during slow continuous scrolling
+  - More predictable save behavior for users
+- Simplified reading position logic by removing unused complexity
+  - Removed 5% delta requirement for scheduling saves
+  - Removed unnecessary state tracking (lastSavedPosition, hasSavedOnce, lastSavedAtRef)
+  - Cleaner, more maintainable code
+
+### Fixed
+
+- Highlights now scroll into view when clicked from `/me/highlights` page
+  - Navigation state properly passes highlight ID and openHighlights flag
+  - Works for both article links and external URL links
+
 ## [0.10.15] - 2025-01-22
 
 ### Changed

package.json

@@ -1,6 +1,6 @@
 {
   "name": "boris",
-  "version": "0.10.16",
+  "version": "0.10.17",
   "description": "A minimal nostr client for bookmark management",
   "homepage": "https://read.withboris.com/",
   "type": "module",

src/components/ContentPanel.tsx

@@ -153,20 +153,11 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
   // Reading position tracking - only for text content that's loaded and long enough
   // Wait for content to load, check it's not a video, and verify it's long enough to track
   const isTextContent = useMemo(() => {
-    const result = {
-      loading,
-      hasMarkdown: !!markdown,
-      hasHtml: !!html,
-      isVideo: selectedUrl?.includes('youtube') || selectedUrl?.includes('vimeo'),
-      longEnough: shouldTrackReadingProgress(html, markdown)
-    }
-    
     if (loading) return false
     if (!markdown && !html) return false
     if (selectedUrl?.includes('youtube') || selectedUrl?.includes('vimeo')) return false
     if (!shouldTrackReadingProgress(html, markdown)) return false
     
-    console.log('[reading-position] 📊 isTextContent check:', result, '→', true)
     return true
   }, [loading, markdown, html, selectedUrl])
   
@@ -187,24 +178,20 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
   // Callback to save reading position
   const handleSavePosition = useCallback(async (position: number) => {
     if (!activeAccount || !relayPool || !eventStore || !articleIdentifier) {
-      console.log('[reading-position] ❌ Cannot save: missing dependencies')
       return
     }
     if (!settings?.syncReadingPosition) {
-      console.log('[reading-position] ⚠️ Save skipped: sync disabled in settings')
       return
     }
     
     // Check if content is long enough to track reading progress
     if (!shouldTrackReadingProgress(htmlRef.current, markdownRef.current)) {
-      console.log('[reading-position] ⚠️ Save skipped: content too short')
       return
     }
 
     const scrollTop = window.pageYOffset || document.documentElement.scrollTop
 
     try {
-      console.log(`[reading-position] [${new Date().toISOString()}] 🚀 Publishing position ${Math.round(position * 100)}% to relays...`)
       const factory = new EventFactory({ signer: activeAccount })
       await saveReadingPosition(
         relayPool,
@@ -217,9 +204,8 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
           scrollTop
         }
       )
-      console.log(`[reading-position] [${new Date().toISOString()}] ✅ Position published successfully`)
     } catch (error) {
-      console.error(`[reading-position] [${new Date().toISOString()}] ❌ Failed to save reading position:`, error)
+      console.error('[reading-position] Failed to save reading position:', error)
     }
   }, [activeAccount, relayPool, eventStore, articleIdentifier, settings?.syncReadingPosition])
 
@@ -236,7 +222,6 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
     if (!isTextContent) {
       // Disable tracking if content is not suitable
       if (isTrackingEnabled) {
-        console.log('[reading-position] ⏸️ Disabling tracking (not text content)')
         setIsTrackingEnabled(false)
       }
       return
@@ -245,7 +230,6 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
     if (!isTrackingEnabled) {
       // Wait 500ms after content loads before enabling tracking
       const timer = setTimeout(() => {
-        console.log('[reading-position] ✅ Enabling tracking after stability delay')
         setIsTrackingEnabled(true)
       }, 500)
       return () => clearTimeout(timer)
@@ -285,35 +269,24 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
   const hasAttemptedRestoreRef = useRef<string | null>(null)
 
   useEffect(() => {
-    console.log('[reading-position] 🔍 Restore effect running:', {
-      isTextContent,
-      isTrackingEnabled,
-      hasAccount: !!activeAccount,
-      articleIdentifier,
-      restoreKey,
-      hasAttempted: hasAttemptedRestoreRef.current
-    })
-    
     if (!isTextContent || !activeAccount || !articleIdentifier) {
-      console.log('[reading-position] ⏭️ Restore skipped: missing dependencies or not text content')
       return
     }
     if (settings?.syncReadingPosition === false) {
-      console.log('[reading-position] ⏭️ Restore skipped: sync disabled in settings')
+      return
+    }
+    if (settings?.autoScrollToReadingPosition === false) {
       return
     }
     if (!isTrackingEnabled) {
-      console.log('[reading-position] ⏭️ Restore skipped: tracking not yet enabled (waiting for content stability)')
       return
     }
 
     // Only attempt restore once per article (after tracking is enabled)
     if (hasAttemptedRestoreRef.current === restoreKey) {
-      console.log('[reading-position] ⏭️ Restore skipped: already attempted for this article')
       return
     }
 
-    console.log('[reading-position] 🔄 Initiating restore for article:', articleIdentifier)
     // Mark as attempted using composite key
     hasAttemptedRestoreRef.current = restoreKey
     
@@ -321,12 +294,9 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
     const savedProgress = readingProgressController.getProgress(articleIdentifier)
     
     if (!savedProgress || savedProgress <= 0.05 || savedProgress >= 1) {
-      console.log('[reading-position] ℹ️ No position to restore (progress:', savedProgress, ')')
       return
     }
 
-    console.log('[reading-position] 🎯 Found saved position:', Math.round(savedProgress * 100) + '%')
-
     // Suppress saves during restore (500ms render + 1000ms smooth scroll = 1500ms)
     if (suppressSavesForRef.current) {
       suppressSavesForRef.current(1500)
@@ -340,20 +310,10 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
       const currentTop = window.pageYOffset || document.documentElement.scrollTop
       const targetTop = savedProgress * maxScroll
 
-      console.log('[reading-position] 📐 Restore calculation:', {
-        docHeight: docH,
-        winHeight: winH,
-        maxScroll,
-        currentTop,
-        targetTop,
-        targetPercent: Math.round(savedProgress * 100) + '%'
-      })
-
       // Skip if delta is too small (< 48px or < 5%)
       const deltaPx = Math.abs(targetTop - currentTop)
       const deltaPct = maxScroll > 0 ? Math.abs((targetTop - currentTop) / maxScroll) : 0
       if (deltaPx < 48 || deltaPct < 0.05) {
-        console.log('[reading-position] ⏭️ Restore skipped: delta too small (', deltaPx, 'px,', Math.round(deltaPct * 100) + '%)')
         // Allow saves immediately since no scroll happened
         if (suppressSavesForRef.current) {
           suppressSavesForRef.current(0)
@@ -361,20 +321,17 @@ const ContentPanel: React.FC<ContentPanelProps> = ({
         return
       }
 
-      console.log('[reading-position] 📜 Restoring scroll position (delta:', deltaPx, 'px,', Math.round(deltaPct * 100) + '%)')
-
       // Perform smooth animated restore
       window.scrollTo({
         top: targetTop,
         behavior: 'smooth'
       })
-      console.log('[reading-position] ✅ Scroll restored to', Math.round(savedProgress * 100) + '%')
     }, 500) // Give content time to render
-  }, [isTextContent, activeAccount, articleIdentifier, settings?.syncReadingPosition, selectedUrl, isTrackingEnabled, restoreKey])
+  }, [isTextContent, activeAccount, articleIdentifier, settings?.syncReadingPosition, settings?.autoScrollToReadingPosition, selectedUrl, isTrackingEnabled, restoreKey])
 
   // Note: We intentionally do NOT save on unmount because:
   // 1. Browser may scroll to top during back navigation, causing 0% saves
-  // 2. The auto-save with 3s debounce already captures position during reading
+  // 2. The auto-save with 1s throttle already captures position during reading
   // 3. Position state may not reflect actual reading position during navigation
 
   // Close menu when clicking outside

src/components/HighlightItem.tsx

@@ -433,7 +433,31 @@ export const HighlightItem: React.FC<HighlightItemProps> = ({
           title={new Date(highlight.created_at * 1000).toLocaleString()}
           onClick={(e) => {
             e.stopPropagation()
-            window.location.href = highlightLinks.native
+            // Navigate within app using same logic as handleItemClick
+            if (highlight.eventReference) {
+              const parts = highlight.eventReference.split(':')
+              if (parts.length === 3 && parts[0] === '30023') {
+                const [, pubkey, identifier] = parts
+                const naddr = nip19.naddrEncode({
+                  kind: 30023,
+                  pubkey,
+                  identifier
+                })
+                navigate(`/a/${naddr}`, { 
+                  state: { 
+                    highlightId: highlight.id,
+                    openHighlights: true 
+                  } 
+                })
+              }
+            } else if (highlight.urlReference) {
+              navigate(`/r/${encodeURIComponent(highlight.urlReference)}`, {
+                state: {
+                  highlightId: highlight.id,
+                  openHighlights: true
+                }
+              })
+            }
           }}
         >
           {formatDateCompact(highlight.created_at)}

src/components/Settings.tsx

@@ -44,6 +44,7 @@ const DEFAULT_SETTINGS: UserSettings = {
   fullWidthImages: true,
   renderVideoLinksAsEmbeds: true,
   syncReadingPosition: true,
+  autoScrollToReadingPosition: true,
   autoMarkAsReadOnCompletion: false,
   hideBookmarksWithoutCreationDate: true,
   ttsUseSystemLanguage: false,

src/components/Settings/LayoutBehaviorSettings.tsx

@@ -118,6 +118,19 @@ const LayoutBehaviorSettings: React.FC<LayoutBehaviorSettingsProps> = ({ setting
         </label>
       </div>
 
+      <div className="setting-group">
+        <label htmlFor="autoScrollToReadingPosition" className="checkbox-label">
+          <input
+            id="autoScrollToReadingPosition"
+            type="checkbox"
+            checked={settings.autoScrollToReadingPosition !== false}
+            onChange={(e) => onUpdate({ autoScrollToReadingPosition: e.target.checked })}
+            className="setting-checkbox"
+          />
+          <span>Auto-scroll to saved reading position</span>
+        </label>
+      </div>
+
       <div className="setting-group">
         <label htmlFor="autoMarkAsReadOnCompletion" className="checkbox-label">
           <input

src/components/Settings/PWASettings.tsx

@@ -33,7 +33,13 @@ const PWASettings: React.FC<PWASettingsProps> = ({ settings, onUpdate, onClose }
 
   const handleLinkClick = (url: string) => {
     if (onClose) onClose()
-    navigate(`/r/${encodeURIComponent(url)}`)
+    // If it's an internal route (starts with /), navigate directly
+    if (url.startsWith('/')) {
+      navigate(url)
+    } else {
+      // External URL: wrap with /r/ path
+      navigate(`/r/${encodeURIComponent(url)}`)
+    }
   }
 
   const handleClearCache = async () => {

src/hooks/useReadingPosition.ts

@@ -33,15 +33,11 @@ export const useReadingPosition = ({
   const suppressSavesFor = useCallback((ms: number) => {
     const until = Date.now() + ms
     suppressUntilRef.current = until
-    console.log(`[reading-position] [${new Date().toISOString()}] 🛡️ Suppressing saves for ${ms}ms until ${new Date(until).toISOString()}`)
   }, [])
 
-  // Throttled save function - saves at 3s intervals during scrolling
+  // Throttled save function - saves at 1s intervals during scrolling
   const scheduleSave = useCallback((currentPosition: number) => {
-    console.log(`[reading-position] [${new Date().toISOString()}] 📞 scheduleSave called at ${Math.round(currentPosition * 100)}%, syncEnabled=${syncEnabled}, hasOnSave=${!!onSave}`)
-    
     if (!syncEnabled || !onSave) {
-      console.log(`[reading-position] [${new Date().toISOString()}] ⏭️ Save skipped: syncEnabled=${syncEnabled}, hasOnSave=${!!onSave}`)
       return
     }
 
@@ -51,7 +47,6 @@ export const useReadingPosition = ({
         clearTimeout(saveTimerRef.current)
         saveTimerRef.current = null
       }
-      console.log(`[reading-position] [${new Date().toISOString()}] 💾 Instant save at 100% completion`)
       lastSaved100Ref.current = true
       onSave(1)
       return
@@ -61,18 +56,15 @@ export const useReadingPosition = ({
     pendingPositionRef.current = currentPosition
 
     // Throttle: only schedule a save if one isn't already pending
-    // This ensures saves happen at regular 3s intervals during continuous scrolling
+    // This ensures saves happen at regular 1s intervals during continuous scrolling
     if (saveTimerRef.current) {
-      console.log(`[reading-position] [${new Date().toISOString()}] ⏳ Timer already pending, updated pending position to ${Math.round(currentPosition * 100)}%`)
       return // Already have a save scheduled, don't reset the timer
     }
 
-    const THROTTLE_MS = 3000
-    console.log(`[reading-position] [${new Date().toISOString()}] ⏰ Scheduling save in ${THROTTLE_MS}ms`)
+    const THROTTLE_MS = 1000
     saveTimerRef.current = setTimeout(() => {
       // Save the latest position, not the one from when timer was scheduled
       const positionToSave = pendingPositionRef.current
-      console.log(`[reading-position] [${new Date().toISOString()}] 💾 Auto-save at ${Math.round(positionToSave * 100)}%`)
       onSave(positionToSave)
       saveTimerRef.current = null
     }, THROTTLE_MS)

src/services/readingPositionService.ts

@@ -203,14 +203,10 @@ export function collectReadingPositionsOnce(params: {
     hasEmitted = true
 
     if (candidates.length === 0) {
-      console.log('[reading-position] 📊 No candidates collected during stabilization window')
       stableCallback(null)
       return
     }
 
-    console.log('[reading-position] 📊 Collected', candidates.length, 'position candidates:', 
-      candidates.map(c => `${Math.round(c.position * 100)}% @${new Date(c.timestamp * 1000).toLocaleTimeString()}`).join(', '))
-
     // Sort: newest first, then highest progress
     candidates.sort((a, b) => {
       const timeDiff = b.timestamp - a.timestamp
@@ -218,13 +214,10 @@ export function collectReadingPositionsOnce(params: {
       return b.position - a.position
     })
 
-    console.log('[reading-position] ✅ Best position selected:', Math.round(candidates[0].position * 100) + '%', 
-      'from', new Date(candidates[0].timestamp * 1000).toLocaleTimeString())
     stableCallback(candidates[0])
   }
 
   // Start streaming and collecting
-  console.log('[reading-position] 🎯 Starting stabilized position collector (window:', windowMs, 'ms)')
   streamStop = startReadingPositionStream(
     relayPool,
     eventStore,
@@ -233,21 +226,16 @@ export function collectReadingPositionsOnce(params: {
     (pos) => {
       if (hasEmitted) return
       if (!pos) {
-        console.log('[reading-position] 📥 Received null position')
         return
       }
       if (pos.position <= 0.05 || pos.position >= 1) {
-        console.log('[reading-position] 🚫 Ignoring position', Math.round(pos.position * 100) + '% (outside 5%-100% range)')
         return
       }
       
-      console.log('[reading-position] 📥 Received position candidate:', Math.round(pos.position * 100) + '%', 
-        'from', new Date(pos.timestamp * 1000).toLocaleTimeString())
       candidates.push(pos)
 
       // Schedule one-shot emission if not already scheduled
       if (!timer) {
-        console.log('[reading-position] ⏰ Starting', windowMs, 'ms stabilization timer')
         timer = setTimeout(() => {
           emitStable()
           if (streamStop) streamStop()

src/services/settingsService.ts

@@ -62,6 +62,7 @@ export interface UserSettings {
   renderVideoLinksAsEmbeds?: boolean // default: false
   // Reading position sync
   syncReadingPosition?: boolean // default: false (opt-in)
+  autoScrollToReadingPosition?: boolean // default: true - automatically scroll to saved position when opening article
   autoMarkAsReadOnCompletion?: boolean // default: false (opt-in)
   // Bookmark filtering
   hideBookmarksWithoutCreationDate?: boolean // default: false

src/styles/components/reader.css

@@ -145,7 +145,7 @@
 }
 .reader-markdown blockquote, .reader-html blockquote { 
   margin: 1.5rem 0; 
-  padding: 1rem 0 1rem 2rem;
+  padding: 1rem 2rem;
   font-style: italic;
 }
 .reader-markdown blockquote p, .reader-html blockquote p { margin: 0.5rem 0; }
@@ -232,7 +232,7 @@
     max-width: 100%;
     width: 100%;
     margin: 0;
-    padding: 0.5rem;
+    padding: 0.5rem 1rem;
     border-radius: 0;
     border-left: none;
     border-right: none;
@@ -261,7 +261,7 @@
   .reader-header-overlay .reader-summary.hide-on-mobile { display: none; }
   .reader-summary-below-image { display: block; padding: 0 0 1.5rem 0; margin-top: -1rem; }
   .reader-summary-below-image .reader-summary { color: var(--color-text-secondary); font-size: 1rem; line-height: 1.6; margin: 0; }
-  .reader-hero-image { min-height: 280px; max-height: 400px; height: 50vh; }
+  .reader-hero-image { width: calc(100% + 2rem); margin: -0.5rem -1rem 2rem -1rem; min-height: 280px; max-height: 400px; height: 50vh; }
   .reader-hero-image img { height: 100%; width: 100%; object-fit: cover; object-position: center; }
   .reader-header-overlay { padding: 1.5rem 1rem 1rem; }
   .reader-header-overlay .reader-title { font-size: 2rem; line-height: 1.3; }