aljaz/boris
1
1
Fork 0
mirror of https://github.com/dergigi/boris.git synced 2025-12-25 10:34:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove setName filter from Amethyst bookmark grouping

Browse Source 
Fixed issue where 489 kind:30001 bookmarks were not appearing in groups
because they had setName: undefined instead of setName: 'bookmark'.

Changes:
- Removed setName === 'bookmark' requirement from amethystPublic/Private filters
- Now all kind:30001 bookmarks are grouped correctly regardless of setName
- Removed debug logging that was added to diagnose the issue

Before: Only 40 bookmarks shown (26 NIP-51 + 7 standalone + 7 web)
After: All 522 bookmarks shown (26 NIP-51 + 489 Amethyst + 7 web)
This commit is contained in:
Gigi
2025-10-18 00:44:54 +02:00
parent a3a00b8456
commit 3b08cd5d23
1 changed files with 3 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/utils/bookmarkUtils.tsx
View File

@@ -93,49 +93,14 @@ export const sortIndividualBookmarks = (items: IndividualBookmark[]) => {
export function groupIndividualBookmarks(items: IndividualBookmark[]) {
const sorted = sortIndividualBookmarks(items)
// Debug: log what sourceKind values we're seeing
const sourceKindCounts = new Map<number | undefined, number>()
sorted.forEach(i => {
const count = sourceKindCounts.get(i.sourceKind) || 0
sourceKindCounts.set(i.sourceKind, count + 1)
})
console.log('[bookmark] 📊 SourceKind distribution:', Object.fromEntries(sourceKindCounts))
// Sample a few items to see their properties
const samples = sorted.slice(0, 5).map(i => ({
sourceKind: i.sourceKind,
isPrivate: i.isPrivate,
setName: i.setName,
id: i.id.slice(0, 20)
}))
console.log('[bookmark] 📊 Sample items:', samples)
// Debug: Show setName distribution for kind:30001
const kind30001Items = sorted.filter(i => i.sourceKind === 30001)
const setNameCounts = new Map<string | undefined, number>()
kind30001Items.forEach(i => {
const count = setNameCounts.get(i.setName) || 0
setNameCounts.set(i.setName, count + 1)
})
console.log('[bookmark] 📊 kind:30001 setName distribution:', Object.fromEntries(setNameCounts))
// Group by source list, not by content type
const nip51Public = sorted.filter(i => i.sourceKind === 10003 && !i.isPrivate)
const nip51Private = sorted.filter(i => i.sourceKind === 10003 && i.isPrivate)
// Amethyst bookmarks: kind:30001 with d-tag "bookmark"
const amethystPublic = sorted.filter(i => i.sourceKind === 30001 && !i.isPrivate && i.setName === 'bookmark')
const amethystPrivate = sorted.filter(i => i.sourceKind === 30001 && i.isPrivate && i.setName === 'bookmark')
// Amethyst bookmarks: kind:30001 (any d-tag or undefined)
const amethystPublic = sorted.filter(i => i.sourceKind === 30001 && !i.isPrivate)
const amethystPrivate = sorted.filter(i => i.sourceKind === 30001 && i.isPrivate)
const standaloneWeb = sorted.filter(i => i.sourceKind === 39701)
console.log('[bookmark] 📊 After grouping:', {
nip51Public: nip51Public.length,
nip51Private: nip51Private.length,
amethystPublic: amethystPublic.length,
amethystPrivate: amethystPrivate.length,
standaloneWeb: standaloneWeb.length,
total: sorted.length
})
return {
nip51Public,
nip51Private,