aljaz/ark
1
0
Fork 0
mirror of https://github.com/aljazceru/ark.git synced 2025-12-17 20:24:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Panic recovery in app svc (#372)

Browse Source 
* panic recovery

* pr review
This commit is contained in:
Dusan Sekulic
2024-11-18 12:29:23 +01:00
committed by GitHub
parent ff96524f22
commit acb54436dd
2 changed files with 110 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
server/internal/core/application/covenant.go
View File

@@ -92,8 +92,23 @@ func NewCovenantService(
repoManager.RegisterEventsHandler(
func(round *domain.Round) {
go svc.propagateEvents(round)
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in propagateEvents: %v", r)
}
}()
svc.propagateEvents(round)
}()
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in updateVtxoSet and scheduleSweepVtxosForRound: %v", r)
}
}()
// utxo db must be updated before scheduling the sweep events
svc.updateVtxoSet(round)
svc.scheduleSweepVtxosForRound(round)
@@ -437,6 +452,12 @@ func (s *covenantService) DeleteNostrRecipient(ctx context.Context, signedVtxoOu
}
func (s *covenantService) start() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in start: %v", r)
}
}()
s.startRound()
}
@@ -646,12 +667,24 @@ func (s *covenantService) finalizeRound() {
}
func (s *covenantService) listenToScannerNotifications() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in listenToScannerNotifications: %v", r)
}
}()
ctx := context.Background()
chVtxos := s.scanner.GetNotificationChannel(ctx)
mutx := &sync.Mutex{}
for vtxoKeys := range chVtxos {
go func(vtxoKeys map[string][]ports.VtxoWithValue) {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in GetVtxos goroutine: %v", r)
}
}()
vtxosRepo := s.repoManager.Vtxos()
for _, keys := range vtxoKeys {
@@ -665,6 +698,12 @@ func (s *covenantService) listenToScannerNotifications() {
if !vtxo.Redeemed {
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in markAsRedeemed goroutine: %v", r)
}
}()
if err := s.markAsRedeemed(ctx, vtxo); err != nil {
log.WithError(err).Warnf("failed to mark vtxo %s:%d as redeemed", vtxo.Txid, vtxo.VOut)
}
@@ -674,6 +713,12 @@ func (s *covenantService) listenToScannerNotifications() {
if vtxo.Spent {
log.Infof("fraud detected on vtxo %s:%d", vtxo.Txid, vtxo.VOut)
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in reactToFraud goroutine: %v", r)
}
}()
if err := s.reactToFraud(ctx, vtxo, mutx); err != nil {
log.WithError(err).Warnf("failed to prevent fraud for vtxo %s:%d", vtxo.Txid, vtxo.VOut)
}
@@ -867,6 +912,12 @@ func (s *covenantService) updateVtxoSet(round *domain.Round) {
}
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in startWatchingVtxos: %v", r)
}
}()
for {
if err := s.startWatchingVtxos(newVtxos); err != nil {
log.WithError(err).Warn(
@@ -881,6 +932,12 @@ func (s *covenantService) updateVtxoSet(round *domain.Round) {
}
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in RoundTransactionEvent: %v", r)
}
}()
// nolint:all
tx, _ := psetv2.NewPsetFromBase64(round.UnsignedTx)
boardingInputs := make([]domain.VtxoKey, 0)

53
server/internal/core/application/covenantless.go
View File

@@ -95,8 +95,23 @@ func NewCovenantlessService(
repoManager.RegisterEventsHandler(
func(round *domain.Round) {
go svc.propagateEvents(round)
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in propagateEvents: %v", r)
}
}()
svc.propagateEvents(round)
}()
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in updateVtxoSet and scheduleSweepVtxosForRound: %v", r)
}
}()
// utxo db must be updated before scheduling the sweep events
svc.updateVtxoSet(round)
svc.scheduleSweepVtxosForRound(round)
@@ -784,6 +799,12 @@ func (s *covenantlessService) DeleteNostrRecipient(ctx context.Context, signedVt
}
func (s *covenantlessService) start() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in start: %v", r)
}
}()
s.startRound()
}
@@ -1209,12 +1230,24 @@ func (s *covenantlessService) finalizeRound(notes []note.Note) {
}
func (s *covenantlessService) listenToScannerNotifications() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in listenToScannerNotifications: %v", r)
}
}()
ctx := context.Background()
chVtxos := s.scanner.GetNotificationChannel(ctx)
mutx := &sync.Mutex{}
for vtxoKeys := range chVtxos {
go func(vtxoKeys map[string][]ports.VtxoWithValue) {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in GetVtxos: %v", r)
}
}()
for _, keys := range vtxoKeys {
for _, v := range keys {
vtxos, err := s.repoManager.Vtxos().GetVtxos(ctx, []domain.VtxoKey{v.VtxoKey})
@@ -1226,6 +1259,12 @@ func (s *covenantlessService) listenToScannerNotifications() {
if !vtxo.Redeemed {
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in markAsRedeemed: %v", r)
}
}()
if err := s.markAsRedeemed(ctx, vtxo); err != nil {
log.WithError(err).Warnf("failed to mark vtxo %s:%d as redeemed", vtxo.Txid, vtxo.VOut)
}
@@ -1235,6 +1274,12 @@ func (s *covenantlessService) listenToScannerNotifications() {
if vtxo.Spent {
log.Infof("fraud detected on vtxo %s:%d", vtxo.Txid, vtxo.VOut)
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in reactToFraud: %v", r)
}
}()
if err := s.reactToFraud(ctx, vtxo, mutx); err != nil {
log.WithError(err).Warnf("failed to prevent fraud for vtxo %s:%d", vtxo.Txid, vtxo.VOut)
}
@@ -1360,6 +1405,12 @@ func (s *covenantlessService) updateVtxoSet(round *domain.Round) {
}
go func() {
defer func() {
if r := recover(); r != nil {
log.Errorf("recovered from panic in startWatchingVtxos: %v", r)
}
}()
for {
if err := s.startWatchingVtxos(newVtxos); err != nil {
log.WithError(err).Warn(