Commit Graph

1201 Commits

Author SHA1 Message Date
mattcurts
0a967c99e0 Confirm Old Team Password (#2261)
* Update language for updating team password

---------

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-04-27 01:56:27 -04:00
skandix
25b3d77ed0 bump SQLAlchemy-Utils to version 0.41.0 (#2294)
* Bump down SQLAlchemy-Utils to version 0.41.0

* Update development dependencies

---------

Signed-off-by: Bendik Dyrli <skandix@datapor.no>
Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-04-27 01:38:31 -04:00
Peyton Duncan
ab91e7df34 SMTP TLS/SSL Labels to Match Thunderbird (#2293)
* TLS/SSL Labels to Match Thunderbird

Replaced TLS and SSL checkbox text to match the
defaults used by Mozilla Thunderbird to eliminate confusion when
configuring SMTP

* Add link to email server documentation

* Properly save changes

---------

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-04-27 00:53:59 -04:00
Kevin Chung
2a6f47d2ea Change email whitelist error message to not include the list of allowed domains (#2286)
* Change email whitelist error message to not include the list of allowed domains
2023-04-13 14:23:18 -04:00
dependabot[bot]
440aaddfb1 Bump redis from 3.5.2 to 4.4.4 (#2275)
Bumps [redis](https://github.com/redis/redis-py) from 3.5.2 to 4.4.4.
- [Release notes](https://github.com/redis/redis-py/releases)
- [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES)
- [Commits](https://github.com/redis/redis-py/compare/3.5.2...v4.4.4)

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-04-13 01:55:16 -04:00
Kevin Chung
c405fbb9b1 Bump pybluemonday version (#2285)
* Bump pybluemonday version
* Remove codecov from development.txt
2023-04-13 01:36:08 -04:00
Alper Berber
23c7b2f90f use ruff instead of flake8 (#2278)
* add: use ruff instead of flake8

* Update ruff switches and remove flake8 plugins

* fix: ignore linting rules

* fix: ignore I001

* fix: spaces before noqa

---------

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-04-11 11:20:48 -04:00
Smyler
faa937020a Prevent race conditions on /healthcheck (#2273)
In a high availability deployment scenario, two clients may make a request on /healthcheck at the exact same time, which can lead to check_config returning False if the second requests changes the 'healthcheck' cache key before the first one has had time to fetch the value it had set.

A solution to counter this is to ensure different keys are used for each healthcheck.
2023-04-03 02:01:17 -04:00
Kevin Chung
870eefb184 Fix issue where we are double processing config.ini items (#2274)
* In some cases with numeric config items it appears that we can end up processing a string twice. This issue fixes it so that we only process the strings once at configparser load time with `before_get`
2023-03-28 14:07:52 -04:00
Kevin Chung
b17adaf7aa Add support for robots.txt (#2269)
* Adds support for admins to control `robots.txt`
* Closes #2141
2023-03-12 17:03:35 -04:00
Kevin Chung
68da00900a Add freezegun to runtime dependencies, generate cachable s3 urls (#2264)
* Add freezegun to application dependencies
* Generate cachable S3 URLs by rounding time down to the previous hour to generate a consistent URL
2023-02-19 15:01:28 -05:00
Kevin Chung
c8dbfa6050 Fix Dockerfile venv so plugins can be installed at runtime (#2260)
* Set ownership of venv in Dockerfile to 1001
2023-02-14 21:22:29 -05:00
Kevin Chung
472010fcc2 Fix scoreboard detail count parameter (#2256)
* Add int requirement to `/api/v1/scoreboard/top/<count>`
2023-02-09 12:27:47 -05:00
Kevin Chung
68c3438474 Fix issue where dynamic challenges break if the decay is 0 (#2255)
* Fix issue where dynamic challenges break if the decay is 0
* Prevent users from adding a decay limit of 0 to dynamic value challenges
2023-02-08 13:22:16 -05:00
Kevin Chung
0f0064535c Clean up the aesthetics for the 'Pause CTF' and 'View After CTF' configs (#2250)
* Clean up the aesthetics for the 'Pause CTF' and 'View After CTF' configs
* Closes #2128
2023-01-28 04:21:16 -05:00
Eduardo Santos
fe9ba03e3b Add support for Docker multi-stage builds (#2228)
Separate docker build into two stagesto discard several binaries, builder, compiler and dev dependencies not needed for production usage. Run CTFd in a venv in `/opt/venv`. Reduce the image size from 648MB to 398MB.

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2023-01-25 12:56:51 -05:00
Kevin Chung
89289ad641 Mark 3.5.1 (#2246)
# 3.5.1 / 2023-01-23

**General**

- The public scoreboard page is no longer shown to users if account visibility is disabled
- Teams created by admins using the normal team creation flow are now hidden by default
- Redirect users to the team creation page if they access a certain pages before the CTF starts
- Added a notice on the Challenges page to remind Admins if they are in Admins Only mode
- Fixed an issue where users couldn't login to their team even though they were already on the team
- Fixed an issue with scoreboard tie breaking when an award results in a tie
- Fixed the order of solves, fails, and awards to always be in chronological ordering (latest first).
- Fixed an issue where certain custom fields could not be submitted

**Admin Panel**

- Improved the rendering of Admin Panel tables on mobile devices
- Clarified the behavior of Score Visibility with respect to Account Visibility in the Admin Panel help text
- Added user id and user email fields to the user mode scoreboard CSV export
- Add CSV export for `teams+members+fields` which is teams with Custom Field entries and their team members with Custom Field entries
- The import process will now catch all exceptions in the import process to report them in the Admin Panel
- Fixed issue where `field_entries` could not be imported under MariaDB
- Fixed issue where `config` entries sometimes would be recreated for some reason causing an import to fail
- Fixed issue with Firefox caching checkboxes by adding `autocomplete='off'` to Admin Panel pages
- Fixed issue where Next selection for a challenge wouldn't always load in Admin Panel

**API**

- Improve response time of `/api/v1/challenges` and `/api/v1/challenges/[challenge_id]/solves` by caching the solve count data for users and challenges
- Add `HEAD /api/v1/notifications` to get a count of notifications that have happened. 
  - This also includes a `since_id` parameter to allow for a notification cursor.
  - Unread notification count can now be tracked by themes that track which notifications a user has read
- Add `since_id` to `GET /api/v1/notifications` to get Notifications that have happened since a specific ID

**Deployment**

- Imports have been disabled when running with a SQLite database backend
  - See https://github.com/CTFd/CTFd/issues/2131
- Added `/healthcheck` endpoint to check if CTFd is ready
- There are now ARM Docker images for OSS CTFd
- Bump dependencies for passlib, bcrypt, requests, gunicorn, gevent, python-geoacumen-city
- Properly load `SAFE_MODE` config from environment variable
- The `AWS_S3_REGION` config has been added to allow specifying an S3 region. The default is `us-east-1`
- Add individual DATABASE config keys as an alternative to `DATABASE_URL`
  - `DATABASE_PROTOCOL`: SQLAlchemy DB protocol (+ driver, optionally)
  - `DATABASE_USER`: Username to access DB server with
  - `DATABASE_PASSWORD`: Password to access DB server with
  - `DATABASE_HOST`: Hostname of the DB server to access
  - `DATABASE_PORT`: Port of the DB server to access
  - `DATABASE_NAME`: Name of the database to use
- Add individual REDIS config keys as an alternative to `REDIS_URL`
  - `REDIS_PROTOCOL`: Protocol to access Redis server with (either redis or rediss)
  - `REDIS_USER`: Username to access Redis server with
  - `REDIS_PASSWORD`: Password to access Redis server with
  - `REDIS_HOST`: Hostname of the Redis server to access
  - `REDIS_PORT`: Port of the Redis server to access
  - `REDIS_DB`: Numeric ID of the database to access

**Plugins**

- Adds support for `config.json` to have multiple paths to add to the Plugins dropdown in the Admin Panel
- Plugins and their migrations now have access to the `get_all_tables` and `get_columns_for_table` functions
- Email sending functions have now been seperated into classes that can be customized via plugins.
  - Add `CTFd.utils.email.providers.EmailProvider`
  - Add `CTFd.utils.email.providers.mailgun.MailgunEmailProvider`
  - Add `CTFd.utils.email.providers.smtp.SMTPEmailProvider`
  - Deprecate `CTFd.utils.email.mailgun.sendmail`
  - Deprecate `CTFd.utils.email.smtp.sendmail`

**Themes**

- The beta interface `Assets.manifest_css` has been removed
- `event-source-polyfill` is now pinned to 1.0.19.
  - See https://github.com/CTFd/CTFd/issues/2159
  - Note that we will not be using this polyfill starting with the `core-beta` theme.
- Add autofocus to text fields on authentication pages
2023-01-23 10:34:49 -05:00
Bin We
57e2154e04 Fix display error on mobile devices (#2244)
* Add table-responsive class to more tables in the Admin Panel to improve mobile view
2023-01-21 03:33:26 -05:00
Thomas Bork
49bc81e517 Add individual REDIS_* options, as an alternative to REDIS_URL (#2245)
* Add individual REDIS_* options, as an alternative to REDIS_URL

* Clarify supported protocols for REDIS_PROTOCOL setting
2023-01-18 23:05:01 -05:00
Thomas Bork
6f8f7d928c Add individual DATABASE_* options, as an alternative to DATABASE_URL (#2237)
Co-authored-by: Kevin Chung <kchung@ctfd.io>
2022-12-23 00:10:27 -05:00
dependabot[bot]
167bac79bb Bump certifi from 2020.11.8 to 2022.12.7 (#2234)
Bumps [certifi](https://github.com/certifi/python-certifi) from 2020.11.8 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](https://github.com/certifi/python-certifi/compare/2020.11.08...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-13 23:47:05 -07:00
Cryptanalyse
3c299095cb Fix the order of the solves of the user pages to the chronological ordering (latest first). (#2108)
* Fix the order of the solves, fails, awards to be chronological ordering (latest first).
2022-12-07 13:26:50 -05:00
Kevin Chung
d89ac579f2 Cache challenge data for faster loading of /api/v1/challenges (#2232)
* Improve response time of `/api/v1/challenges` and `/api/v1/challenges/[challenge_id]/solves`
* Rewrite and remove _build_solves_query to make it cacheable
* Closes #2209
2022-12-05 00:10:30 -05:00
Kevin Chung
800fb8260a Clarify Score Visibility and Account Visibility (#2227)
* Don't show /scoreboard if we do not have account_visibility
* Clarify the behavior of Score Visibility with respect to Account Visibility
2022-12-03 12:16:11 -05:00
Eduardo Santos
7e575a2e47 Bump CTFd dependencies (#2229)
Bump bcrypt, gevent, greenlet, python-geoacumen-city, requests.
2022-11-18 12:42:34 -05:00
Kevin Chung
e4a605e235 Change sendmail functions into classes that can be overriden from a plugin (#2221)
* Change sendmail functions into classes that can be overriden from a plugin
* Deprecate `CTFd.utils.email.mailgun.sendmail`
* Deprecate `CTFd.utils.email.smtp.sendmail`
2022-11-06 17:37:15 -05:00
Kevin Chung
dfa7f87823 Adding more protections for 502's during imports (#2220)
* Be more defensive on asset loading during imports
* On primary databases only import backups when we are actually able to make it to the target migration
2022-11-05 19:08:12 -04:00
Kevin Chung
95bfb96a82 Add names_only parameter to get_columns_for_table (#2219) 2022-11-05 18:12:19 -04:00
Kevin Chung
5daa85fce6 Fix other issues wih missing autocomplete='off' (#2217) 2022-11-05 11:55:40 -04:00
Bradley Jenkins
54ebf824f6 Allow /healthcheck endpoint to bypass setup (#2215)
* fixes #2214: https://petsathome.atlassian.net/browse/PDE-2132: Added "views.healthcheck"

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2022-11-05 09:21:14 -04:00
Kevin Chung
a085d0922a Fix issue with scoreboard ordering when an award results in a tie (#2212)
* Fix issue with scoreboard ordering when an award results in a tie
* Closes #833
2022-11-02 16:56:23 -04:00
Ty Rieckmann
ac7d5c7214 Add autofocus to text fields on authentication pages (#2196)
* Add autofocus to text fields on authentication pages
2022-10-16 15:07:44 -04:00
Kevin Chung
9e3ebfd301 Fix issue where Next selection wouldn't always load in Admin Panel also Closes #2159 (#2199)
* Fix issue where Next selection wouldn't always load in Admin Panel 
* Closes #2159 by pinning `event-source-polyfill` to 1.0.19. Note that we will not be using this polyfill starting with the `core-beta` theme.
2022-10-15 03:41:06 -04:00
Kevin Chung
96e6d66120 Fix issue where users could login to their team even though they were already on the team (#2198)
* Fix issue where users couldn't login to their team even though they were already on the team
2022-10-14 04:26:00 -04:00
Smyler
eb66034aae Add S3 region support (#2188)
Co-authored-by: Smyler <smyler@hackademint.org>
2022-09-30 03:46:47 -04:00
Janos Bonic
02c08f50cc Redirect users to team creation before event start (#2185)
* Redirect users to the team creation page if they access a during_ctf_time_only page before the CTF starts
2022-09-23 00:35:43 -04:00
Brendan McShane
04de6c0b4f Update Docker Image CI/CD (#2183)
* Update docker-build.yml to provide ARM builds
2022-09-15 16:24:58 -04:00
Kevin Chung
4793d95338 Emit more theme init data using tojson (#2182)
* Emit more theme init data using tojson
* Add `teamId` and `teamName` into admin `base.html`
2022-09-07 14:40:42 -04:00
Kevin Chung
328b523b24 Fix issue with dynamic_challenges migration loading (#2179) 2022-08-31 11:52:20 -04:00
Kevin Chung
ae29dca881 Add mechanism for plugin migrations to get current tables and columns (#2175)
* Add mechanism for plugin migrations to get current tables and columns
2022-08-26 04:09:43 -04:00
Miłosz Skaza
aeee3db3be fix: checkboxes in theme config window (#2172)
* fix: checkboxes in theme config window
2022-08-24 17:00:53 -04:00
Kevin Chung
22ae3a8eb7 Don't error out if SAFE_MODE config doesn't exist (#2173) 2022-08-24 12:13:57 -04:00
Kevin Chung
541b3f5570 Specifically load a plugin's alembic_version from the database (#2170)
* Specifically load a plugin's alembic_version from the database
2022-08-23 16:05:51 -04:00
Kevin Chung
09f58705a3 Load SAFE_MODE config from envvar (#2169)
* Properly load `SAFE_MODE` config from environment variable
* Closes #2168
2022-08-23 15:24:52 -04:00
Kevin Chung
e0290cc67b Notifications improvements (#2166)
* Improve event `ping`s to actually include data so that they show up in devtools
* Improve Event publishers to take an `id` parameter that is sent to the browser
* Add a `since_id` parameter to `GET /api/v1/notifications` to get Notifications that have happened since a specific ID
* Add `HEAD /api/v1/notifications` to get a count of notifications that have happened. This also includes a `since_id` parameter to allow for a notification cursor.
2022-08-15 17:35:01 -04:00
Niklas Mollenhauer
d1e9ab45bb Use binaries in PATH in npm run scripts (#2163)
When running software installed via NPM, `node_modules/.bin` is in PATH, so we can just omit mos tof the path.

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2022-08-15 15:37:37 -04:00
Kevin Chung
2a8aa48a32 Remove the Assets.manifest_css method as manifest-css.json is no longer necessary (#2164)
* Remove the Assets.manifest_css method as manifest-css.json is no longer necessary
* Related to https://github.com/CTFd/core-beta/pull/22
2022-08-10 15:30:52 -04:00
Dustin Loring
11a18daf98 Made get_configurable_plugins work nicely with config.jsons that include multiple plugin entries as a list (#2161)
* Adds support for config.json to have multiple paths to add to the Plugins dropdown in the Admin Panel
* Closes #1370
2022-08-08 14:28:48 -04:00
Kevin Chung
471bd48f1c Add autocomplete='off' to admin pages to fix Firefox caching checkboxes (#2158)
* Add autocomplete='off' to admin pages to fix Firefox caching checkboxes
2022-07-31 22:18:58 -04:00
Anders Soh
4c0f98f078 validate value type is string before using strip (#2155)
* Fix issue where required custom fields could not be submitted for existing users

Co-authored-by: Kevin Chung <kchung@ctfd.io>
2022-07-31 16:20:14 -04:00