turso/core/translate/trigger_exec.rs

use crate::schema::{BTreeTable, Trigger};
use crate::translate::emitter::Resolver;
use crate::translate::expr::translate_expr;
use crate::translate::{translate_inner, ProgramBuilder, ProgramBuilderOpts};
use crate::util::normalize_ident;
use crate::vdbe::insn::Insn;
use crate::{bail_parse_error, QueryMode, Result, Statement};
use parking_lot::RwLock;
use std::collections::HashSet;
use std::num::NonZero;
use std::sync::Arc;
use turso_parser::ast::{self, Expr, TriggerEvent, TriggerTime};

/// Context for trigger execution
#[derive(Debug)]
pub struct TriggerContext {
    /// Table the trigger is attached to
    pub table: Arc<BTreeTable>,
    /// NEW row registers (for INSERT/UPDATE). The last element is always the rowid.
    pub new_registers: Option<Vec<usize>>,
    /// OLD row registers (for UPDATE/DELETE). The last element is always the rowid.
    pub old_registers: Option<Vec<usize>>,
}

impl TriggerContext {
    pub fn new(
        table: Arc<BTreeTable>,
        new_registers: Option<Vec<usize>>,
        old_registers: Option<Vec<usize>>,
    ) -> Self {
        Self {
            table,
            new_registers,
            old_registers,
        }
    }
}

/// Context for compiling trigger subprograms - maps NEW/OLD to parameter indices
#[derive(Debug)]
struct TriggerSubprogramContext {
    /// Map from column index to parameter index for NEW values (1-indexed)
    new_param_map: Option<Vec<NonZero<usize>>>,
    /// Map from column index to parameter index for OLD values (1-indexed)
    old_param_map: Option<Vec<NonZero<usize>>>,
    table: Arc<BTreeTable>,
}

/// Rewrite NEW and OLD references in trigger expressions to use Variable instructions (parameters)
fn rewrite_trigger_expr_for_subprogram(
    expr: &mut ast::Expr,
    table: &BTreeTable,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;
    use crate::translate::expr::WalkControl;

    walk_expr_mut(expr, &mut |e: &mut ast::Expr| -> Result<WalkControl> {
        match e {
            Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
                let ns = normalize_ident(ns.as_str());
                let col = normalize_ident(col.as_str());

                // Handle NEW.column references
                if ns.eq_ignore_ascii_case("new") {
                    if let Some(new_params) = &ctx.new_param_map {
                        // Check if this is a rowid alias column first
                        if let Some((idx, col_def)) = table.get_column(&col) {
                            if col_def.is_rowid_alias() {
                                // Rowid alias columns map to the rowid parameter, not the column register
                                *e = Expr::Variable(format!(
                                    "{}",
                                    *ctx.new_param_map
                                        .as_ref()
                                        .expect("NEW parameters must be provided")
                                        .last()
                                        .expect("NEW parameters must be provided")
                                ));
                                return Ok(WalkControl::Continue);
                            }
                            if idx < new_params.len() {
                                *e = Expr::Variable(format!("{}", new_params[idx].get()));
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle NEW.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.new_param_map
                                    .as_ref()
                                    .expect("NEW parameters must be provided")
                                    .last()
                                    .expect("NEW parameters must be provided")
                                    .get()
                            ));
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in NEW: {}", col);
                    } else {
                        bail_parse_error!(
                            "NEW references are only valid in INSERT and UPDATE triggers"
                        );
                    }
                }

                // Handle OLD.column references
                if ns.eq_ignore_ascii_case("old") {
                    if let Some(old_params) = &ctx.old_param_map {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < old_params.len() {
                                *e = Expr::Variable(format!("{}", old_params[idx].get()));
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle OLD.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.old_param_map
                                    .as_ref()
                                    .expect("OLD parameters must be provided")
                                    .last()
                                    .expect("OLD parameters must be provided")
                                    .get()
                            ));
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in OLD: {}", col);
                    } else {
                        bail_parse_error!(
                            "OLD references are only valid in UPDATE and DELETE triggers"
                        );
                    }
                }

                // Handle unqualified column references - they refer to NEW if available, else OLD
                if let Some((idx, _)) = table.get_column(&col) {
                    if let Some(new_params) = &ctx.new_param_map {
                        if idx < new_params.len() {
                            *e = Expr::Variable(format!("{}", new_params[idx].get()));
                            return Ok(WalkControl::Continue);
                        }
                    }
                    if let Some(old_params) = &ctx.old_param_map {
                        if idx < old_params.len() {
                            *e = Expr::Variable(format!("{}", old_params[idx].get()));
                            return Ok(WalkControl::Continue);
                        }
                    }
                }

                Ok(WalkControl::Continue)
            }
            _ => Ok(WalkControl::Continue),
        }
    })?;
    Ok(())
}

/// Convert TriggerCmd to Stmt, rewriting NEW/OLD to Variable expressions (for subprogram compilation)
fn trigger_cmd_to_stmt_for_subprogram(
    cmd: &ast::TriggerCmd,
    subprogram_ctx: &TriggerSubprogramContext,
) -> Result<ast::Stmt> {
    use turso_parser::ast::{InsertBody, QualifiedName};

    match cmd {
        ast::TriggerCmd::Insert {
            or_conflict,
            tbl_name,
            col_names,
            select,
            upsert,
            returning,
        } => {
            // Rewrite NEW/OLD references in the SELECT
            let mut select_clone = select.clone();
            rewrite_expressions_in_select_for_subprogram(&mut select_clone, subprogram_ctx)?;

            let body = InsertBody::Select(select_clone, upsert.clone());
            Ok(ast::Stmt::Insert {
                with: None,
                or_conflict: *or_conflict,
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                columns: col_names.clone(),
                body,
                returning: returning.clone(),
            })
        }
        ast::TriggerCmd::Update {
            or_conflict,
            tbl_name,
            sets,
            from,
            where_clause,
        } => {
            // Rewrite NEW/OLD references in SET clauses and WHERE clause
            let mut sets_clone = sets.clone();
            for set in &mut sets_clone {
                rewrite_trigger_expr_for_subprogram(
                    &mut set.expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            let mut where_clause_clone = where_clause.clone();
            if let Some(ref mut where_expr) = where_clause_clone {
                rewrite_trigger_expr_for_subprogram(
                    where_expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            Ok(ast::Stmt::Update(ast::Update {
                with: None,
                or_conflict: *or_conflict,
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                indexed: None,
                sets: sets_clone,
                from: from.clone(),
                where_clause: where_clause_clone,
                returning: vec![],
                order_by: vec![],
                limit: None,
            }))
        }
        ast::TriggerCmd::Delete {
            tbl_name,
            where_clause,
        } => {
            // Rewrite NEW/OLD references in WHERE clause
            let mut where_clause_clone = where_clause.clone();
            if let Some(ref mut where_expr) = where_clause_clone {
                rewrite_trigger_expr_for_subprogram(
                    where_expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            Ok(ast::Stmt::Delete {
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                where_clause: where_clause_clone,
                limit: None,
                returning: vec![],
                indexed: None,
                order_by: vec![],
                with: None,
            })
        }
        ast::TriggerCmd::Select(select) => {
            // Rewrite NEW/OLD references in the SELECT
            let mut select_clone = select.clone();
            rewrite_expressions_in_select_for_subprogram(&mut select_clone, subprogram_ctx)?;
            Ok(ast::Stmt::Select(select_clone))
        }
    }
}

/// Rewrite NEW/OLD references in all expressions within a SELECT statement for subprogram
fn rewrite_expressions_in_select_for_subprogram(
    select: &mut ast::Select,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;

    // Rewrite expressions in the SELECT body
    match &mut select.body.select {
        ast::OneSelect::Select {
            columns,
            where_clause,
            group_by,
            ..
        } => {
            // Rewrite in columns
            for col in columns {
                if let ast::ResultColumn::Expr(ref mut expr, _) = col {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }

            // Rewrite in WHERE clause
            if let Some(ref mut where_expr) = where_clause {
                walk_expr_mut(where_expr, &mut |e: &mut ast::Expr| {
                    rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                    Ok(crate::translate::expr::WalkControl::Continue)
                })?;
            }

            // Rewrite in GROUP BY expressions and HAVING clause
            if let Some(ref mut group_by) = group_by {
                for expr in &mut group_by.exprs {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }

                // Rewrite in HAVING clause
                if let Some(ref mut having_expr) = group_by.having {
                    walk_expr_mut(having_expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }
        }
        ast::OneSelect::Values(values) => {
            for row in values {
                for expr in row {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }
        }
    }

    Ok(())
}

/// Rewrite a single NEW/OLD reference for subprogram (called from walk_expr_mut)
fn rewrite_trigger_expr_single_for_subprogram(
    e: &mut ast::Expr,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    match e {
        Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
            let ns = normalize_ident(ns.as_str());
            let col = normalize_ident(col.as_str());

            // Handle NEW.column references
            if ns.eq_ignore_ascii_case("new") {
                if let Some(new_params) = &ctx.new_param_map {
                    if let Some((idx, col_def)) = ctx.table.get_column(&col) {
                        if col_def.is_rowid_alias() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.new_param_map
                                    .as_ref()
                                    .expect("NEW parameters must be provided")
                                    .last()
                                    .expect("NEW parameters must be provided")
                                    .get()
                            ));
                            return Ok(());
                        }
                        if idx < new_params.len() {
                            *e = Expr::Variable(format!("{}", new_params[idx].get()));
                            return Ok(());
                        }
                    }
                    // Handle NEW.rowid
                    if crate::translate::planner::ROWID_STRS
                        .iter()
                        .any(|s| s.eq_ignore_ascii_case(&col))
                    {
                        *e = Expr::Variable(format!(
                            "{}",
                            ctx.new_param_map
                                .as_ref()
                                .expect("NEW parameters must be provided")
                                .last()
                                .expect("NEW parameters must be provided")
                                .get()
                        ));
                        return Ok(());
                    }
                    bail_parse_error!("no such column in NEW: {}", col);
                } else {
                    bail_parse_error!(
                        "NEW references are only valid in INSERT and UPDATE triggers"
                    );
                }
            }

            // Handle OLD.column references
            if ns.eq_ignore_ascii_case("old") {
                if let Some(old_params) = &ctx.old_param_map {
                    if let Some((idx, col_def)) = ctx.table.get_column(&col) {
                        if col_def.is_rowid_alias() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.old_param_map
                                    .as_ref()
                                    .expect("OLD parameters must be provided")
                                    .last()
                                    .expect("OLD parameters must be provided")
                                    .get()
                            ));
                            return Ok(());
                        }
                        if idx < old_params.len() {
                            *e = Expr::Variable(format!("{}", old_params[idx].get()));
                            return Ok(());
                        }
                    }
                    // Handle OLD.rowid
                    if crate::translate::planner::ROWID_STRS
                        .iter()
                        .any(|s| s.eq_ignore_ascii_case(&col))
                    {
                        *e = Expr::Variable(format!(
                            "{}",
                            ctx.old_param_map
                                .as_ref()
                                .expect("OLD parameters must be provided")
                                .last()
                                .expect("OLD parameters must be provided")
                                .get()
                        ));
                        return Ok(());
                    }
                    bail_parse_error!("no such column in OLD: {}", col);
                } else {
                    bail_parse_error!(
                        "OLD references are only valid in UPDATE and DELETE triggers"
                    );
                }
            }

            // Handle unqualified column references - they refer to NEW if available, else OLD
            if let Some((idx, col_def)) = ctx.table.get_column(&col) {
                if col_def.is_rowid_alias() {
                    *e = Expr::Variable(format!(
                        "{}",
                        ctx.new_param_map
                            .as_ref()
                            .expect("NEW parameters must be provided")
                            .last()
                            .expect("NEW parameters must be provided")
                            .get()
                    ));
                    return Ok(());
                }
                if let Some(new_params) = &ctx.new_param_map {
                    if idx < new_params.len() {
                        *e = Expr::Variable(format!("{}", new_params[idx].get()));
                        return Ok(());
                    }
                }
                if let Some(old_params) = &ctx.old_param_map {
                    if idx < old_params.len() {
                        *e = Expr::Variable(format!("{}", old_params[idx].get()));
                        return Ok(());
                    }
                }
            }
        }
        _ => {}
    }
    Ok(())
}

/// Execute trigger commands by compiling them as a subprogram and emitting Program instruction
/// Returns true if there are triggers that will fire.
fn execute_trigger_commands(
    program: &mut ProgramBuilder,
    resolver: &mut Resolver,
    trigger: &Arc<Trigger>,
    ctx: &TriggerContext,
    connection: &Arc<crate::Connection>,
) -> Result<bool> {
    if connection.trigger_is_compiling(trigger) {
        // Do not recursively compile the same trigger
        return Ok(false);
    }
    connection.start_trigger_compilation(trigger.clone());
    // Build parameter mapping: parameters are 1-indexed and sequential
    // Order: [NEW values..., OLD values..., rowid]
    // So if we have 2 NEW columns, 2 OLD columns: NEW params are 1,2; OLD params are 3,4; rowid is 5
    let num_new = ctx.new_registers.as_ref().map(|r| r.len()).unwrap_or(0);

    let new_param_map: Option<Vec<NonZero<usize>>> = ctx.new_registers.as_ref().map(|new_regs| {
        (1..=new_regs.len())
            .map(|i| NonZero::new(i).unwrap())
            .collect()
    });

    let old_param_map: Option<Vec<NonZero<usize>>> = ctx.old_registers.as_ref().map(|old_regs| {
        (1..=old_regs.len())
            .map(|i| NonZero::new(i + num_new).unwrap())
            .collect()
    });
    let subprogram_ctx = TriggerSubprogramContext {
        new_param_map,
        old_param_map,
        table: ctx.table.clone(),
    };
    let mut subprogram_builder = ProgramBuilder::new_for_trigger(
        QueryMode::Normal,
        program.capture_data_changes_mode().clone(),
        ProgramBuilderOpts {
            num_cursors: 1,
            approx_num_insns: 32,
            approx_num_labels: 2,
        },
        trigger.clone(),
    );
    for command in trigger.commands.iter() {
        let stmt = trigger_cmd_to_stmt_for_subprogram(command, &subprogram_ctx)?;
        subprogram_builder.prologue();
        subprogram_builder = translate_inner(
            stmt,
            resolver,
            subprogram_builder,
            connection,
            "trigger subprogram",
        )?;
    }
    subprogram_builder.epilogue(resolver.schema);
    let built_subprogram = subprogram_builder.build(connection.clone(), true, "trigger subprogram");

    let mut param_register_indices = Vec::new();
    if let Some(new_regs) = &ctx.new_registers {
        param_register_indices.extend(new_regs.iter().copied());
    }
    if let Some(old_regs) = &ctx.old_registers {
        param_register_indices.extend(old_regs.iter().copied());
    }

    let params: Vec<crate::types::Value> = param_register_indices
        .iter()
        .map(|&reg_idx| {
            // Use a special encoding: negative integer represents register index
            // This is a hack - ideally we'd modify Program to accept register indices directly
            crate::types::Value::Integer(-(reg_idx as i64 + 1))
        })
        .collect();

    let turso_stmt = Statement::new(
        built_subprogram,
        connection.mv_store().cloned(),
        connection.pager.load().clone(),
        QueryMode::Normal,
    );
    program.emit_insn(Insn::Program {
        params,
        program: Arc::new(RwLock::new(turso_stmt)),
    });
    connection.end_trigger_compilation();

    Ok(true)
}

/// Check if there are any triggers for a given event (regardless of time).
/// This is used during plan preparation to determine if materialization is needed.
pub fn has_relevant_triggers_type_only(
    schema: &crate::schema::Schema,
    event: TriggerEvent,
    updated_column_indices: Option<&HashSet<usize>>,
    table: &BTreeTable,
) -> bool {
    let mut triggers = schema.get_triggers_for_table(table.name.as_str());

    // Filter triggers by event
    triggers.any(|trigger| {
        // Check event matches
        let event_matches = match (&trigger.event, &event) {
            (TriggerEvent::Delete, TriggerEvent::Delete) => true,
            (TriggerEvent::Insert, TriggerEvent::Insert) => true,
            (TriggerEvent::Update, TriggerEvent::Update) => true,
            (TriggerEvent::UpdateOf(trigger_cols), TriggerEvent::Update) => {
                // For UPDATE OF, we need to check if any of the specified columns
                // are in the UPDATE SET clause
                let updated_cols =
                    updated_column_indices.expect("UPDATE should contain some updated columns");
                // Check if any of the trigger's specified columns are being updated
                trigger_cols.iter().any(|col_name| {
                    let normalized_col = normalize_ident(col_name.as_str());
                    if let Some((col_idx, _)) = table.get_column(&normalized_col) {
                        updated_cols.contains(&col_idx)
                    } else {
                        // Column doesn't exist - according to SQLite docs, unrecognized
                        // column names in UPDATE OF are silently ignored
                        false
                    }
                })
            }
            _ => false,
        };

        event_matches
    })
}

/// Check if there are any triggers for a given event (regardless of time).
/// This is used during plan preparation to determine if materialization is needed.
pub fn get_relevant_triggers_type_and_time<'a>(
    schema: &'a crate::schema::Schema,
    event: TriggerEvent,
    time: TriggerTime,
    updated_column_indices: Option<HashSet<usize>>,
    table: &'a BTreeTable,
) -> impl Iterator<Item = Arc<Trigger>> + 'a + Clone {
    let triggers = schema.get_triggers_for_table(table.name.as_str());

    // Filter triggers by event
    triggers
        .filter(move |trigger| -> bool {
            // Check event matches
            let event_matches = match (&trigger.event, &event) {
                (TriggerEvent::Delete, TriggerEvent::Delete) => true,
                (TriggerEvent::Insert, TriggerEvent::Insert) => true,
                (TriggerEvent::Update, TriggerEvent::Update) => true,
                (TriggerEvent::UpdateOf(trigger_cols), TriggerEvent::Update) => {
                    // For UPDATE OF, we need to check if any of the specified columns
                    // are in the UPDATE SET clause
                    if let Some(ref updated_cols) = updated_column_indices {
                        // Check if any of the trigger's specified columns are being updated
                        trigger_cols.iter().any(|col_name| {
                            let normalized_col = normalize_ident(col_name.as_str());
                            if let Some((col_idx, _)) = table.get_column(&normalized_col) {
                                updated_cols.contains(&col_idx)
                            } else {
                                // Column doesn't exist - according to SQLite docs, unrecognized
                                // column names in UPDATE OF are silently ignored
                                false
                            }
                        })
                    } else {
                        false
                    }
                }
                _ => false,
            };

            if !event_matches {
                return false;
            }

            trigger.time == time
        })
        .cloned()
}

#[allow(clippy::too_many_arguments)]
pub fn fire_trigger(
    program: &mut ProgramBuilder,
    resolver: &mut Resolver,
    trigger: Arc<Trigger>,
    ctx: &TriggerContext,
    connection: &Arc<crate::Connection>,
) -> Result<()> {
    // Evaluate WHEN clause if present
    if let Some(mut when_expr) = trigger.when_clause.clone() {
        // Rewrite NEW/OLD references in WHEN clause to use registers
        rewrite_trigger_expr_for_when_clause(&mut when_expr, &ctx.table, ctx)?;

        let when_reg = program.alloc_register();
        translate_expr(program, None, &when_expr, when_reg, resolver)?;

        let skip_label = program.allocate_label();
        program.emit_insn(Insn::IfNot {
            reg: when_reg,
            jump_if_null: true,
            target_pc: skip_label,
        });

        // Execute trigger commands if WHEN clause is true
        execute_trigger_commands(program, resolver, &trigger, ctx, connection)?;

        program.preassign_label_to_next_insn(skip_label);
    } else {
        // No WHEN clause - always execute
        execute_trigger_commands(program, resolver, &trigger, ctx, connection)?;
    }

    Ok(())
}

/// Rewrite NEW/OLD references in WHEN clause expressions (uses Register expressions, not Variable)
fn rewrite_trigger_expr_for_when_clause(
    expr: &mut ast::Expr,
    table: &BTreeTable,
    ctx: &TriggerContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;
    use crate::translate::expr::WalkControl;

    walk_expr_mut(expr, &mut |e: &mut ast::Expr| -> Result<WalkControl> {
        match e {
            Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
                let ns = normalize_ident(ns.as_str());
                let col = normalize_ident(col.as_str());

                // Handle NEW.column references
                if ns.eq_ignore_ascii_case("new") {
                    if let Some(new_regs) = &ctx.new_registers {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < new_regs.len() {
                                *e = Expr::Register(new_regs[idx]);
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle NEW.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Register(
                                *ctx.new_registers
                                    .as_ref()
                                    .expect("NEW registers must be provided")
                                    .last()
                                    .expect("NEW registers must be provided"),
                            );
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in NEW: {}", col);
                    } else {
                        bail_parse_error!(
                            "NEW references are only valid in INSERT and UPDATE triggers"
                        );
                    }
                }

                // Handle OLD.column references
                if ns.eq_ignore_ascii_case("old") {
                    if let Some(old_regs) = &ctx.old_registers {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < old_regs.len() {
                                *e = Expr::Register(old_regs[idx]);
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle OLD.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Register(
                                *ctx.old_registers
                                    .as_ref()
                                    .expect("OLD registers must be provided")
                                    .last()
                                    .expect("OLD registers must be provided"),
                            );
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in OLD: {}", col);
                    } else {
                        bail_parse_error!(
                            "OLD references are only valid in UPDATE and DELETE triggers"
                        );
                    }
                }

                // Handle unqualified column references - they refer to NEW if available, else OLD
                if let Some((idx, _)) = table.get_column(&col) {
                    if let Some(new_regs) = &ctx.new_registers {
                        if idx < new_regs.len() {
                            *e = Expr::Register(new_regs[idx]);
                            return Ok(WalkControl::Continue);
                        }
                    }
                    if let Some(old_regs) = &ctx.old_registers {
                        if idx < old_regs.len() {
                            *e = Expr::Register(old_regs[idx]);
                            return Ok(WalkControl::Continue);
                        }
                    }
                }

                Ok(WalkControl::Continue)
            }
            _ => Ok(WalkControl::Continue),
        }
    })?;
    Ok(())
}