mirror of
https://github.com/aljazceru/turso.git
synced 2025-12-27 21:14:21 +01:00
4ef3c1d04d
insert() fails if key exists (there shouldn't be two) and panics if it's different pages, and also fails if it can't make room for the page. Replaced the limited pop_if_not_dirty() function with make_room_for(). It tries to evict many pages as requested spare capacity. It should come handy later by resize() and Pager. make_room_for() tries to make room or fails if it can't evict enough entries. For make_room_for() I also tried with an all-or-nothing approach, so if say a query requests a lot more than possible to make room for, it doesn't evict a bunch of pages from the cache that might be useful. But implementing this approach got very complicated since it needs to keep exclusive PageRefs and collecting this caused segfaults. Might be worth trying again in the future. But beware the rabbit hole. Updated page cache test logic for new insert rules. Updated Pager.allocate_page() to handle failure logic but needs further work. This is to show new cache insert handling. There are many places to update. Left comments on callers of pager and page cache needing to update error handling, for now.