mirror of
https://github.com/aljazceru/turso.git
synced 2025-12-27 13:04:20 +01:00
beaf393476
First step toward resolving https://github.com/tursodatabase/limbo/issues/1643. ### This PR With this change, the following two queries are considered equivalent: ```sql SELECT value FROM generate_series(5, 50); SELECT value FROM generate_series WHERE start = 5 AND stop = 50; ``` Arguments passed in parentheses to the virtual table name are now matched to hidden columns. Additionally, I fixed two bugs related to virtual tables. ### TODO (I'll handle this in a separate PR) Column references are still not supported as table-valued function arguments. The only difference is that previously, a query like: ```sql SELECT one.value, series.value FROM (SELECT 1 AS value) one, generate_series(one.value, 3) series; ``` would cause a panic. Now, it returns a proper error message instead. Adding support for column references is more nuanced for two main reasons: * We need to ensure that in joins where a TVF depends on other tables, those other tables are processed first. For example, in: ```sql SELECT one.value, series.value FROM generate_series(one.value, 3) series, (SELECT 1 AS value) one; ``` the one table must be processed by the top-level loop, and series must be nested. * For outer joins involving TVFs, the arguments must be treated as `ON` predicates, not `WHERE` predicates. Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com> Closes #1727