pedrocarlo
8501bc930a
use workspace rand version
2025-10-21 14:10:05 -03:00
Pekka Enberg
94c343770d
mvcc: Disable automatic checkpointing by default
...
MVCC checkpointing currently prevents concurrent writes so disable it by
default while we work on it.
2025-10-08 09:14:55 +03:00
Levy A.
cf53ecb7e3
refactor: remove TextRef and RawSlice and fix tests
2025-10-07 10:43:45 -03:00
Levy A.
77a412f6af
refactor: remove unsafe reference semantics from RefValue
...
also renames `RefValue` to `ValueRef`, to align with rusqlite and other
crates
2025-10-07 10:43:44 -03:00
Pere Diaz Bou
44152f11d0
core/mvcc/logical-log: switch RwLock to parking_lot
2025-10-07 11:15:48 +02:00
bit-aloo
66c69461fb
Add getter/setter for checkpoint threshold in LogicalLog
...
Wire threshold access through Storage
Add checkpoint threshold accessors to MvStore
2025-10-07 10:17:04 +05:30
Pere Diaz Bou
a30c95d988
core/mvcc/logical-log: add threshold for checkpoints in logical log
2025-10-03 22:24:33 +02:00
pedrocarlo
131a5b8048
adjust logical log IO functions to return Completions and not IOResult
2025-10-03 01:44:41 -03:00
Jussi Saurio
9e4ea6ea34
Merge 'core/mvcc/logical-log: fail in read_more_data if couldn't read enough' from Pere Diaz Bou
...
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3500
2025-10-02 06:58:28 +03:00
Jussi Saurio
bb4e54ca73
Merge 'fix/mvcc: deserialize table_id as i64' from Jussi Saurio
...
Reviewed-by: Nikita Sivukhin (@sivukhin)
Closes #3492
2025-10-02 06:58:01 +03:00
Pere Diaz Bou
b89df44339
fmt
2025-10-01 14:31:30 +02:00
Pere Diaz Bou
dc0245d758
core/mvcc/logical-log: fail in read_more_data if couldn't read enough
2025-10-01 14:25:22 +02:00
Jussi Saurio
e9f0c59bcc
fix/mvcc: set log offset to end of file after recovery finishes
...
otherwise we start overwriting existing log entries
2025-10-01 12:46:24 +03:00
Jussi Saurio
bcb941f33b
fix/mvcc: deserialize table_id as i64
2025-10-01 10:26:23 +03:00
Jussi Saurio
d4d50b564a
fix even more tests
2025-09-30 23:22:07 +03:00
Jussi Saurio
fe871188bf
fix tests again
2025-09-30 22:54:48 +03:00
Jussi Saurio
fd84fd0683
fix test compilation errors
2025-09-30 22:27:28 +03:00
Jussi Saurio
7c897d382f
Implement MvTableId newtype for better type safety of table ids
2025-09-30 16:54:22 +03:00
Jussi Saurio
a52dbb7842
Handle table ID / rootpages properly for both checkpointed and non-checkpointed tables
...
Table ID is an opaque identifier that is only meaningful to the MV store.
Each checkpointed MVCC table corresponds to a single B-tree on the pager,
which naturally has a root page.
We cannot use root page as the MVCC table ID directly because:
- We assign table IDs during MVCC commit, but
- we commit pages to the pager only during checkpoint
which means the root page is not easily knowable ahead of time.
Hence, we:
- store the mapping between table id and btree rootpage
- sqlite_schema rows will have a negative rootpage column if the
table has not been checkpointed yet.
2025-09-30 16:53:12 +03:00
Pere Diaz Bou
0f631101df
core: change page idx type from usize to i64
...
MVCC is like the annoying younger cousin (I know because I was him) that
needs to be treated differently. MVCC requires us to use root_pages that
might not be allocated yet, and the plan is to use negative root_pages
for that case. Therefore, we need i64 in order to fit this change.
2025-09-29 18:38:43 +02:00
Pekka Enberg
65b382b9e1
Merge 'Make MVCC code Send and Sync' from Pekka Enberg
...
Closes #3361
2025-09-27 08:21:01 +03:00
Pere Diaz Bou
99adf73168
core/mvcc/logical-log: rename to needs_recovery
2025-09-26 16:59:57 +02:00
Pere Diaz Bou
9e47cc3700
clippy
2025-09-26 14:16:11 +02:00
Pekka Enberg
1402e9841e
core/mvcc: Wrap StreamingLogicalLogReader::buffer with RwLock
2025-09-26 14:19:16 +03:00
Pekka Enberg
96accef06c
core/mvcc: Wrap header with RwLock
2025-09-26 14:10:18 +03:00
Pere Diaz Bou
4cdf293a2b
core/mvcc/logical-log: fuzz test recover use db.restart
2025-09-26 12:56:58 +02:00
Pere Diaz Bou
83d8a7c775
core/mvcc/logical-log: lock recover logical log process
2025-09-26 12:47:31 +02:00
Pere Diaz Bou
334da8abbb
core/mvcc/logical-log: refactor get log path in tests
2025-09-25 18:33:26 +02:00
Jussi Saurio
c07a227560
Merge 'core/mvcc/logical-log: load logical log from disk' from Pere Diaz Bou
...
## Description
Read transactions from logical log and load mvcc store based on the
contents onto transaction 0, which is the special transaction where we
will load all row versions that can be read by all new transactions.
## Todo
- [x] Testing for multiple transactions
- [ ] Lock multiple loading of same logical-log at the same time
- [x] Add column_count to format because if not it is hard to judge from
record alone.
- [x] Trim buffer read
I was thinking to implement the rest on another pr to not increase load
to review this one.
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3323
2025-09-25 16:26:34 +03:00
Pere Diaz Bou
8f3332377a
core/mvcc/logical-log: fmt fmt fmt fmt
2025-09-25 13:33:16 +02:00
Pere Diaz Bou
b75eb9f09d
core/mvcc/logical-log: drain consumed bytes on read_more_data
2025-09-25 13:31:03 +02:00
Pere Diaz Bou
7b131b0b0d
core/mvcc/logical-log: test fuzz logical log read
2025-09-25 13:23:43 +02:00
Pere Diaz Bou
dd0a71484d
core/mvcc/logical-log: test insert 100 transactions
2025-09-25 12:40:05 +02:00
Pere Diaz Bou
8528f92248
core/mvcc/logical-log: fix is_eof
2025-09-25 12:39:48 +02:00
Pere Diaz Bou
654f9a9412
core/mvcc/logical-log: read column_count from immutable record
2025-09-25 12:27:30 +02:00
Jussi Saurio
b702af8ac0
mvcc: add truncate method to logical log
2025-09-25 08:12:13 +03:00
Pere Diaz Bou
1478538cb9
core/mvcc/logical-log: load logical log from disk
...
Read transactions from logical log and load mvcc store based on the
contents onto transaction 0, which is the special transaction where we
will load all row versions that can be read by all new transactions.
- [ ] Testing for multiple transactions
- [ ] Lock multiple loading of same logical-log at the same time
- [ ] Add column_count to format because if not it is hard to judge from
record alone.
2025-09-25 02:15:28 +02:00
Pere Diaz Bou
2f4426fc33
core/mvcc/logical-log: change order of Data size in InsertRow
2025-09-22 13:25:46 +02:00
Pere Diaz Bou
4cc88ee2bb
core/mvcc/logical-log: rename Insert and Delete -> InsertRow and DeleteRow in LogRecordType
2025-09-22 13:21:54 +02:00
Pere Diaz Bou
db326affc6
core/mvcc/logical-log: rename LogRowType to LogRecordType
2025-09-22 13:19:02 +02:00
Pere Diaz Bou
e22a3893d5
core/mvcc/logical-log: remove column_count from insert row type
2025-09-22 13:18:17 +02:00
Pere Diaz Bou
4c959e760b
core/mvcc/logical-log: add rows size field for transaction format
2025-09-22 13:15:07 +02:00
Pere Diaz Bou
2cd1562966
core/mvcc/logical-log: add format for transaction fields and marker end
2025-09-22 13:06:11 +02:00
Pere Diaz Bou
6fc1bed187
core/mvcc/logical-log: add format for logical log header
2025-09-22 13:00:52 +02:00
Pere Diaz Bou
36a728d984
core/mvcc/logical-log: add format for row types
2025-09-22 12:43:54 +02:00
Pekka Enberg
2307cf03be
Merge 'core/mvcc: Wrap LogicalLog in RwLock' from Pekka Enberg
...
Closes #3215
2025-09-19 13:40:40 +03:00
Jussi Saurio
ba7ae50eff
mvcc: remove unused code related to is_logical_log()
...
is always logical log
2025-09-19 12:55:27 +03:00
Pekka Enberg
c77f523bfe
core/mvcc: Wrap LogicalLog in RwLock
2025-09-19 09:02:58 +03:00
Pekka Enberg
3f35267b7c
core/mvcc: Kill noop storage
...
We don't need it for anything.
2025-09-19 08:52:57 +03:00
Pere Diaz Bou
402f171ce4
fix compilation error on logical_log
2025-09-18 19:20:37 +02:00
