Nikita Sivukhin
00114d9674
remove quotes handling from normalization util
2025-09-29 11:00:19 +04:00
Nikita Sivukhin
86a95e813d
Merge branch 'main' into quoting-fix-attempt-2
2025-09-29 10:58:51 +04:00
Pekka Enberg
d3abeb6281
core/storage: Wrap WalFile::{max,min}_frame with AtomicU64
2025-09-28 16:47:54 +03:00
Pekka Enberg
aba596441c
core/storage: Wrap WalFile::max_frame_read_lock_index with AtomicUsize
2025-09-28 13:42:32 +03:00
Jussi Saurio
959165eed1
Merge 'core/storage: Mark Page as Send and Sync' from Pekka Enberg
...
Closes #3399
2025-09-28 08:08:46 +03:00
Jussi Saurio
618cf2a4e7
Merge 'core/translate: rewrite default column value from identifier to string literal' from Preston Thorpe
...
closes #3390
closes #3389
Closes #3403
2025-09-28 08:07:11 +03:00
PThorpe92
03046faccb
Translate default value Expr::Id to Literal to allow for identifier in col def
2025-09-27 13:56:04 -04:00
PThorpe92
b7fc9fef40
Persist NOT NULL column constraint to schema table
2025-09-27 13:12:19 -04:00
Pekka Enberg
3d3e39a958
Merge 'Make Sorter Send and Sync' from Pekka Enberg
...
Closes #3398
2025-09-27 16:51:27 +03:00
Pekka Enberg
d7a0a3db56
Merge 'core/translate: allow creating column called 'rowid'' from Preston Thorpe
...
closes #3282
includes minor refactor, removing `column_is_rowid_alias`, which is only
checking the public field of the argument Column.
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3385
2025-09-27 16:51:09 +03:00
Pekka Enberg
5ff0044961
Merge 'length shall not count when it sees nullc' from Pavan Nambi
...
fixes #3317
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3356
2025-09-27 16:50:50 +03:00
Pekka Enberg
e34a935e0a
Merge 'resolve column alias after rewritting column access in the expression in returning insert clause' from Nikita Sivukhin
...
Fixes https://github.com/tursodatabase/turso/issues/3295
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3355
2025-09-27 16:50:42 +03:00
Pekka Enberg
2a8a0729c7
Merge 'core/storage: Wrap WalFile::syncing with AtomicBool' from Pekka Enberg
...
Closes #3397
2025-09-27 15:18:32 +03:00
Pekka Enberg
ce76aa11b2
core/storage: Mark Page as Send and Sync
2025-09-27 15:16:38 +03:00
Pekka Enberg
7b6fc0f3b6
core/vdbe: Wrap SortedChunk::total_bytes_read with AtomicUsize
2025-09-27 14:35:31 +03:00
Pekka Enberg
61b3f56997
core/vdbe: Wrap SortedChunk::io_state with RwLock
2025-09-27 14:28:55 +03:00
Pekka Enberg
5f39987ec0
core/vdbe: Wrap SortedChunk::buffer_len with AtomicUsize
2025-09-27 14:23:02 +03:00
Pekka Enberg
b31818f77c
core/vdbe: Wrap SortedChunk::buffer with RwLock
2025-09-27 14:23:02 +03:00
Pekka Enberg
8d9d2dad1d
core/storage: Wrap WalFile::syncing with AtomicBool
2025-09-27 14:07:26 +03:00
Glauber Costa
3ee97ddf36
Make sure complex expressions in filters go through Project
...
We had code for this, but the code had a fatal flaw: it tried to detect
a complex operation (an operation that needs projection), and return
false (no need for projection), for the others.
This is the exact opposite of what we should do: we should identify the
*simple* operations, and then return true (needs projection) for the
rest.
CAST is a special beast, since it is not a function, but rather, a
special opcode. Everything else above is the true just the same. But for
CAST, we have to do the extra work to capture it in the logical plan and
pass it down.
Fixes #3372
Fixes #3370
Fixes #3369
2025-09-27 07:21:03 -03:00
Jussi Saurio
283fba2e0d
use normalized table name
2025-09-27 09:53:11 +03:00
Jussi Saurio
67d320960d
ALTER TABLE: prevent dropping/renaming column referenced in VIEW
2025-09-27 09:45:15 +03:00
Jussi Saurio
3137357092
ALTER TABLE: prevent dropping indexed column in VDBE layer
2025-09-27 09:45:15 +03:00
Jussi Saurio
085b92dc4e
ALTER TABLE: prevent dropping indexed columns in translate layer
2025-09-27 09:45:15 +03:00
Jussi Saurio
a2d833c073
ALTER TABLE: add comment about things preventing drop column
2025-09-27 09:45:15 +03:00
Pekka Enberg
d796964a1e
Merge 'support mixed integer and float expressions in the expr_compiler' from Glauber Costa
...
Fixes #3373
Closes #3387
2025-09-27 08:22:14 +03:00
Pekka Enberg
65b382b9e1
Merge 'Make MVCC code Send and Sync' from Pekka Enberg
...
Closes #3361
2025-09-27 08:21:01 +03:00
Pekka Enberg
92291ed736
Merge 'Fix offset variable handling' from Nikita Sivukhin
...
Before, db generated incorrect plan in case when offset parameter were
introduced as variable:
```
turso> EXPLAIN SELECT * FROM users LIMIT ? OFFSET ?;
addr opcode p1 p2 p3 p4 p5 comment
---- ----------------- ---- ---- ---- ------------- -- -------
0 Init 0 16 0 0 Start at 16
1 Variable 1 1 0 0 r[1]=parameter(1); OFFSET expr
2 MustBeInt 1 0 0 0
3 Variable 2 2 0 0 r[2]=parameter(2); OFFSET expr
4 MustBeInt 2 0 0 0
5 OffsetLimit 1 3 2 0 if r[1]>0 then r[3]=r[1]+max(0,r[2]) else r[3]=(-1)
6 OpenRead 0 2 0 0 table=users, root=2, iDb=0
7 Rewind 0 15 0 0 Rewind table users
8 Variable 2 2 0 0 r[2]=parameter(2); OFFSET expr
9 MustBeInt 2 0 0 0
10 IfPos 2 14 1 0 r[2]>0 -> r[2]-=1, goto 14
11 Column 0 0 4 0 r[4]=users.x
12 ResultRow 4 1 0 0 output=r[4]
13 DecrJumpZero 1 15 0 0 if (--r[1]==0) goto 15
14 Next 0 8 0 0
15 Halt 0 0 0 0
16 Transaction 0 1 1 0 iDb=0 tx_mode=Read
17 Goto 0 1 0 0
```
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3360
2025-09-27 08:20:54 +03:00
Pekka Enberg
a932ac5450
Merge 'core: recover logical log on Database::connect ' from Pere Diaz Bou
...
If we open database and logical log is not empty we need to recover from
it. We also make sure a single recover executes concurrently and other
connections just wait for it to finish.
I also changed the fuzz tester to use `restart` instead of calling
`load_logical_log` manually to test this behaviour.
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3359
2025-09-27 08:20:41 +03:00
Glauber Costa
d28022b491
support mixed integer and float expressions in the expr_compiler
...
Fixes #3373
2025-09-26 21:11:38 -03:00
Preston Thorpe
5dc30b5a68
Merge 'core/storage: Display page category for rowid integrity check failure' from Pekka Enberg
...
Let's add more hints to hunt down the reason for #2896 .
Reviewed-by: Preston Thorpe <preston@turso.tech >
Closes #3378
2025-09-26 19:07:45 -04:00
PThorpe92
5d8a735aaf
fix clippy error
2025-09-26 18:06:09 -04:00
PThorpe92
d4dc458328
Evaluate table column refs before checking rowid to allow using it as col name
2025-09-26 17:33:38 -04:00
PThorpe92
e52aa1538e
Remove unused BTreeTable method for checking single field on Column in schema
2025-09-26 17:32:51 -04:00
PThorpe92
af215c2906
Check cols first before falling back to explicit rowid in UPDATE translation
2025-09-26 17:32:16 -04:00
Preston Thorpe
e43184fb98
Merge 'translate: refactor arguments and centralize parameter context' from Preston Thorpe
...
This PR contains _no semantic changes_.
I made this cleanup on another branch when I was working on subqueries,
as the inconsistency with passing around `Schema` and `SymbolTable` had
been kinda bothering me. By adding `param_ctx` to the program, it
prevents accidentally resetting it to zero.
Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com >
Closes #3382
2025-09-26 13:05:29 -04:00
PThorpe92
d9658070a9
Fix clippy warnings
2025-09-26 12:17:34 -04:00
PThorpe92
5fcc187434
translate: refactor arguments and centralize parameter context
2025-09-26 12:06:44 -04:00
Pekka Enberg
931cf2658e
core/storage: Display page category for rowid integrity check failure
...
Let's add more hints to hunt down the reason for #2896 .
2025-09-26 18:25:49 +03:00
Pere Diaz Bou
99adf73168
core/mvcc/logical-log: rename to needs_recovery
2025-09-26 16:59:57 +02:00
Nikita Sivukhin
f80650586a
remove misleading comment
2025-09-26 18:06:20 +04:00
Nikita Sivukhin
63a9fa8c28
fix handling of offset parameter set through variable
...
- before the fix db generated following plan:
turso> EXPLAIN SELECT * FROM users LIMIT ? OFFSET ?;
addr opcode p1 p2 p3 p4 p5 comment
---- ----------------- ---- ---- ---- ------------- -- -------
0 Init 0 16 0 0 Start at 16
1 Variable 1 1 0 0 r[1]=parameter(1); OFFSET expr
2 MustBeInt 1 0 0 0
3 Variable 2 2 0 0 r[2]=parameter(2); OFFSET expr
4 MustBeInt 2 0 0 0
5 OffsetLimit 1 3 2 0 if r[1]>0 then r[3]=r[1]+max(0,r[2]) else r[3]=(-1)
6 OpenRead 0 2 0 0 table=users, root=2, iDb=0
7 Rewind 0 15 0 0 Rewind table users
8 Variable 2 2 0 0 r[2]=parameter(2); OFFSET expr
9 MustBeInt 2 0 0 0
10 IfPos 2 14 1 0 r[2]>0 -> r[2]-=1, goto 14
11 Column 0 0 4 0 r[4]=users.x
12 ResultRow 4 1 0 0 output=r[4]
13 DecrJumpZero 1 15 0 0 if (--r[1]==0) goto 15
14 Next 0 8 0 0
15 Halt 0 0 0 0
16 Transaction 0 1 1 0 iDb=0 tx_mode=Read
17 Goto 0 1 0 0
- the problem here is that Variable value is re-read at step 8 - which is wrong
2025-09-26 18:05:36 +04:00
Nikita Sivukhin
5b5379d078
propagate context to stringifier to properly derive column names
2025-09-26 17:40:41 +04:00
Nikita Sivukhin
52f3216211
fix avg aggregation
...
- ignore NULL rows as SQLite do
- emit NULL instead of NaN when no rows were aggregated
- adjust agg column alias name
2025-09-26 17:11:06 +04:00
Pere Diaz Bou
9e47cc3700
clippy
2025-09-26 14:16:11 +02:00
Pekka Enberg
1402e9841e
core/mvcc: Wrap StreamingLogicalLogReader::buffer with RwLock
2025-09-26 14:19:16 +03:00
Pekka Enberg
96accef06c
core/mvcc: Wrap header with RwLock
2025-09-26 14:10:18 +03:00
Pere Diaz Bou
59d3e37b9f
fmt
2025-09-26 13:01:13 +02:00
Pere Diaz Bou
9c1d94a355
core/mvcc/logical-log: assert we don't call begin_load_tx twice
2025-09-26 12:59:13 +02:00
Pere Diaz Bou
4cdf293a2b
core/mvcc/logical-log: fuzz test recover use db.restart
2025-09-26 12:56:58 +02:00