From f6b7a3fba40a74fb34e20bddb65976e2bc1c6d55 Mon Sep 17 00:00:00 2001
From: rjhallsted <rjhallsted@gmail.com>
Date: Mon, 16 Sep 2024 16:31:37 -0700
Subject: [PATCH] Remove duplication of glob and like translation

---
 core/translate/expr.rs | 38 ++------------------------------------
 1 file changed, 2 insertions(+), 36 deletions(-)

diff --git a/core/translate/expr.rs b/core/translate/expr.rs
index 24a48dc5e..d63bfb46b 100644
--- a/core/translate/expr.rs
+++ b/core/translate/expr.rs
@@ -1,5 +1,5 @@
 use crate::{function::JsonFunc, Result};
-use sqlite3_parser::ast::{self, LikeOperator, UnaryOperator};
+use sqlite3_parser::ast::{self, UnaryOperator};
 use std::rc::Rc;
 
 use super::optimizer::CachedResult;
@@ -906,40 +906,6 @@ pub fn translate_expr(
                             });
                             Ok(target_register)
                         }
-                        ScalarFunc::Glob => {
-                            let args = match args {
-                                Some(args) if args.len() == 2 => args,
-                                Some(_) | None => crate::bail_parse_error!(
-                                    "{} function requires exactly 2 arguments",
-                                    srf.to_string()
-                                ),
-                            };
-                            let mut constant_mask = 0;
-                            for (idx, arg) in args.iter().enumerate() {
-                                let reg = program.alloc_register();
-                                let _ = translate_expr(
-                                    program,
-                                    referenced_tables,
-                                    arg,
-                                    reg,
-                                    cursor_hint,
-                                    cached_results,
-                                )?;
-                                if let ast::Expr::Literal(_) = arg {
-                                    program.mark_last_insn_constant();
-                                    if idx == 0 {
-                                        constant_mask = 1;
-                                    }
-                                }
-                            }
-                            program.emit_insn(Insn::Function {
-                                constant_mask,
-                                start_reg: target_register + 1,
-                                dest: target_register,
-                                func: func_ctx,
-                            });
-                            Ok(target_register)
-                        }
                         ScalarFunc::IfNull => {
                             let args = match args {
                                 Some(args) if args.len() == 2 => args,
@@ -983,7 +949,7 @@ pub fn translate_expr(
 
                             Ok(target_register)
                         }
-                        ScalarFunc::Like => {
+                        ScalarFunc::Glob | ScalarFunc::Like => {
                             let args = if let Some(args) = args {
                                 if args.len() < 2 {
                                     crate::bail_parse_error!(