From f1475bd5acdc0bcc8e13058b9188cc2ced2d907b Mon Sep 17 00:00:00 2001 From: PThorpe92 Date: Wed, 13 Aug 2025 10:17:33 -0400 Subject: [PATCH] Remove bool return value from page set_locked --- core/storage/pager.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/storage/pager.rs b/core/storage/pager.rs index e72caeb61..7bd24b53c 100644 --- a/core/storage/pager.rs +++ b/core/storage/pager.rs @@ -159,9 +159,8 @@ impl Page { self.get().flags.load(Ordering::Acquire) & PAGE_LOCKED != 0 } - pub fn set_locked(&self) -> bool { - let prev = self.get().flags.fetch_or(PAGE_LOCKED, Ordering::Acquire); - prev & PAGE_LOCKED == 0 + pub fn set_locked(&self) { + self.get().flags.fetch_or(PAGE_LOCKED, Ordering::Acquire); } pub fn clear_locked(&self) { @@ -1011,13 +1010,13 @@ impl Pager { ) -> Result<(PageRef, Completion)> { tracing::trace!("read_page_no_cache(page_idx = {})", page_idx); let page = Arc::new(Page::new(page_idx)); - page.set_locked(); let Some(wal) = self.wal.as_ref() else { turso_assert!( matches!(frame_watermark, Some(0) | None), "frame_watermark must be either None or Some(0) because DB has no WAL and read with other watermark is invalid" ); + page.set_locked(); let c = self.begin_read_disk_page(page_idx, page.clone(), allow_empty_read)?; return Ok((page, c)); };