clippy

core/pseudo.rs

@@ -10,14 +10,16 @@ pub struct PseudoCursor {
     current: RefCell<Option<ImmutableRecord>>,
 }
 
-impl PseudoCursor {
+impl Default for PseudoCursor {
-    pub fn new() -> Self {
+    fn default() -> Self {
         Self {
             record_cursor: RecordCursor::new(),
             current: RefCell::new(None),
         }
     }
+}
 
+impl PseudoCursor {
     pub fn record(&self) -> Ref<Option<ImmutableRecord>> {
         self.current.borrow()
     }

core/vdbe/execute.rs

@@ -1389,7 +1389,7 @@ pub fn op_open_pseudo(
     );
     {
         let cursors = &mut state.cursors;
-        let cursor = PseudoCursor::new();
+        let cursor = PseudoCursor::default();
         cursors
             .get_mut(*cursor_id)
             .unwrap()

core/vdbe/sorter.rs

@@ -280,9 +280,8 @@ impl Sorter {
                 // TODO: blocking will be unnecessary here with IO completions
                 let mut completions = vec![];
                 for chunk_idx in 0..self.chunks.len() {
-                    match self.push_to_chunk_heap(chunk_idx)? {
+                    if let Some(c) = self.push_to_chunk_heap(chunk_idx)? {
-                        Some(c) => completions.push(c),
+                        completions.push(c);
-                        None => (),
                     };
                 }
                 self.init_chunk_heap_state = InitChunkHeapState::Start;