From ea98d8086f9e88ee3dce705df3086694bd67f201 Mon Sep 17 00:00:00 2001 From: Jussi Saurio Date: Tue, 21 Oct 2025 15:03:02 +0300 Subject: [PATCH] Change default ON CONFLICT mode back to ABORT now that we support it --- core/translate/insert.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/translate/insert.rs b/core/translate/insert.rs index 64bd29ed6..2facd8520 100644 --- a/core/translate/insert.rs +++ b/core/translate/insert.rs @@ -232,7 +232,7 @@ pub fn translate_insert( &table, &mut body, connection, - on_conflict.unwrap_or(ResolveType::Rollback), + on_conflict.unwrap_or(ResolveType::Abort), )?; if inserting_multiple_rows && btree_table.has_autoincrement { @@ -976,9 +976,8 @@ fn bind_insert( next: None, })); } - ResolveType::Rollback => { - // This is the current default behavior for INSERT in tursodb - the transaction will be rolled back if the insert fails. - // In SQLite, the default is ABORT and we should use that one once we support subtransactions. + ResolveType::Abort => { + // This is the default conflict resolution strategy for INSERT in SQLite. } _ => { crate::bail_parse_error!(