aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-30 14:34:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix avg(), total(), count() default value on empty set

Browse Source
This commit is contained in:
Bennett Clement
2024-07-12 00:20:44 +08:00
parent 79ba53f190
commit e377e09498
1 changed files with 29 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
core/vdbe.rs
View File

@@ -594,23 +594,38 @@ impl Program {
state.pc += 1; state.pc += 1;
} }
Insn::AggFinal { register, func } => { Insn::AggFinal { register, func } => {
match func { match state.registers[*register].borrow_mut() {
AggFunc::Avg => { OwnedValue::Agg(agg) => {
let OwnedValue::Agg(agg) = state.registers[*register].borrow_mut() match func {
else { AggFunc::Avg => {
unreachable!(); let AggContext::Avg(acc, count) = agg.borrow_mut() else {
unreachable!();
};
*acc /= count.clone();
}
AggFunc::Sum | AggFunc::Total => {}
AggFunc::Count => {}
AggFunc::Max => {}
AggFunc::Min => {}
_ => {
todo!();
}
}; };
let AggContext::Avg(acc, count) = agg.borrow_mut() else {
unreachable!();
};
*acc /= count.clone();
} }
AggFunc::Sum | AggFunc::Total => {} OwnedValue::Null => {
AggFunc::Count => {} // when the set is empty
AggFunc::Max => {} match func {
AggFunc::Min => {} AggFunc::Total => {
state.registers[*register] = OwnedValue::Float(0.0);
}
AggFunc::Count => {
state.registers[*register] = OwnedValue::Integer(0);
}
_ => {}
}
}
_ => { _ => {
todo!(); unreachable!();
} }
}; };
state.pc += 1; state.pc += 1;