From cb1c538a031834a375589dc47de58ed0956afd32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=A0=EC=9A=B0?= Date: Mon, 5 May 2025 14:51:52 +0900 Subject: [PATCH] Remove @Disalbed annotation for basic UPDATE and DELETE --- .../java/tech/turso/jdbc4/JDBC4StatementTest.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/bindings/java/src/test/java/tech/turso/jdbc4/JDBC4StatementTest.java b/bindings/java/src/test/java/tech/turso/jdbc4/JDBC4StatementTest.java index 52895442e..12deedb5c 100644 --- a/bindings/java/src/test/java/tech/turso/jdbc4/JDBC4StatementTest.java +++ b/bindings/java/src/test/java/tech/turso/jdbc4/JDBC4StatementTest.java @@ -1,7 +1,10 @@ package tech.turso.jdbc4; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.sql.ResultSet; import java.sql.SQLException; @@ -40,7 +43,6 @@ class JDBC4StatementTest { } @Test - @Disabled("UPDATE not supported yet") void execute_update_should_return_false() throws Exception { stmt.execute("CREATE TABLE users (id INT PRIMARY KEY, username TEXT);"); stmt.execute("INSERT INTO users VALUES (1, 'limbo');"); @@ -81,16 +83,15 @@ class JDBC4StatementTest { } @Test - @Disabled("Limbo update not yet supported") + @Disabled("Refer to sqlite-jdbc implementation and fix this test") void execute_update_should_return_number_of_updated_elements() throws Exception { - assertThat(stmt.executeUpdate("CREATE TABLE s1 (c1);")).isEqualTo(0); + assertThat(stmt.executeUpdate("CREATE TABLE s1 (c1 INT);")).isEqualTo(0); assertThat(stmt.executeUpdate("INSERT INTO s1 VALUES (1), (2), (3);")).isEqualTo(3); assertThat(stmt.executeUpdate("UPDATE s1 SET c1 = 0;")).isEqualTo(3); } @Test - @Disabled("Limbo delete has a bug") void execute_update_should_return_number_of_deleted_elements() throws Exception { assertThat(stmt.executeUpdate("CREATE TABLE s1 (c1);")).isEqualTo(0); assertThat(stmt.executeUpdate("INSERT INTO s1 VALUES (1), (2), (3);")).isEqualTo(3);