From c4e2a344ae2462008b20900ab002d2b719b0a871 Mon Sep 17 00:00:00 2001
From: jussisaurio <jussi.saurio@gmail.com>
Date: Sat, 21 Dec 2024 23:44:41 +0200
Subject: [PATCH] parse error instead of assert! for unsupported features

---
 core/translate/insert.rs | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/core/translate/insert.rs b/core/translate/insert.rs
index bd9caae4c..12c9ed016 100644
--- a/core/translate/insert.rs
+++ b/core/translate/insert.rs
@@ -169,7 +169,7 @@ fn populate_column_registers(
 pub fn translate_insert(
     schema: &Schema,
     with: &Option<With>,
-    or_conflict: &Option<ResolveType>,
+    on_conflict: &Option<ResolveType>,
     tbl_name: &QualifiedName,
     columns: &Option<DistinctNames>,
     body: &InsertBody,
@@ -177,8 +177,12 @@ pub fn translate_insert(
     database_header: Rc<RefCell<DatabaseHeader>>,
     connection: Weak<Connection>,
 ) -> Result<Program> {
-    assert!(with.is_none());
-    assert!(or_conflict.is_none());
+    if with.is_some() {
+        crate::bail_parse_error!("WITH clause is not supported");
+    }
+    if on_conflict.is_some() {
+        crate::bail_parse_error!("ON CONFLICT clause is not supported");
+    }
     let mut program = ProgramBuilder::new();
     let init_label = program.allocate_label();
     program.emit_insn_with_label_dependency(