From c18418bed00dc79fbbf33d66db20dc9fc97a68c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=A0=EC=9A=B0?= Date: Mon, 27 Jan 2025 20:35:11 +0900 Subject: [PATCH] Nit --- bindings/java/rs_src/limbo_statement.rs | 1 - .../java/org/github/tursodatabase/core/LimboResultSet.java | 4 +++- .../org/github/tursodatabase/jdbc4/JDBC4ResultSetTest.java | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bindings/java/rs_src/limbo_statement.rs b/bindings/java/rs_src/limbo_statement.rs index f8a9706e2..4e39e411a 100644 --- a/bindings/java/rs_src/limbo_statement.rs +++ b/bindings/java/rs_src/limbo_statement.rs @@ -29,7 +29,6 @@ impl LimboStatement { Box::into_raw(Box::new(self)) as jlong } - #[allow(dead_code)] pub fn drop(ptr: jlong) { let _boxed = unsafe { Box::from_raw(ptr as *mut LimboStatement) }; } diff --git a/bindings/java/src/main/java/org/github/tursodatabase/core/LimboResultSet.java b/bindings/java/src/main/java/org/github/tursodatabase/core/LimboResultSet.java index 598ef22c4..ec6e63a26 100644 --- a/bindings/java/src/main/java/org/github/tursodatabase/core/LimboResultSet.java +++ b/bindings/java/src/main/java/org/github/tursodatabase/core/LimboResultSet.java @@ -1,5 +1,6 @@ package org.github.tursodatabase.core; +import java.sql.ResultSet; import java.sql.SQLException; import org.github.tursodatabase.annotations.Nullable; import org.slf4j.Logger; @@ -40,7 +41,8 @@ public class LimboResultSet { } /** - * Consumes all the rows in this result set until the {@link #next()} method returns `false`. + * Consumes all the rows in this {@link ResultSet} until the {@link #next()} method returns + * `false`. * * @throws SQLException if the result set is not open or if an error occurs while iterating. */ diff --git a/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ResultSetTest.java b/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ResultSetTest.java index 7d62a245b..905b6f0f3 100644 --- a/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ResultSetTest.java +++ b/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ResultSetTest.java @@ -61,7 +61,7 @@ class JDBC4ResultSetTest { } @Test - void resultSet_close_test() throws Exception { + void close_resultSet_test() throws Exception { stmt.executeUpdate("CREATE TABLE users (id INT PRIMARY KEY, username TEXT);"); stmt.executeUpdate("INSERT INTO users VALUES (2, 'seonwoo');"); stmt.executeQuery("SELECT * FROM users");