From ba9bab983ebac61c692efb77baf9634ba0c245e0 Mon Sep 17 00:00:00 2001 From: Henrik Ingo Date: Fri, 16 May 2025 01:36:37 +0300 Subject: [PATCH] =?UTF-8?q?Change=20Nyrki=C3=B6=20parameters=20to=20p=3D0.?= =?UTF-8?q?0001=20and=20min=3D0%?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is my recommendation based on fiddling with your data. Seems to roughly halve the number of change points. --- .github/workflows/rust_perf.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust_perf.yml b/.github/workflows/rust_perf.yml index 11ea9c9da..fe8a3e98e 100644 --- a/.github/workflows/rust_perf.yml +++ b/.github/workflows/rust_perf.yml @@ -49,9 +49,9 @@ jobs: # parameters of the algorithm. Note: These are global, so we only set them once and for all. # Smaller p-value = less change points found. Larger p-value = more, but also more false positives. - nyrkio-settings-pvalue: 0.01 + nyrkio-settings-pvalue: 0.0001 # Ignore changes smaller than this. - nyrkio-settings-threshold: 2% + nyrkio-settings-threshold: 0% clickbench: runs-on: ubuntu-latest