From b3883d03d6b16b19fa7c1d03677957e48dab6657 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=A0=EC=9A=B0?= Date: Tue, 14 Jan 2025 20:14:32 +0900 Subject: [PATCH] Apply necessary changes for java 8 --- bindings/java/build.gradle.kts | 2 +- .../main/java/org/github/tursodatabase/LimboConnection.java | 2 +- .../java/org/github/tursodatabase/jdbc4/JDBC4Connection.java | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bindings/java/build.gradle.kts b/bindings/java/build.gradle.kts index 48abcba05..fcdebad3a 100644 --- a/bindings/java/build.gradle.kts +++ b/bindings/java/build.gradle.kts @@ -21,7 +21,7 @@ repositories { dependencies { errorprone("com.uber.nullaway:nullaway:0.10.26") // maximum version which supports java 8 - errorprone("com.google.errorprone:error_prone_core:2.11.0") + errorprone("com.google.errorprone:error_prone_core:2.10.0") // maximum version which supports java 8 testImplementation(platform("org.junit:junit-bom:5.10.0")) testImplementation("org.junit.jupiter:junit-jupiter") diff --git a/bindings/java/src/main/java/org/github/tursodatabase/LimboConnection.java b/bindings/java/src/main/java/org/github/tursodatabase/LimboConnection.java index 5bb5e973f..98f0ad04b 100644 --- a/bindings/java/src/main/java/org/github/tursodatabase/LimboConnection.java +++ b/bindings/java/src/main/java/org/github/tursodatabase/LimboConnection.java @@ -46,7 +46,7 @@ public abstract class LimboConnection implements Connection { } private static AbstractDB open(String url, String fileName, Properties properties) throws SQLException { - if (fileName.isBlank()) { + if (fileName.isEmpty()) { throw new IllegalArgumentException("fileName should not be empty"); } diff --git a/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java b/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java index 6ffb41e3e..9e67ae501 100644 --- a/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java +++ b/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java @@ -4,6 +4,7 @@ import org.github.tursodatabase.LimboConnection; import org.github.tursodatabase.annotations.SkipNullableCheck; import java.sql.*; +import java.util.HashMap; import java.util.Map; import java.util.Properties; import java.util.concurrent.Executor; @@ -150,7 +151,7 @@ public class JDBC4Connection extends LimboConnection { @Override public Map> getTypeMap() throws SQLException { // TODO - return Map.of(); + return new HashMap<>(); } @Override