From b356a84d6992a2dda44b2724f1d0bb5babc33bdc Mon Sep 17 00:00:00 2001 From: Henrik Ingo Date: Mon, 10 Feb 2025 04:43:19 +0200 Subject: [PATCH] =?UTF-8?q?Enable=20Nyrki=C3=B6=20also=20on=20PRs.=20(Non-?= =?UTF-8?q?blocking=20mode.)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Rename push_only.yml workflow to rust_perf.yml - Move the 'bench' task from rust.yml to rust_perf.yml - More Nyrkio configuration options exposed: Team support (everyone in gh/tursodatabase can access Nyrkiö) Public results Alerting options: Comment on PR, if change detected, don't fail task --- .github/workflows/rust_perf.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust_perf.yml b/.github/workflows/rust_perf.yml index dd961ad87..f34b90bec 100644 --- a/.github/workflows/rust_perf.yml +++ b/.github/workflows/rust_perf.yml @@ -1,9 +1,8 @@ name: Rust Benchmarks+Nyrkiö -# Pull request support isn't integrated to the github-action-benchmark so run only post-merge on: push: - branches: [ "main", "master", "notmain", "add-nyrkio" ] + branches: [ "main", "master", "notmain" ] pull_request: branches: [ "main", "notmain", "master" ] @@ -41,12 +40,12 @@ jobs: output-file-path: output.txt # What to do if a change is immediately detected by Nyrkiö. # Note that smaller changes are only detected with delay, usually after a change - # persisted over 2-7 commits. + # persisted over 2-7 commits. Go to nyrkiö.com to view those or configure alerts. # Note that Nyrkiö will find all changes, also improvements. This means fail-on-alert # on pull events isn't compatible with this workflow being required to pass branch protection. - fail-on-alert: true + fail-on-alert: false comment-on-alert: true - comment-always: true + comment-always: false # Nyrkiö configuration nyrkio-enable: true # Make results and change points public, so that any oss contributor can see them @@ -55,11 +54,16 @@ jobs: # Get yours from https://nyrkio.com/docs/getting-started nyrkio-token: ${{ secrets.STAGING_JWT_TOKEN }} nyrkio-api-root: https://staging.nyrkio.com/api/v0 - # nyrkio-org: nyrkio + # Make results and change points public, so that any oss contributor can see them + nyrkio-public: true nyrkio-settings-pvalue: 0.01% nyrkio-settings-threshold: 1% + # Team support = results are visible and manageable to everyone in the same Github org + # nyrkio-org: tursodatabase + # nyrkio-org: nyrkio # Old way... # Explicitly set this to null. We don't want threshold based alerts today. external-data-json-path: null gh-repository: null +