aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-18 17:14:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

cli: Fail import command if table does not exists

Browse Source 
SQLite creates a table if it does not exists, but we just silently
ignore the data. Let's add an error if table does not exist until we fix
this.

Refs #2079
This commit is contained in:
Pekka Enberg
2025-07-14 11:50:01 +03:00
parent 8f8d582b4a
commit b13a0bb549
1 changed files with 53 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
cli/commands/import.rs
View File

@@ -34,6 +34,59 @@ impl<'a> ImportFile<'a> {
}
pub fn import_csv(&mut self, args: ImportArgs) {
// Check if the target table exists
let table_check_query = format!(
"SELECT name FROM sqlite_master WHERE type='table' AND name='{}';",
args.table
);
match self.conn.query(table_check_query) {
Ok(rows) => {
if let Some(mut rows) = rows {
let mut table_exists = false;
loop {
match rows.step() {
Ok(turso_core::StepResult::Row) => {
table_exists = true;
break;
}
Ok(turso_core::StepResult::Done) => break,
Ok(turso_core::StepResult::IO) => {
rows.run_once().unwrap();
}
Ok(
turso_core::StepResult::Interrupt | turso_core::StepResult::Busy,
) => break,
Err(e) => {
let _ = self.writer.write_all(
format!("Error checking table existence: {e:?}\n").as_bytes(),
);
return;
}
}
}
if !table_exists {
let _ = self.writer.write_all(
format!("Error: no such table: {}\n", args.table).as_bytes(),
);
return;
}
} else {
let _ = self
.writer
.write_all(format!("Error: no such table: {}\n", args.table).as_bytes());
return;
}
}
Err(e) => {
let _ = self
.writer
.write_all(format!("Error checking table existence: {e:?}\n").as_bytes());
return;
}
}
let file = match File::open(args.file) {
Ok(file) => file,
Err(e) => {