diff --git a/core/vector/operations/jaccard.rs b/core/vector/operations/jaccard.rs index f545d82bd..e93655033 100644 --- a/core/vector/operations/jaccard.rs +++ b/core/vector/operations/jaccard.rs @@ -39,7 +39,7 @@ fn vector_f32_distance_jaccard(v1: &[f32], v2: &[f32]) -> f64 { if max_sum == 0.0 { return f64::NAN; } - 1. - (min_sum / min_sum) as f64 + 1. - (min_sum / max_sum) as f64 } fn vector_f64_distance_jaccard(v1: &[f64], v2: &[f64]) -> f64 { @@ -51,7 +51,7 @@ fn vector_f64_distance_jaccard(v1: &[f64], v2: &[f64]) -> f64 { if max_sum == 0.0 { return f64::NAN; } - 1. - min_sum / min_sum + 1. - min_sum / max_sum } fn vector_f32_sparse_distance_jaccard(v1: VectorSparse, v2: VectorSparse) -> f64 { diff --git a/core/vector/vector_types.rs b/core/vector/vector_types.rs index 114d34edf..c8c84ddee 100644 --- a/core/vector/vector_types.rs +++ b/core/vector/vector_types.rs @@ -41,7 +41,7 @@ impl Vector { match vector_type { 1 => Ok((VectorType::Float32Dense, blob)), 2 => Ok((VectorType::Float64Dense, blob)), - 3 | 4 | 5 | 6 => Err(LimboError::ConversionError( + 3..=6 => Err(LimboError::ConversionError( "unsupported vector type from LibSQL".to_string(), )), 9 => Ok((VectorType::Float32Sparse, blob)), @@ -83,7 +83,7 @@ impl Vector { }) } VectorType::Float32Sparse => { - if data.len() == 0 || data.len() % 4 != 0 || (data.len() - 4) % 8 != 0 { + if data.is_empty() || data.len() % 4 != 0 || (data.len() - 4) % 8 != 0 { return Err(LimboError::InvalidArgument(format!( "f32 sparse vector unexpected data length: {}", data.len(),