From aa4703c442538c54bcb8ab3b9bd205ace033c8ac Mon Sep 17 00:00:00 2001 From: Pere Diaz Bou Date: Wed, 12 Mar 2025 17:24:59 +0100 Subject: [PATCH] Fix read frame setting wrong offset When I added frame reading support I thought, okay, who cares about the page id of this page it we read it from a frame because we don't need it to compute the offset to read from the file in this case. Fuck me, because it was needed in case we read `page 1` from WAL because it has a differnt `offset`. --- core/storage/sqlite3_ondisk.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/storage/sqlite3_ondisk.rs b/core/storage/sqlite3_ondisk.rs index 066742417..d3c7ff431 100644 --- a/core/storage/sqlite3_ondisk.rs +++ b/core/storage/sqlite3_ondisk.rs @@ -1308,7 +1308,7 @@ pub fn begin_read_wal_frame( let frame = page.clone(); let complete = Box::new(move |buf: Arc>| { let frame = frame.clone(); - finish_read_page(2, buf, frame).unwrap(); + finish_read_page(page.get().id, buf, frame).unwrap(); }); let c = Completion::Read(ReadCompletion::new(buf, complete)); io.pread(offset, c)?;