From 9c473799275cd858e609f0afc2582e533d52b4ed Mon Sep 17 00:00:00 2001 From: PThorpe92 Date: Sat, 18 Jan 2025 15:23:33 -0500 Subject: [PATCH] Fix deref null ptr in Debug impl on external types --- extensions/core/src/types.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/extensions/core/src/types.rs b/extensions/core/src/types.rs index ce516e02b..5483a4875 100644 --- a/extensions/core/src/types.rs +++ b/extensions/core/src/types.rs @@ -46,7 +46,7 @@ impl Display for ResultCode { } #[repr(C)] -#[derive(PartialEq, Eq, Clone, Copy)] +#[derive(PartialEq, Debug, Eq, Clone, Copy)] pub enum ValueType { Null, Integer, @@ -64,6 +64,9 @@ pub struct Value { impl std::fmt::Debug for Value { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + if self.value.is_null() { + return write!(f, "{:?}: Null", self.value_type); + } match self.value_type { ValueType::Null => write!(f, "Value {{ Null }}"), ValueType::Integer => write!(f, "Value {{ Integer: {} }}", unsafe {