From 9bf5b9609fffd7b0dfc36dfd1ebbf3ef79be6064 Mon Sep 17 00:00:00 2001
From: Jussi Saurio <jussi.saurio@gmail.com>
Date: Sun, 16 Feb 2025 11:26:58 +0200
Subject: [PATCH] expr.rs: Binary: use translate_expr()'s impl for currently
 unsupported ops in translate_condition_expr()

---
 core/translate/expr.rs | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/core/translate/expr.rs b/core/translate/expr.rs
index e02ef73d6..da9b7a282 100644
--- a/core/translate/expr.rs
+++ b/core/translate/expr.rs
@@ -237,7 +237,19 @@ pub fn translate_condition_expr(
                 resolver,
             )?;
         }
-        ast::Expr::Binary(lhs, op, rhs) => {
+        ast::Expr::Binary(lhs, op, rhs)
+            if matches!(
+                op,
+                ast::Operator::Greater
+                    | ast::Operator::GreaterEquals
+                    | ast::Operator::Less
+                    | ast::Operator::LessEquals
+                    | ast::Operator::Equals
+                    | ast::Operator::NotEquals
+                    | ast::Operator::Is
+                    | ast::Operator::IsNot
+            ) =>
+        {
             let lhs_reg = program.alloc_register();
             let rhs_reg = program.alloc_register();
             translate_and_mark(program, Some(referenced_tables), lhs, lhs_reg, resolver)?;
@@ -267,11 +279,14 @@ pub fn translate_condition_expr(
                 ast::Operator::IsNot => {
                     emit_cmp_null_insn!(program, condition_metadata, Ne, Eq, lhs_reg, rhs_reg)
                 }
-                _ => {
-                    todo!("op {:?} not implemented", op);
-                }
+                _ => unreachable!(),
             }
         }
+        ast::Expr::Binary(_, _, _) => {
+            let result_reg = program.alloc_register();
+            translate_expr(program, Some(referenced_tables), expr, result_reg, resolver)?;
+            emit_cond_jump(program, condition_metadata, result_reg);
+        }
         ast::Expr::Literal(_)
         | ast::Expr::Cast { .. }
         | ast::Expr::FunctionCall { .. }