From 94b1cf9ab5184af35cba817f6ebd7893f38279de Mon Sep 17 00:00:00 2001 From: TcMits Date: Thu, 4 Sep 2025 12:09:21 +0700 Subject: [PATCH 1/3] windows iterator returns no values for shorter slice --- core/util.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/util.rs b/core/util.rs index 80845c8c9..18b4e835a 100644 --- a/core/util.rs +++ b/core/util.rs @@ -679,11 +679,11 @@ pub(crate) fn type_from_name(type_name: &str) -> (Type, bool) { return (Type::Integer, true); } - if let Some(ty) = type_name.windows(4).find_map(|s| { - if contains_ignore_ascii_case!(s, b"INT") { - return Some(Type::Integer); - } + if contains_ignore_ascii_case!(type_name, b"INT") { + return (Type::Integer, false); + } + if let Some(ty) = type_name.windows(4).find_map(|s| { match_ignore_ascii_case!(match s { b"CHAR" | b"CLOB" | b"TEXT" => Some(Type::Text), b"BLOB" => Some(Type::Blob), From ce6ff74cd647de6bf66add891be1f1354fd10700 Mon Sep 17 00:00:00 2001 From: TcMits Date: Thu, 4 Sep 2025 13:02:10 +0700 Subject: [PATCH 2/3] add test --- core/util.rs | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/core/util.rs b/core/util.rs index 18b4e835a..09ff97116 100644 --- a/core/util.rs +++ b/core/util.rs @@ -1370,6 +1370,7 @@ pub fn extract_view_columns(select_stmt: &ast::Select, schema: &Schema) -> Vec Date: Thu, 4 Sep 2025 13:04:53 +0700 Subject: [PATCH 3/3] make clippy happy --- core/util.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/util.rs b/core/util.rs index 09ff97116..097139d18 100644 --- a/core/util.rs +++ b/core/util.rs @@ -2379,7 +2379,7 @@ pub mod tests { for (input, expected) in tc { let result = type_from_name(input); - assert_eq!(result, expected, "Failed for input: {}", input); + assert_eq!(result, expected, "Failed for input: {input}"); } } }