From 96e3f7bc5c8408bf942def8feca2df335c06348d Mon Sep 17 00:00:00 2001 From: "Levy A." Date: Mon, 9 Jun 2025 19:07:36 -0300 Subject: [PATCH] refactor: remove magic number --- core/translate/alter.rs | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/core/translate/alter.rs b/core/translate/alter.rs index e07ca6470..5940b3d95 100644 --- a/core/translate/alter.rs +++ b/core/translate/alter.rs @@ -241,9 +241,12 @@ pub fn translate_alter_table( }); program.cursor_loop(cursor_id, |program, rowid| { - let first_column = program.alloc_registers(5); + let sqlite_schema_column_len = sqlite_schema.columns.len(); + assert_eq!(sqlite_schema_column_len, 5); - for i in 0..5 { + let first_column = program.alloc_registers(sqlite_schema_column_len); + + for i in 0..sqlite_schema_column_len { program.emit_column(cursor_id, i, first_column + i); } @@ -256,7 +259,7 @@ pub fn translate_alter_table( program.emit_string8_new_reg(rename_to.clone()); program.mark_last_insn_constant(); - let out = program.alloc_registers(5); + let out = program.alloc_registers(sqlite_schema_column_len); program.emit_insn(Insn::Function { constant_mask: 0, @@ -272,7 +275,7 @@ pub fn translate_alter_table( program.emit_insn(Insn::MakeRecord { start_reg: out, - count: 5, + count: sqlite_schema_column_len, dest_reg: record, index_name: None, }); @@ -319,9 +322,12 @@ pub fn translate_alter_table( }); program.cursor_loop(cursor_id, |program, rowid| { - let first_column = program.alloc_registers(5); + let sqlite_schema_column_len = sqlite_schema.columns.len(); + assert_eq!(sqlite_schema_column_len, 5); - for i in 0..5 { + let first_column = program.alloc_registers(sqlite_schema_column_len); + + for i in 0..sqlite_schema_column_len { program.emit_column(cursor_id, i, first_column + i); } @@ -347,7 +353,7 @@ pub fn translate_alter_table( program.emit_insn(Insn::MakeRecord { start_reg: out, - count: 5, + count: sqlite_schema_column_len, dest_reg: record, index_name: None, });