From aea6d942d68c66d566d249532f24253f87a35b16 Mon Sep 17 00:00:00 2001 From: Jussi Saurio Date: Thu, 7 Aug 2025 14:59:05 +0300 Subject: [PATCH] bench/insert: fix expected return value from pragma --- core/benches/benchmark.rs | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/core/benches/benchmark.rs b/core/benches/benchmark.rs index a23493fce..8ab2e89c4 100644 --- a/core/benches/benchmark.rs +++ b/core/benches/benchmark.rs @@ -551,14 +551,18 @@ fn bench_insert_rows(criterion: &mut Criterion) { sqlite_conn .pragma_update(None, "journal_mode", "WAL") .unwrap(); + sqlite_conn + .pragma_update(None, "locking_mode", "EXCLUSIVE") + .unwrap(); let journal_mode = sqlite_conn .pragma_query_value(None, "journal_mode", |row| row.get::<_, String>(0)) .unwrap(); assert_eq!(journal_mode.to_lowercase(), "wal"); let synchronous = sqlite_conn - .pragma_query_value(None, "synchronous", |row| row.get::<_, String>(0)) + .pragma_query_value(None, "synchronous", |row| row.get::<_, usize>(0)) .unwrap(); - assert_eq!(synchronous.to_lowercase(), "full"); + const FULL: usize = 2; + assert_eq!(synchronous, FULL); // Create test table sqlite_conn @@ -568,11 +572,6 @@ fn bench_insert_rows(criterion: &mut Criterion) { .pragma_update(None, "locking_mode", "EXCLUSIVE") .unwrap(); - // Create test table - sqlite_conn - .execute("CREATE TABLE test (id INTEGER, value TEXT)", []) - .unwrap(); - group.bench_function(format!("sqlite_insert_{batch_size}_rows"), |b| { let mut values = String::from("INSERT INTO test VALUES "); for i in 0..batch_size {