From 83af71f1409141192c3408591d3a1cf9c4c8a2a2 Mon Sep 17 00:00:00 2001 From: PThorpe92 Date: Sat, 5 Apr 2025 11:30:57 -0400 Subject: [PATCH] Return accidentally deleted comment on SeekGE insn from merge conflict --- core/vdbe/insn.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/core/vdbe/insn.rs b/core/vdbe/insn.rs index 4a6bc1ea4..8d3a9afca 100644 --- a/core/vdbe/insn.rs +++ b/core/vdbe/insn.rs @@ -484,10 +484,10 @@ pub enum Insn { target_pc: BranchOffset, }, - // cursor_id is a cursor pointing to a B-Tree index that uses integer keys, this op writes the value obtained from MakeRecord into the index. - // P3 + P4 are for the original column values that make up that key in unpacked (pre-serialized) form. - // If P5 has the OPFLAG_APPEND bit set, that is a hint to the b-tree layer that this insert is likely to be an append. - // OPFLAG_NCHANGE bit set, then the change counter is incremented by this instruction. If the OPFLAG_NCHANGE bit is clear, then the change counter is unchanged + /// cursor_id is a cursor pointing to a B-Tree index that uses integer keys, this op writes the value obtained from MakeRecord into the index. + /// P3 + P4 are for the original column values that make up that key in unpacked (pre-serialized) form. + /// If P5 has the OPFLAG_APPEND bit set, that is a hint to the b-tree layer that this insert is likely to be an append. + /// OPFLAG_NCHANGE bit set, then the change counter is incremented by this instruction. If the OPFLAG_NCHANGE bit is clear, then the change counter is unchanged IdxInsertAsync { cursor_id: CursorID, record_reg: usize, // P2 the register containing the record to insert @@ -498,6 +498,9 @@ pub enum Insn { IdxInsertAwait { cursor_id: CursorID, }, + + /// The P4 register values beginning with P3 form an unpacked index key that omits the PRIMARY KEY. Compare this key value against the index that P1 is currently pointing to, ignoring the PRIMARY KEY or ROWID fields at the end. + /// If the P1 index entry is greater or equal than the key value then jump to P2. Otherwise fall through to the next instruction. IdxGE { cursor_id: CursorID, start_reg: usize,