aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-18 00:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

javascript: Fix Statement.get() for boundary values

Browse Source
This commit is contained in:
Pekka Enberg
2025-08-19 14:00:01 +03:00
parent e99f189344
commit 6b59bcd51e
4 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
bindings/javascript/src/lib.rs
View File

@@ -281,12 +281,19 @@ impl Statement {
ValueType::Null => turso_core::Value::Null,
ValueType::Number => {
let n: f64 = unsafe { value.cast()? };
if n.fract() == 0.0 {
if n.fract() == 0.0 && n >= i64::MIN as f64 && n <= i64::MAX as f64 {
turso_core::Value::Integer(n as i64)
} else {
turso_core::Value::Float(n)
}
}
ValueType::BigInt => {
let bigint_str = value.coerce_to_string()?.into_utf8()?.as_str()?.to_owned();
let bigint_value = bigint_str.parse::<i64>().map_err(|e| {
Error::new(Status::NumberExpected, format!("Failed to parse BigInt: {e}"))
})?;
turso_core::Value::Integer(bigint_value)
}
ValueType::String => {
let s = value.coerce_to_string()?.into_utf8()?;
turso_core::Value::Text(s.as_str()?.to_owned().into())

12
packages/turso-serverless/src/protocol.ts
View File

@@ -89,12 +89,20 @@ export function encodeValue(value: any): Value {
}
if (typeof value === 'number') {
if (Number.isInteger(value)) {
return { type: 'integer', value: value.toString() };
if (!Number.isFinite(value)) {
throw new Error("Only finite numbers (not Infinity or NaN) can be passed as arguments");
}
return { type: 'float', value };
}
if (typeof value === 'bigint') {
return { type: 'integer', value: value.toString() };
}
if (typeof value === 'boolean') {
return { type: 'integer', value: value ? '1' : '0' };
}
if (typeof value === 'string') {
return { type: 'text', value };
}

11
testing/javascript/__test__/async.test.js
View File

@@ -279,6 +279,17 @@ test.serial("Statement.get() [raw]", async (t) => {
t.deepEqual(await stmt.raw().get(1), [1, "Alice", "alice@example.org"]);
});
test.serial("Statement.get() values", async (t) => {
const db = t.context.db;
const stmt = (await db.prepare("SELECT ?")).raw();
t.deepEqual(await stmt.get(1), [1]);
t.deepEqual(await stmt.get(Number.MIN_VALUE), [Number.MIN_VALUE]);
t.deepEqual(await stmt.get(Number.MAX_VALUE), [Number.MAX_VALUE]);
t.deepEqual(await stmt.get(Number.MAX_SAFE_INTEGER), [Number.MAX_SAFE_INTEGER]);
t.deepEqual(await stmt.get(9007199254740991n), [9007199254740991]);
});
// ==========================================================================
// Statement.iterate()
// ==========================================================================

2
testing/javascript/__test__/sync.test.js
View File

@@ -334,7 +334,7 @@ test.serial("Statement.get() [raw]", async (t) => {
t.deepEqual(stmt.raw().get(1), [1, "Alice", "alice@example.org"]);
});
test.skip("Statement.get() values", async (t) => {
test.serial("Statement.get() values", async (t) => {
const db = t.context.db;
const stmt = db.prepare("SELECT ?").raw();