From 68632cc1420774efcf2aed66dc3f12f4dd927c5d Mon Sep 17 00:00:00 2001 From: Nikita Sivukhin Date: Thu, 9 Oct 2025 17:26:36 +0400 Subject: [PATCH] rename euclidian to L2 for consistency --- core/function.rs | 7 +++---- core/translate/expr.rs | 2 +- core/vdbe/execute.rs | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/core/function.rs b/core/function.rs index b5a6503cc..e0e7b345c 100644 --- a/core/function.rs +++ b/core/function.rs @@ -156,7 +156,7 @@ pub enum VectorFunc { Vector64, VectorExtract, VectorDistanceCos, - VectorDistanceEuclidean, + VectorDistanceL2, VectorConcat, VectorSlice, } @@ -175,8 +175,7 @@ impl Display for VectorFunc { Self::Vector64 => "vector64".to_string(), Self::VectorExtract => "vector_extract".to_string(), Self::VectorDistanceCos => "vector_distance_cos".to_string(), - // We use `distance_l2` to reduce user input - Self::VectorDistanceEuclidean => "vector_distance_l2".to_string(), + Self::VectorDistanceL2 => "vector_distance_l2".to_string(), Self::VectorConcat => "vector_concat".to_string(), Self::VectorSlice => "vector_slice".to_string(), }; @@ -868,7 +867,7 @@ impl Func { "vector64" => Ok(Self::Vector(VectorFunc::Vector64)), "vector_extract" => Ok(Self::Vector(VectorFunc::VectorExtract)), "vector_distance_cos" => Ok(Self::Vector(VectorFunc::VectorDistanceCos)), - "vector_distance_l2" => Ok(Self::Vector(VectorFunc::VectorDistanceEuclidean)), + "vector_distance_l2" => Ok(Self::Vector(VectorFunc::VectorDistanceL2)), "vector_concat" => Ok(Self::Vector(VectorFunc::VectorConcat)), "vector_slice" => Ok(Self::Vector(VectorFunc::VectorSlice)), _ => crate::bail_parse_error!("no such function: {}", name), diff --git a/core/translate/expr.rs b/core/translate/expr.rs index 940c7a01e..835f1ea08 100644 --- a/core/translate/expr.rs +++ b/core/translate/expr.rs @@ -904,7 +904,7 @@ pub fn translate_expr( emit_function_call(program, func_ctx, &[regs, regs + 1], target_register)?; Ok(target_register) } - VectorFunc::VectorDistanceEuclidean => { + VectorFunc::VectorDistanceL2 => { let args = expect_arguments_exact!(args, 2, vector_func); let regs = program.alloc_registers(2); translate_expr(program, referenced_tables, &args[0], regs, resolver)?; diff --git a/core/vdbe/execute.rs b/core/vdbe/execute.rs index 1c63f54de..8f74268be 100644 --- a/core/vdbe/execute.rs +++ b/core/vdbe/execute.rs @@ -5210,7 +5210,7 @@ pub fn op_function( vector_distance_cos(&state.registers[*start_reg..*start_reg + arg_count])?; state.registers[*dest] = Register::Value(result); } - VectorFunc::VectorDistanceEuclidean => { + VectorFunc::VectorDistanceL2 => { let result = vector_distance_l2(&state.registers[*start_reg..*start_reg + arg_count])?; state.registers[*dest] = Register::Value(result);