Merge branch 'main' into update_offset

testing/cli_tests/cli_test_cases.py

@@ -264,6 +264,7 @@ def test_update_with_limit():
     limbo.quit()
 
 
+
 def test_update_with_limit_and_offset():
     limbo = TestLimboShell(
         "CREATE TABLE t (a,b,c); insert into t values (1,2,3), (4,5,6), (7,8,9), (1,2,3),(4,5,6), (7,8,9);"
@@ -288,6 +289,15 @@ def test_update_with_limit_and_offset():
         "update-limit-where-result", "SELECT COUNT(*) from t WHERE a = 333;", "0"
     )
     limbo.quit()
+    
+def test_insert_default_values():
+    limbo = TestLimboShell(
+        "CREATE TABLE t (a integer default(42),b integer default (43),c integer default(44));"
+    )
+    for _ in range(1, 10):
+        limbo.execute_dot("INSERT INTO t DEFAULT VALUES;")
+    limbo.run_test("insert-default-values", "SELECT * FROM t;", "42|43|44\n" * 9)
+    limbo.quit()
 
 
 if __name__ == "__main__":

testing/cli_tests/extensions.py

@@ -342,6 +342,7 @@ def test_kv():
     # first, create a normal table to ensure no issues
     limbo.execute_dot("CREATE TABLE other (a,b,c);")
     limbo.execute_dot("INSERT INTO other values (23,32,23);")
+    limbo = TestLimboShell()
     limbo.run_test_fn(
         "create virtual table t using kv_store;",
         lambda res: "Virtual table module not found: kv_store" in res,
@@ -350,6 +351,7 @@ def test_kv():
     limbo.debug_print(
         "create virtual table t using kv_store;",
     )
+    limbo.run_test_fn(".schema", lambda res: "CREATE VIRTUAL TABLE t" in res)
     limbo.run_test_fn(
         "insert into t values ('hello', 'world');",
         null,
@@ -496,12 +498,6 @@ def test_vfs():
         "Tested large write to testfs",
     )
     print("Tested large write to testfs")
-    # Pere: I commented this out because it added an extra row that made the test test_sqlite_vfs_compat fail
-    # it didn't segfault from my side so maybe this is necessary?
-    # # open regular db file to ensure we don't segfault when vfs file is dropped
-    # limbo.execute_dot(".open testing/vfs.db")
-    # limbo.execute_dot("create table test (id integer primary key, value float);")
-    # limbo.execute_dot("insert into test (value) values (1.0);")
     limbo.quit()
 
 
@@ -548,10 +544,10 @@ if __name__ == "__main__":
         test_aggregates()
         test_crypto()
         test_series()
-        test_kv()
         test_ipaddr()
         test_vfs()
         test_sqlite_vfs_compat()
+        test_kv()
     except Exception as e:
         print(f"Test FAILED: {e}")
         cleanup()