From 6252947232558c7a8a8ad24c2e4ed0b80be52b6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=A0=EC=9A=B0?= Date: Mon, 27 Jan 2025 19:49:10 +0900 Subject: [PATCH] Fix the logic on determining whether connection is closed --- .../java/org/github/tursodatabase/core/LimboConnection.java | 1 - .../java/org/github/tursodatabase/jdbc4/JDBC4Connection.java | 3 +-- .../org/github/tursodatabase/jdbc4/JDBC4ConnectionTest.java | 3 +++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bindings/java/src/main/java/org/github/tursodatabase/core/LimboConnection.java b/bindings/java/src/main/java/org/github/tursodatabase/core/LimboConnection.java index 402218b87..34e5692e3 100644 --- a/bindings/java/src/main/java/org/github/tursodatabase/core/LimboConnection.java +++ b/bindings/java/src/main/java/org/github/tursodatabase/core/LimboConnection.java @@ -31,7 +31,6 @@ public abstract class LimboConnection implements Connection { public LimboConnection(String url, String filePath, Properties properties) throws SQLException { this.database = open(url, filePath, properties); this.connectionPtr = this.database.connect(); - this.closed = true; } private static AbstractDB open(String url, String filePath, Properties properties) diff --git a/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java b/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java index 2fa24b2ea..3c32ffaf2 100644 --- a/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java +++ b/bindings/java/src/main/java/org/github/tursodatabase/jdbc4/JDBC4Connection.java @@ -88,8 +88,7 @@ public class JDBC4Connection extends LimboConnection { @Override public boolean isClosed() throws SQLException { - // TODO - return false; + return super.isClosed(); } @Override diff --git a/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ConnectionTest.java b/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ConnectionTest.java index cda7fce94..1bc4fb526 100644 --- a/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ConnectionTest.java +++ b/bindings/java/src/test/java/org/github/tursodatabase/jdbc4/JDBC4ConnectionTest.java @@ -68,13 +68,16 @@ class JDBC4ConnectionTest { @Test void calling_close_multiple_times_throws_no_exception() throws Exception { + assertFalse(connection.isClosed()); connection.close(); + assertTrue(connection.isClosed()); connection.close(); } @Test void calling_methods_on_closed_connection_should_throw_exception() throws Exception { connection.close(); + assertTrue(connection.isClosed()); assertThrows( SQLException.class, () ->