From 414f92d0a09e5d901ba8a2823defd68c28c02076 Mon Sep 17 00:00:00 2001 From: Pavan-Nambi Date: Thu, 9 Oct 2025 13:31:47 +0530 Subject: [PATCH] go back to for loop cleanup clippy --- core/translate/schema.rs | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/core/translate/schema.rs b/core/translate/schema.rs index ce8f40f7f..7191de03e 100644 --- a/core/translate/schema.rs +++ b/core/translate/schema.rs @@ -41,15 +41,17 @@ pub fn translate_create_table( } if let ast::CreateTableBody::ColumnsAndConstraints { columns, .. } = &body { - let mut indexes = (0..columns.len()).collect::>(); + for i in 0..columns.len() { + let col_i = &columns[i]; - indexes.sort_unstable_by_key(|&i| normalize_ident(columns[i].col_name.as_str())); - - for w in indexes.windows(2) { - let name1 = normalize_ident(columns[w[0]].col_name.as_str()); - let name2 = normalize_ident(columns[w[1]].col_name.as_str()); - if name1 == name2 { - bail_parse_error!("duplicate column name: {}", columns[w[0]].col_name.as_str()); + for j in &columns[(i + 1)..] { + if col_i + .col_name + .as_str() + .eq_ignore_ascii_case(j.col_name.as_str()) + { + bail_parse_error!("duplicate column name: {}", j.col_name.as_str()); + } } } }