From 3ff548b8c5dc96db85e6801610aaa8e7c622e8bf Mon Sep 17 00:00:00 2001 From: Henrik Ingo Date: Mon, 10 Feb 2025 04:28:52 +0200 Subject: [PATCH] Add explicitly all alerting options to workflow yml Set pvalue and threshold from workflow --- .github/workflows/rust_perf.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/rust_perf.yml b/.github/workflows/rust_perf.yml index 5a1b07ab9..d4cba22b3 100644 --- a/.github/workflows/rust_perf.yml +++ b/.github/workflows/rust_perf.yml @@ -33,15 +33,25 @@ jobs: name: turso tool: criterion output-file-path: output.txt + # What to do if a change is immediately detected by Nyrkiö. + # Note that smaller changes are only detected with delay, usually after a change + # persisted over 2-7 commits. + # Note that Nyrkiö will find all changes, also improvements. This means fail-on-alert + # on pull events isn't compatible with this workflow being required to pass branch protection. fail-on-alert: true + comment-on-alert: true + comment-always: true # Nyrkiö configuration nyrkio-enable: true # Make results and change points public, so that any oss contributor can see them nyrkio-public: true + # Get yours from https://nyrkio.com/docs/getting-started nyrkio-token: ${{ secrets.STAGING_JWT_TOKEN }} nyrkio-api-root: https://staging.nyrkio.com/api/v0 # nyrkio-org: nyrkio + nyrkio-settings-pvalue: 0.01% + nyrkio-settings-threshold: 1% # Old way... # Explicitly set this to null. We don't want threshold based alerts today.