From 216a8e78481ddfae9cd9d73a849a460d89b7f3c4 Mon Sep 17 00:00:00 2001
From: PThorpe92 <preston@unlockedlabs.org>
Date: Fri, 7 Mar 2025 07:38:20 -0500
Subject: [PATCH] Update getrandom dependency in ext api crate

---
 Cargo.lock                         | 2 +-
 extensions/core/Cargo.toml         | 6 ++++--
 extensions/core/README.md          | 5 +++++
 extensions/core/src/vfs_modules.rs | 2 +-
 4 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 34adaaf5d..b55e32afc 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1711,7 +1711,7 @@ name = "limbo_ext"
 version = "0.0.16"
 dependencies = [
  "chrono",
- "getrandom 0.2.15",
+ "getrandom 0.3.1",
  "limbo_macros",
 ]
 
diff --git a/extensions/core/Cargo.toml b/extensions/core/Cargo.toml
index da1552c8f..c6450a33d 100644
--- a/extensions/core/Cargo.toml
+++ b/extensions/core/Cargo.toml
@@ -12,6 +12,8 @@ core_only = []
 static = []
 
 [dependencies]
-chrono = "0.4.40"
-getrandom = { version = "0.2.15", features = ["js"] }
 limbo_macros = { workspace = true }
+
+[target.'cfg(not(target_family = "wasm"))'.dependencies]
+getrandom = "0.3.1"
+chrono = "0.4.40"
diff --git a/extensions/core/README.md b/extensions/core/README.md
index 8ffd8a6ab..ae848b0d7 100644
--- a/extensions/core/README.md
+++ b/extensions/core/README.md
@@ -59,9 +59,14 @@ register_extension!{
     scalars: { double }, // name of your function, if different from attribute name
     aggregates: { Percentile },
     vtabs: { CsvVTable },
+    vfs: { ExampleFS },
 }
 ```
 
+**NOTE**: Currently, any Derive macro used from this crate is required to be in the same
+file as the `register_extension` macro.
+
+
 ### Scalar Example:
 ```rust
 use limbo_ext::{register_extension, Value, scalar};
diff --git a/extensions/core/src/vfs_modules.rs b/extensions/core/src/vfs_modules.rs
index 556b5edda..67fd7c020 100644
--- a/extensions/core/src/vfs_modules.rs
+++ b/extensions/core/src/vfs_modules.rs
@@ -14,7 +14,7 @@ pub trait VfsExtension: Default + Send + Sync {
     }
     fn generate_random_number(&self) -> i64 {
         let mut buf = [0u8; 8];
-        getrandom::getrandom(&mut buf).unwrap();
+        getrandom::fill(&mut buf).unwrap();
         i64::from_ne_bytes(buf)
     }
     fn get_current_time(&self) -> String {