diff --git a/core/json/mod.rs b/core/json/mod.rs index a27979f58..758737815 100644 --- a/core/json/mod.rs +++ b/core/json/mod.rs @@ -319,6 +319,8 @@ pub fn json_object(values: &[OwnedValue]) -> crate::Result { [key, value] => { let key = match key { // TODO: is this tp_string call ok? + // TODO: We can construct the IndexMap from Rc, but we must enable the + // serde's `rc` feature so we can serialize Rc OwnedValue::Text(t) => t.value.to_string(), // TODO: I matched sqlite message error here. Is this ok? _ => crate::bail_constraint_error!("labels must be TEXT"),