aljaz/tiingo-python
1
1
Fork 0
mirror of https://github.com/hydrosquall/tiingo-python.git synced 2025-12-17 20:04:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor News Method

Browse Source
This commit is contained in:
Cameron Yick
2017-09-17 15:21:03 -04:00
parent 14d3bb6bd3
commit febffd76da
2 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/test_tiingo.py
View File

@@ -90,16 +90,19 @@ class TestNews(TestCase):
def test_get_news_articles(self): def test_get_news_articles(self):
"""Confirm that news article work""" """Confirm that news article work"""
NUM_ARTICLES = 10
search_params = { search_params = {
"tickers": ["aapl", "googl"], "tickers": ["aapl", "googl"],
"tags": ["Technology", "Bitcoin"], "tags": ["Technology", "Bitcoin"],
"startDate": "2016-01-01", "startDate": "2016-01-01",
"endDate": "2017-08-31", "endDate": "2017-08-31",
"sources": ['washingtonpost.com', 'altcointoday.com'], "sources": ['washingtonpost.com', 'altcointoday.com'],
"limit": 10 "limit": NUM_ARTICLES
} }
articles = self._client.get_news(**search_params) articles = self._client.get_news(**search_params)
assert len(articles) == NUM_ARTICLES
for article in articles: for article in articles:
assert all(key in article for key in self.article_keys) assert all(key in article for key in self.article_keys)

21
tiingo/api.py
View File

@@ -109,22 +109,13 @@ class TiingoClient(RestClient):
params = { params = {
'limit': limit, 'limit': limit,
'offset': offset, 'offset': offset,
'sortBy': sortBy 'sortBy': sortBy,
'tickers': tickers,
'sources': sources,
'tags': tags,
'startDate': startDate,
'endDate': endDate
} }
# TBD: whether these commas are necessary if just pass list instead
if tickers:
params['tickers'] = ",".join(tickers)
if tags:
params['tags'] = ",".join(tags)
if sources:
params['sources'] = ",".join(sources)
if startDate:
params['startDate'] = startDate
if endDate:
params['endDate'] = endDate
response = self._request('GET', url, params=params) response = self._request('GET', url, params=params)
return response.json() return response.json()