[errors] Be more specific about requiring tickers as list

This commit is contained in:
Cameron Yick
2019-04-29 23:19:49 -04:00
parent 61708c3291
commit 922812a026
2 changed files with 8 additions and 3 deletions

View File

@@ -9,8 +9,14 @@ import sys
import pkg_resources import pkg_resources
from zipfile import ZipFile from zipfile import ZipFile
import requests
from tiingo.restclient import RestClient from tiingo.restclient import RestClient
from tiingo.exceptions import InstallPandasException, APIColumnNameError, InvalidFrequencyError, MissingRequiredArgumentError from tiingo.exceptions import (
InstallPandasException,
APIColumnNameError,
InvalidFrequencyError,
MissingRequiredArgumentError)
try: try:
import pandas as pd import pandas as pd
@@ -223,7 +229,7 @@ class TiingoClient(RestClient):
if metric_name is not None and metric_name not in valid_columns: if metric_name is not None and metric_name not in valid_columns:
raise APIColumnNameError('Valid data items are: ' + str(valid_columns)) raise APIColumnNameError('Valid data items are: ' + str(valid_columns))
if metric_name is None and type(tickers) is not str: if metric_name is None and isinstance(tickers, list):
raise MissingRequiredArgumentError("""When tickers is provided as a list, metric_name is a required argument. raise MissingRequiredArgumentError("""When tickers is provided as a list, metric_name is a required argument.
Please provide a metric_name, or call this method with one ticker at a time.""") Please provide a metric_name, or call this method with one ticker at a time.""")

View File

@@ -10,6 +10,5 @@ class APIColumnNameError(Exception):
class InvalidFrequencyError(Exception): class InvalidFrequencyError(Exception):
pass pass
class MissingRequiredArgumentError(Exception): class MissingRequiredArgumentError(Exception):
pass pass