scrcpy

mirror of https://github.com/Genymobile/scrcpy.git synced 2026-02-07 15:04:27 +01:00

Files

Romain Vimont afbaf59abb Cast to sc_tick type in conversion macros

With the old macros definitions, the type of the result depended on the
type of `sec`.

In particular, if sec is a 32-bit type, sec * 1000000 was likely to
overflow (even if the result was assigned to a sc_tick by the caller of
the macro).

This was the case on Windows, where the long type is a 32-bit signed
integer: the --time-limit argument, expressed in seconds, was first
parsed to a long value, then multiplied by 1000000 by the
SC_TICK_FROM_SEC() macro, causing an overflow when the value was greater
than 2147 (2^31 / 1000000).

Fixes #5355 <https://github.com/Genymobile/scrcpy/issues/5355>

2024-10-08 18:18:05 +02:00