aljaz/scrcpy
1
0
Fork 0
mirror of https://github.com/Genymobile/scrcpy.git synced 2026-02-20 21:34:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
2,005 Commits 643 Branches 60 Tags
b65301f672e852fe2f3fded1fac2091c85679c35
Commit Graph

25 Commits

Author SHA1 Message Date
Romain Vimont
64a04b8d4a Fix process execution on Windows 7 
According to this bug report on Firefox:
<https://bugzilla.mozilla.org/show_bug.cgi?id=1460995>

> CreateProcess fails with ERROR_NO_SYSTEM_RESOURCES on Windows 7. It
> looks like the reason why is because PROC_THREAD_ATTRIBUTE_HANDLE_LIST
> doesn't like console handles.

To avoid the problem, do not pass console handles to
PROC_THREAD_ATTRIBUTE_HANDLE_LIST.

Refs #2783 <https://github.com/Genymobile/scrcpy/pull/2783>
Refs f801d8b312
Fixes #2838 <https://github.com/Genymobile/scrcpy/issues/2838>
PR #2840 <https://github.com/Genymobile/scrcpy/pull/2840>
 2021-12-01 18:02:35 +01:00
Romain Vimont
86c91e183d Log CreateProcessW() error code on Windows 
Refs #2838 <https://github.com/Genymobile/scrcpy/issues/2838>
 2021-11-30 09:41:47 +01:00
Romain Vimont
f801d8b312 Expose flags for process execution 
Let the caller decide if stdout and stderr must be inherited on process
creation, i.e. if stdout and stderr of the child process should be
printed in the scrcpy console.

This allows to get output and errors for specific adb commands depending
on the context.

PR #2827 <https://github.com/Genymobile/scrcpy/pull/2827>
 2021-11-29 20:39:03 +01:00
Romain Vimont
b9b8b6aab8 Simplify Windows process inheritance configuration 
Merge if-blocks together.
 2021-11-26 09:41:11 +01:00
Romain Vimont
3653fb6b15 Add OutOfMemory log helper 
Add a special LOG_OOM() function to log all OutOfMemory errors (i.e.
allocations returning NULL).
 2021-11-24 22:06:49 +01:00
Romain Vimont
ba547e3895 Configure feature test macros in meson 
Refs #2807 <https://github.com/Genymobile/scrcpy/pull/2807>

Co-authored-by: RipleyTom <RipleyTom@users.noreply.github.com>
 2021-11-21 00:20:11 +01:00
Romain Vimont
9cb14b5166 Inherit only specific handles on Windows 
To be able to communicate with a child process via stdin, stdout and
stderr, the CreateProcess() parameter bInheritHandles must be set to
TRUE. But this causes *all* handles to be inherited, including sockets.

As a result, the server socket was inherited by the process running adb
to execute the server on the device, so it could not be closed properly,
causing other scrcpy instances to fail.

To fix the issue, use an extended API to explicitly set the HANDLEs to
inherit:
 - <https://stackoverflow.com/a/28185363/1987178>
 - <https://devblogs.microsoft.com/oldnewthing/20111216-00/?p=8873>

Fixes #2779 <https://github.com/Genymobile/scrcpy/issues/2779>
PR #2783 <https://github.com/Genymobile/scrcpy/pull/2783>
 2021-11-15 10:13:30 +01:00
Romain Vimont
9cb8766220 Factorize resource release after CreateProcess() 
Free the wide characters string in all cases before checking for errors.
 2021-11-15 07:49:01 +01:00
Romain Vimont
fd4ec784e0 Remove useless assignments on error 
Leave the output parameter untouched on error.
 2021-11-14 22:53:49 +01:00
Romain Vimont
52cebe1597 Fix Windows sc_pipe function names 
The implementation name was incorrect (it was harmless, because they are
not used on Windows).
 2021-11-14 22:41:38 +01:00
Romain Vimont
057c7a4df4 Move str_util to str 
Simplify naming.
 2021-11-14 01:22:22 +01:00
Romain Vimont
979ce64dc0 Improve string util API 
Use prefixed names and improve documentation.
 2021-11-14 01:22:22 +01:00
Romain Vimont
aa011832c1 Improve process API 
Prefix symbols and constants names and improve documentation.
 2021-11-12 22:44:37 +01:00
Romain Vimont
7e93abcf6d Factorize common impl of process_execute() 
Both implementations are the same. Move them to the common process.c.
 2021-11-12 22:44:37 +01:00
Romain Vimont
d4c262301f Move functions from process to file 
Move filesystem-related functions from process.[ch] to file.[ch].
 2021-11-12 22:44:37 +01:00
Romain Vimont
eaf4afaad9 Add command execution with redirection 
Expose command execution with pipes to stdin, stdout and stderr.

This will allow to read the result of adb commands.
 2021-10-26 21:30:04 +02:00
Wirtos_new
a9d9cbf8b5 Replace VLA by dynamic allocation 
And increase the command buffer size.

Refs #1358 <https://github.com/Genymobile/scrcpy/issues/1358#issuecomment-862989748>
PR #2405 <https://github.com/Genymobile/scrcpy/pull/2405>

Signed-off-by: Romain Vimont <rom@rom1v.com>
 2021-06-20 21:16:42 +02:00
Romain Vimont
710e80aa0d Return build_cmd() success via a boolean 
For consistency with other functions in the codebase.
 2021-06-20 21:16:42 +02:00
Romain Vimont
30e619d37f Replace SDL_strdup() by strdup() 
The functions SDL_malloc(), SDL_free() and SDL_strdup() were used only
because strdup() was not available everywhere.

Now that it is available, use the native version of these functions.
 2021-02-17 09:54:03 +01:00
Romain Vimont
6a50231698 Expose a single process_wait() 
There were two versions: process_wait() and process_wait_noclose().

Expose a single version with a flag (it was already implemented that way
internally).
 2021-01-24 14:24:18 +01:00
Romain Vimont
b8edcf52b0 Simplify process_wait() 
The function process_wait() returned a bool (true if the process
terminated successfully) and provided the exit code via an output
parameter exit_code.

But the returned value was always equivalent to exit_code == 0, so just
return the exit code instead.
 2021-01-22 18:29:21 +01:00
Romain Vimont
59feb2a15c Group common includes into common.h 
Include config.h and compat.h in common.h, and include common.h from all
source files.
 2021-01-08 19:22:10 +01:00
Romain Vimont
d580ee30f1 Separate process wait and close 
On Linux, waitpid() both waits for the process to terminate and reaps it
(closes its handle). On Windows, these actions are separated into
WaitForSingleObject() and CloseHandle().

Expose these actions separately, so that it is possible to send a signal
to a process while waiting for its termination without race condition.

This allows to wait for server termination normally, but kill the
process without race condition if it is not terminated after some delay.
 2021-01-08 16:44:21 +01:00
Romain Vimont
821c175730 Rename process_simple_wait to process_wait 
Adding "simple" in the function name brings no benefit.
 2021-01-08 16:44:21 +01:00
Romain Vimont
4bd9da4c93 Split command into process and adb 
The process API provides the system-specific implementation, the adb API
uses it to expose adb commands.
 2021-01-08 16:44:21 +01:00