From fde02a7dfa3bcf7c583b7399e5d4b6c9d83baebd Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Fri, 9 Jan 2026 19:06:08 +0100 Subject: [PATCH] Fix segfault with --no-video Do not call SDL_RectToFRect() if geometry is NULL. Bug introduced by 02989249f6a992090a70c4d61e0834a990f004fa. --- app/src/display.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/display.c b/app/src/display.c index 3050966c..44603696 100644 --- a/app/src/display.c +++ b/app/src/display.c @@ -389,8 +389,12 @@ sc_display_render(struct sc_display *display, const SDL_Rect *geometry, if (orientation == SC_ORIENTATION_0) { SDL_FRect frect; - SDL_RectToFRect(geometry, &frect); - bool ok = SDL_RenderTexture(renderer, texture, NULL, &frect); + SDL_FRect *fgeometry = NULL; + if (geometry) { + SDL_RectToFRect(geometry, &frect); + fgeometry = &frect; + } + bool ok = SDL_RenderTexture(renderer, texture, NULL, fgeometry); if (!ok) { LOGE("Could not render texture: %s", SDL_GetError()); return SC_DISPLAY_RESULT_ERROR;