Files
python-teos/watchtower-plugin/net/http.py
Sergi Delgado Segura 43217874b5 Splits add_appointment so it can also be used by the Retrier
- The appointment constructions is left in Watchtower (via on_commit_revocation method)
- The tower interaction is moved to net/http so it can be reused
- Adds missing logic for invalid resposes by the tower (e.g invalid signatures)
2020-04-29 14:14:01 +02:00

147 lines
5.8 KiB
Python

import json
import requests
from requests import ConnectionError, ConnectTimeout
from requests.exceptions import MissingSchema, InvalidSchema, InvalidURL
from common import errors
from common import constants
from common.appointment import Appointment
from common.exceptions import SignatureError
from common.cryptographer import Cryptographer
from exceptions import TowerConnectionError, TowerResponseError
def add_appointment(plugin, tower_id, tower_info, appointment_dict, signature):
try:
plugin.log("Sending appointment to {}".format(tower_id))
response = send_appointment(tower_id, tower_info, appointment_dict, signature)
plugin.log("Appointment accepted and signed by {}".format(tower_id))
plugin.log("Remaining slots: {}".format(response.get("available_slots")))
# TODO: Not storing the whole appointments for now. The node can recreate all the data if needed.
# DISCUSS: It may be worth checking that the available slots match instead of blindly trusting.
tower_info.appointments[appointment_dict.get("locator")] = response.get("signature")
tower_info.available_slots = response.get("available_slots")
tower_info.status = "reachable"
except SignatureError as e:
plugin.log("{} is misbehaving, not using it any longer".format(tower_id))
tower_info.status = "misbehaving"
tower_info.invalid_appointments.append((appointment_dict, e.kwargs.get("signature")))
except TowerConnectionError:
# All TowerConnectionError are transitory. The connection is tried on register, so the URL cannot be malformed.
# Flag appointment for retry
plugin.log("{} cannot be reached. Adding appointment to pending".format(tower_id))
tower_info.status = "temporarily unreachable"
except TowerResponseError as e:
data = e.kwargs.get("data")
status_code = e.kwargs.get("status_code")
if data and status_code == constants.HTTP_BAD_REQUEST:
if data.get("error_code") == errors.APPOINTMENT_INVALID_SIGNATURE_OR_INSUFFICIENT_SLOTS:
plugin.log("There is a subscription issue with {}. Adding appointment to pending".format(tower_id))
tower_info.status = "subscription error"
elif data.get("error_code") >= errors.INVALID_REQUEST_FORMAT:
plugin.log("Appointment sent to {} is invalid".format(tower_id))
tower_info.status = "reachable"
# DISCUSS: It may be worth backing up the data since otherwise the update is dropped
elif status_code == constants.HTTP_SERVICE_UNAVAILABLE:
# Flag appointment for retry
plugin.log("{} is temporarily unavailable. Adding appointment to pending".format(tower_id))
tower_info.status = "temporarily unreachable"
else:
# Log unexpected behaviour
plugin.log(str(e), level="warn")
return tower_info.status
def send_appointment(tower_id, tower_info, appointment_dict, signature):
data = {"appointment": appointment_dict, "signature": signature}
add_appointment_endpoint = "{}/add_appointment".format(tower_info.netaddr)
response = process_post_response(post_request(data, add_appointment_endpoint, tower_id))
signature = response.get("signature")
# Check that the server signed the appointment as it should.
if not signature:
raise SignatureError("The response does not contain the signature of the appointment", signature=None)
rpk = Cryptographer.recover_pk(Appointment.from_dict(appointment_dict).serialize(), signature)
if tower_id != Cryptographer.get_compressed_pk(rpk):
raise SignatureError(
"The returned appointment's signature is invalid", tower_id=tower_id, rpk=rpk, signature=signature
)
return response
def post_request(data, endpoint, tower_id):
"""
Sends a post request to the tower.
Args:
data (:obj:`dict`): a dictionary containing the data to be posted.
endpoint (:obj:`str`): the endpoint to send the post request.
tower_id (:obj:`str`): the identifier of the tower to connect to (a compressed public key).
Returns:
:obj:`dict`: a json-encoded dictionary with the server response if the data can be posted.
Raises:
:obj:`ConnectionError`: if the client cannot connect to the tower.
"""
try:
return requests.post(url=endpoint, json=data, timeout=5)
except ConnectTimeout:
message = "Cannot connect to {}. Connection timeout".format(tower_id)
except ConnectionError:
message = "Cannot connect to {}. Tower cannot be reached".format(tower_id)
except (InvalidSchema, MissingSchema, InvalidURL):
message = "Invalid URL. No schema, or invalid schema, found (url={}, tower_id={}).".format(endpoint, tower_id)
raise TowerConnectionError(message)
def process_post_response(response):
"""
Processes the server response to a post request.
Args:
response (:obj:`requests.models.Response`): a ``Response`` object obtained from the request.
Returns:
:obj:`dict`: a dictionary containing the tower's response data if the response type is
``HTTP_OK``.
Raises:
:obj:`TowerResponseError <cli.exceptions.TowerResponseError>`: if the tower responded with an error, or the
response was invalid.
"""
try:
response_json = response.json()
except (json.JSONDecodeError, AttributeError):
raise TowerResponseError(
"The server returned a non-JSON response", status_code=response.status_code, reason=response.reason
)
if response.status_code not in [constants.HTTP_OK, constants.HTTP_NOT_FOUND]:
raise TowerResponseError(
"The server returned an error", status_code=response.status_code, reason=response.reason, data=response_json
)
return response_json